Received: by 10.213.65.68 with SMTP id h4csp870879imn; Wed, 28 Mar 2018 14:39:20 -0700 (PDT) X-Google-Smtp-Source: AIpwx49Ay59DcZMYFHCeVDYhsNW9mHyJAUGWBOfaxaiScRbgouDuyga7G8Mqn1ZYX8lfuUHbkRBc X-Received: by 2002:a17:902:341:: with SMTP id 59-v6mr5220528pld.407.1522273160579; Wed, 28 Mar 2018 14:39:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522273160; cv=none; d=google.com; s=arc-20160816; b=yL0o04vxd5YXK4YKcWmzipgYRWw4gP1Viz1XXo4BKyBVmrRBFAgMpRpNcwGsCt6qST 0iU8TKpMeHc/VHJOdy0PyVEZV0mLmp474NAEudmb931pMK1fBKyxePb+E18Fj/20uO2P b4oclMC3+KzR7f8+fqX11w/EU9aLWns761G7DAIXMgx41WXzEAQzS0WVXbrFYHvZAwIO a2qDu/z8GGIhAIBA9GKQV9uMrXYV5IqqPmkRZO+aK4+oh1LqG1Ns6D5pmLhLsyKDF9Wh juIGaCJWXDY3UOb1kRUDlXpEnaJvhjzyA0qCKwpQXXaY9R3uUUo227zOLIBYhzf0jHDT Hgjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=R/uz8bjKXsjIELboBtP317xpJrps0eKm77F0FyDCjKY=; b=kEXD1JwuByitnnWxYba18hrAngeLbAmner9SFJtwoqTTVtVgR+VVT62u0HWc/yOOcV z/AeUpvgwF0kH3yu9jzqyAa5fmvxEjrnco9mn3pMOmRXaOVcHKURmV0ryt84/w+JdVzX HI3wi2X2A/XFU2T3tiZNH2El6NLH4Lgg53B5zakOZOE5SiqEk2JJS5Nmm4KpQL9DPHx0 dst2G/VQKBvNFxoKcPTSWh1x9tUSDk64R/Bt33lvWxvBMPSjDKliBuMCAn0erwVl31E0 EDtMDnpVJ7zXGIkk8zUiro/d9BckICc+4uJZj7zaiRk7zsXR6MK4vezLK0bwijowI2IK dIKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@babblebit.net header.s=mail header.b=NBwHopey; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=babblebit.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o61-v6si4307799pld.646.2018.03.28.14.39.05; Wed, 28 Mar 2018 14:39:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@babblebit.net header.s=mail header.b=NBwHopey; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=babblebit.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbeC1ViM (ORCPT + 99 others); Wed, 28 Mar 2018 17:38:12 -0400 Received: from mail.babblebit.net ([37.139.8.208]:47344 "EHLO mail.babblebit.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753002AbeC1ViL (ORCPT ); Wed, 28 Mar 2018 17:38:11 -0400 X-Greylist: delayed 1107 seconds by postgrey-1.27 at vger.kernel.org; Wed, 28 Mar 2018 17:38:11 EDT Received: from localhost.localdomain (79-75-32-4.dynamic.dsl.as9105.com [79.75.32.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.babblebit.net (Postfix) with ESMTPSA id 0D1DD12010C; Wed, 28 Mar 2018 21:19:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=babblebit.net; s=mail; t=1522271982; bh=J2kAql4/VZdbenN/xX9QQ6NSVARIF1eyaYdLt8JZlaA=; h=From:To:Cc:Subject:Date:From; b=NBwHopeywIoXDTURMYKel6L07g40E8OBqLpMJENCsqfJmF/7oOfVBLON3TrOAPPEG Jbur2r7Bney0NBovkZVaGrA+yvL7nqxwY3byNek7mKnBuKC3yXByGU53xPu711MKVs Rg+E+NYRVO0Yo1LoOvZN75hrHg9U8RZU3iA9RbNM= From: Chris Coffey To: Greg Kroah-Hartman , NeilBrown , Matthias Brugger Cc: devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Chris Coffey Subject: [PATCH] staging: mt7621-eth: Fix sparse warning in ethtool.c Date: Wed, 28 Mar 2018 22:18:48 +0100 Message-Id: <20180328211848.11085-1-cmc@babblebit.net> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include the local ethtool.h header file in mtk_eth_soc.h so implementation files have centralized access to it. This fixes the following sparse warning: drivers/staging/mt7621-eth/ethtool.c:213:6: warning: symbol 'mtk_set_ethtool_ops' was not declared. Should it be static? Signed-off-by: Chris Coffey --- drivers/staging/mt7621-eth/mtk_eth_soc.c | 1 - drivers/staging/mt7621-eth/mtk_eth_soc.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c index cbc7339843..0574e71573 100644 --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c @@ -35,7 +35,6 @@ #include "mtk_eth_soc.h" #include "mdio.h" -#include "ethtool.h" #define MAX_RX_LENGTH 1536 #define MTK_RX_ETH_HLEN (VLAN_ETH_HLEN + VLAN_HLEN + ETH_FCS_LEN) diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.h b/drivers/staging/mt7621-eth/mtk_eth_soc.h index 443f88d8af..01deeddfdd 100644 --- a/drivers/staging/mt7621-eth/mtk_eth_soc.h +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.h @@ -23,6 +23,7 @@ #include #include #include +#include "ethtool.h" /* these registers have different offsets depending on the SoC. we use a lookup * table for these -- 2.11.0