Received: by 10.213.65.68 with SMTP id h4csp916472imn; Wed, 28 Mar 2018 15:43:41 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+K/X1rhJZwFIjf9zhSF3aIZIipA2kM/fX5oUXS2qMWOEdeH4m8OiPKV/lNTLHMkleXBdxh X-Received: by 2002:a17:902:4d45:: with SMTP id o5-v6mr5771246plh.84.1522277020995; Wed, 28 Mar 2018 15:43:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522277020; cv=none; d=google.com; s=arc-20160816; b=ofele0R8PYATQGIcu09slTtQJ+0MLg5V/wov9I+PI5le/co/zt1OLtHOgh5kICXjid nHUIng7ue9o/khL05iIcU7dnLn2uh4V6Sa698tOpDONw98NTCuFG2anV/FPkd6D6lCHN 9V4ghFvaFgS/b8qPTdH67nsHyBGYvOwWugObL9MjETPesYXyH1PovSUvvec8lUAgdYNQ 6HwiSj750a/4Fp8vgjyxsabyRlFzZ+xvzEDon52MIdKnMc6FGcu32Hfc0V8Y7t/mXLOi DOvBH2W388fy6wN8r4vVglhpB5jXdcBOed0sxpKhNghHEewcHpWG2V1V3EdiUA9kAhZc K2QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=P3DCgoMd0xA4xlW34kg4SISrKVdeTKpl36Ff9ndxXvQ=; b=HI87XN+ns6UH1kXem6Kevk0vbsa+A7XjNxexI1GgMH7oaY5njGq0ET2Dv5ngt7cM+5 HgxHuV9fmWvFYiVUaPdATkFUMmTBJJvVJYNwLSCL59y+zCMhvRAmS51Vpq4UgY79/gaZ zDc9OleTZ+doJJXA1aSsqagtxxO/u5iEvNi9u4NMyDajHKzUZ6XtxgjRtCfl7UjQGv/u fx6NsFp64NeSvZm+5PFz8odVEp16ZDouQPga6LM65aI8ljnULPaSC9wovmmPcBPFfhQ5 qodyq7ltpuMmiVCS+V5VO7ZfSCtN6z2f7FvBBGTMZ3jNk1RO/NpCb+Uvdcpq3OeWpY3H j3QA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=SQ2HA418; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b34-v6si4534964pld.249.2018.03.28.15.43.26; Wed, 28 Mar 2018 15:43:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=SQ2HA418; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753879AbeC1Wmh (ORCPT + 99 others); Wed, 28 Mar 2018 18:42:37 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:20385 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753423AbeC1Wmf (ORCPT ); Wed, 28 Mar 2018 18:42:35 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by fllnx210.ext.ti.com (8.15.1/8.15.1) with ESMTP id w2SMfJkS005385; Wed, 28 Mar 2018 17:41:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1522276879; bh=UhF1OA9CQB6XqNv5jvkwFeD9vL+yewTQYsBcpmYNG/I=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=SQ2HA418PrnEJKbk8zJrZbFHr1Zh4DrnectIAZoLjZnMMN1hE7gLz6FRXUovJ1GUt Esyk+2rF9x9MhYysZ4prjqgrFSvBJIvy7omB9LqQE5wgMgbUrQA0376AIY89XXR71n L7FxMBYLD/YE666S0sdltKxtbtIAQHkL4Z7nVtuU= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w2SMfJLY032129; Wed, 28 Mar 2018 17:41:19 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Wed, 28 Mar 2018 17:41:18 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Wed, 28 Mar 2018 17:41:18 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w2SMfIog013410; Wed, 28 Mar 2018 17:41:18 -0500 Subject: Re: [PATCH v3 0/8] ARM: davinci: complete the conversion to using the reset framework To: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Rob Herring , Mark Rutland , Russell King , David Lechner , Michael Turquette , Stephen Boyd , Ohad Ben-Cohen , Bjorn Andersson , Philipp Zabel CC: , , , , , Bartosz Golaszewski References: <20180327092031.11251-1-brgl@bgdev.pl> From: Suman Anna Message-ID: Date: Wed, 28 Mar 2018 17:41:18 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180327092031.11251-1-brgl@bgdev.pl> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, On 03/27/2018 04:20 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > This series converts the only user of the handcoded, mach-specific reset > routines in the davinci platform to using the reset framework. > > Patches 1-3 add necessary lookups/DT-properties. > > Patches 4-6 fix issues found in the remoteproc davinci driver. Can you pick up patches 4 through 6 for 4.17 itself through the remoteproc tree? They can be picked up independent of the CCF conversion. Anyway, the actual CCF conversion and the reset framework adaptation patch would need the dts patches to be picked up first to maintain functionality, and I do not think Sekhar is picking up the dts changes for 4.17 this late. regards Suman > > Patch 7 converts the davinci-rproc driver to the reset framework. > > Patch 8 removes now dead code. > > Philipp: it turned out that it's indeed better to use the reset > controller's device name for the entry lookup. > > Tested both in DT and legacy modes by booting the examples from > ti-ipc-rtos recipe in meta-ti. > > This series applies on top of David Lechner's common-clk-v9 branch[1] > with Philipp Zabel's reset/next branch[2] pulled in. > > It can be found in my github tree as well[3]. > > [1] git://github.com/dlech/ev3dev-kernel.git common-clk-v9 > [2] git://git.pengutronix.de/git/pza/linux reset/next > [3] git@github.com:brgl/linux.git topic/davinci-reset > > v1 -> v2: > - fixed the device tree patches the descriptions of which were mixed up > - return -EPROBE_DEFER from davinci-rproc's probe() if we can't get the > reset provider, since it's possible that the lookup table was not yet > registered > - made the local variable naming consistent in the davinci-rproc driver > - fixed a typo in PATCH 5/8 > > v2 -> v3: > - reworded the commit messages (s/remoteproc: da8xx/remoteproc\/davinci/) > - call clk_disable_unprepare() if reset_control_deassert() fails in > da8xx_rproc_start() > - added a patch fixing the S_IRUGO checkpatch warning, since we're > already modifying this driver anyway > - added a temp variable for code brevity in da8xx_rproc_stop() > - removed patch 1/8 (already applied to reset/next) > > Bartosz Golaszewski (8): > ARM: davinci: dts: make psc0 a reset provider > ARM: davinci: dts: add a reset control to the dsp node > clk: davinci: add a reset lookup table for psc0 > remoteproc/davinci: add the missing retval check for clk_enable() > remoteproc/davinci: prepare and unprepare the clock where needed > remoteproc/davinci: use octal permissions for module_param() > remoteproc/davinci: use the reset framework > clk: davinci: kill davinci_clk_reset_assert/deassert() > > arch/arm/boot/dts/da850.dtsi | 2 ++ > arch/arm/mach-davinci/include/mach/clock.h | 21 -------------- > drivers/clk/davinci/psc-da850.c | 7 +++++ > drivers/clk/davinci/psc.c | 19 +------------ > drivers/remoteproc/da8xx_remoteproc.c | 45 ++++++++++++++++++++++++------ > 5 files changed, 47 insertions(+), 47 deletions(-) > delete mode 100644 arch/arm/mach-davinci/include/mach/clock.h >