Received: by 10.213.65.68 with SMTP id h4csp945808imn; Wed, 28 Mar 2018 16:26:28 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+82D+jAP07AeDhUi56u0Pln4QmzQG9BCiBi8/8SUq9JMefuMn5t9m1iJQwsdC/sXoUP4Mr X-Received: by 10.99.119.78 with SMTP id s75mr3923123pgc.238.1522279588745; Wed, 28 Mar 2018 16:26:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522279588; cv=none; d=google.com; s=arc-20160816; b=XckNtq+9sIiJeWqI6GFjNUujVU9478h404gVc5YBLgsYVdHHjiRJsBzZgMNvjwtLRW UTgi/sRLYNGvXX+ErgL3CJlkd3roGzjLFSTPzXzKzjpRgp16uz0YmPCFMO9gm8Tw67av K2vqgsqJ1xoQwQs5ZTR/ghKzr064cqKTS5o6lI6tnlBlvILJAePKlDna5yqYC00MEICe Au3BBk92TMWhPvZn3CX/Y7j9MvsBdOlyhPc37zOcEMSmRgJWgOIEK9H0AqAEBkEjtz0P viCTNiBBF1vJBLzUywNGYtSVDMLalCrq0TYbhJUT/9vzTwpnY41V+geKxkcW4WVAgd/R KHfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:msip_labels:content-language:thread-index :content-transfer-encoding:mime-version:message-id:date:subject :in-reply-to:references:cc:to:from:dkim-signature :arc-authentication-results; bh=3qkfpTwRSCTLWmdZzfftyRB7cgfAhiAyaZJSg6NRTDM=; b=a0zD4HYVMxaO0Cp2fNJ8AudfprhX+ndWO9PQmVwV5eSFIluoXDOi6oyCU1h5zUs4lz YI5mqFunypHwPTj+CSABnp5bsNSmW8yfde+umivF8BskYcf3tu0Nuh6+suSF2gQuTYrD h3a4O9/j9AOl6i7nF3P1IjyqQZzBNjviJWRiS/OPpCOpNn/d6vQdsPMwe43Cd3FGoYcE RSBsLaHmWkSD1AlIOLWXuDqXraaa87pzkG1vGRfjeGS69W66O+DdrJLZlRDGXh8FP0rE EUxnMpoUDw38FVsObch2kTKNH5f+PYVw96XMyZAmGBpn8wjiEXIUDkWgNBgBdZfxl8KK T1Pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=bvAy1nzW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c3-v6si4366278plo.45.2018.03.28.16.26.14; Wed, 28 Mar 2018 16:26:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=bvAy1nzW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751183AbeC1XZR (ORCPT + 99 others); Wed, 28 Mar 2018 19:25:17 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35236 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbeC1XZP (ORCPT ); Wed, 28 Mar 2018 19:25:15 -0400 Received: by mail-pg0-f67.google.com with SMTP id j3so1823023pgf.2 for ; Wed, 28 Mar 2018 16:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:thread-index :content-language:msip_labels; bh=3qkfpTwRSCTLWmdZzfftyRB7cgfAhiAyaZJSg6NRTDM=; b=bvAy1nzWxmZEi4PqoJCiYRwZUaCe8b6+Pc25Pu1x8BZrjjEmySmHmFO3lFLSoRmEzM ovmLhEowDvZLV1XQVuV+WlCL+JmNeapR/zSafrl7NpSRfy41HVuxq1A3e/HbncujB+d6 Hbu9iLhsJU6yBdjA31MfNqh8tVZl+qrXtGLSEuqIb5Kp9jbM0bP5sLPtZjAmqCn1FZpM XTdd/VhVYR69LCrUd/K3SLkRvKJaXJr3hv7Xj97CEtuTOuwhDA4JNfPTIxRgRqxNNCt9 qxNg+K5ZTCTWZd1ctpV2f0OFiaHQDilLnUDScl/uVZaXH+p4JiuhVS0PZK0r2FY3QUci LmBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:thread-index :content-language:msip_labels; bh=3qkfpTwRSCTLWmdZzfftyRB7cgfAhiAyaZJSg6NRTDM=; b=E3j7kyFvmabq5bJm2pBtmfaXe0IHovfntPVFiLYCmLQGTh1y8g1zcBcpb3nJ+BXU1D ORYGLosuyhDwYUMOqDM2iDKL0/6uNFgMA49Nb4z5rB4XkgTWjsbjgH6hphpgb9HoVxgS l9ghYtnKJ2fsjyO378mcSSefNxXe06mre2Er4eqUiGkmfqPY6f7Ja4bJt4aUjW0RlTyJ xXULP3ku6cnuy/Rernv6dZMOm2BV1FGTXQtWtQLRyRWQhSxlS5JbvGSTf6Vzhg9Htrgh DgRMqnMsDkECtBm/yZvNqZUVHfGUSOYdBZgVUqIekekcKL9V8JcUsar7SEQQ/SJHqB++ kYzg== X-Gm-Message-State: AElRT7GaZDPWRvriTdQJ6T3KMNRqHG9gRj98eLGLwX26zP8QeXiXL3MP UXgB76enMrHwO1FCbG/5WPwJyA== X-Received: by 10.98.220.86 with SMTP id t83mr4460430pfg.60.1522279514433; Wed, 28 Mar 2018 16:25:14 -0700 (PDT) Received: from MININTFU8L5V5 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id z6sm9044542pfe.9.2018.03.28.16.25.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Mar 2018 16:25:13 -0700 (PDT) From: "Stephen Hemminger" To: "'Joshua R. Poulson'" Cc: "'K. Y. Srinivasan'" , "'KY Srinivasan'" , , , , , "'Andy Whitcroft'" , "'Vitaly Kuznetsov'" , , "'Leann Ogasawara'" , "'Marcelo Henrique Cerri'" , "'Stephen Hemminger'" , "'Michael Kelley'" , "'Stable'" References: <20180305052408.19475-1-kys@exchange.microsoft.com> <20180328120142.7ba72aa2@xeon-e3> In-Reply-To: Subject: RE: [PATCH 1/1] Drivers: hv: vmbus: Fix ring buffer signaling Date: Wed, 28 Mar 2018 16:25:11 -0700 Message-ID: <03e101d3c6ec$05828e20$1087aa60$@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIXJVKPxVxvEmfw2GlV/rYeOH2oWgLJIZd1A4wSEfCjLOO1MA== Content-Language: en-us msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=sthemmin@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2018-03-28T23:25:11.5486283Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, I hadn't updated to rc7 yet -----Original Message----- From: Joshua R. Poulson =20 Sent: Wednesday, March 28, 2018 12:18 PM To: Stephen Hemminger Cc: K. Y. Srinivasan ; KY Srinivasan = ; gregkh@linuxfoundation.org; = linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; = olaf@aepfle.de; Andy Whitcroft ; Vitaly Kuznetsov = ; jasowang@redhat.com; Leann Ogasawara = ; Marcelo Henrique Cerri = ; Stephen Hemminger = ; Michael Kelley ; Stable = Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix ring buffer signaling https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?h=3Dv4.16-rc7&id=3D655296c8bbeffcf020558c4455305d597a73bde1 On Wed, Mar 28, 2018 at 12:01 PM, Stephen Hemminger wrote: > On Sun, 4 Mar 2018 22:24:08 -0700 > kys@exchange.microsoft.com wrote: > >> From: Michael Kelley >> >> Fix bugs in signaling the Hyper-V host when freeing space in the >> host->guest ring buffer: >> >> 1. The interrupt_mask must not be used to determine whether to signal >> on the host->guest ring buffer >> 2. The ring buffer write_index must be read (via = hv_get_bytes_to_write) >> *after* pending_send_sz is read in order to avoid a race condition >> 3. Comparisons with pending_send_sz must treat the "equals" case as >> not-enough-space >> 4. Don't signal if the pending_send_sz feature is not present. Older >> versions of Hyper-V that don't implement this feature will poll. >> >> Fixes: 03bad714a161 ("vmbus: more host signalling avoidance") >> >> Cc: Stable # 4.14 and above >> Signed-off-by: Michael Kelley >> Signed-off-by: K. Y. Srinivasan > > What ever happened to this patch? It doesn't seem to be in char-misc, = upstream, > or stable kernel tree yet. > >