Received: by 10.213.65.68 with SMTP id h4csp1120952imn; Wed, 28 Mar 2018 21:19:48 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/78IPI8tGpefvkIkJYIL3o25Yf+AbUDCQ9imxZPeB8gG0EXHWt1o5rJjW6ccJ7hdEo2DLO X-Received: by 10.101.98.22 with SMTP id d22mr4465976pgv.344.1522297188285; Wed, 28 Mar 2018 21:19:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522297188; cv=none; d=google.com; s=arc-20160816; b=o+UBHaqP/CZe8o3n4cdxFffe+9Gv0OXjZfE6ppK/lDXs2cyFg5SbIgeh6+p2otNV4o 7nWqiyS1ex+omzzLISd+LhF600kiPxg/WvoQ+NqB2E6MWkV+/12x9+OYUgkhrWVNqEGZ RjY5ySAS7uU3itz6bYoPyscP/pJ+2CzWFLxGB/mhjneDrM9SHHs6LFoL4wW5t9QqMEE5 TWQMKF7iOd3q3coNYeXYa+Tv3/Usm6StqCNVrzVcxtTcBY2npouUpjSQDXWylsPDL5Aq dOmVjZcdc0cZt9F4SlS5yXAJ75aZn8+knuxpOaOJenVW7a0Knhmx27lbgZiIsbPtPPEF edtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=IYSa/7Tor4IcJUGstE6G7Aj9MFQt5IbL7nhcZqkat4g=; b=aqgUoMTXXA3PKgSUJktfPn+z0PIkQJWbFdB7yp/rb3L/62597hhLD9SAA3hpNxg1FV ibTT/6uS2xv9KfgfHrXf56JvGNEjqiaeSAXqiBTbDDNTR6Mt4nN7wGQdoVfKcNNENORU FPRPenFEQvmR73965CRdE0bktApqIOx6ov+dwC6jXsE3Rqn1VGKO4u93qQCBR12TJzcL QhWAMNSTinLH0Mmc2wRx+0uOhJLK9KquJPB2FOKgftU51YIrozZ0G878E+ZUpuMoz2xq sh8pZvXxjBdBmq/xSjCfpxh9Y4Of3R2hsRUWRBhLS97V/ZOafKFfB8ThavrMQrlCtGin 2XLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=VWYPuiuD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si3475025pgu.518.2018.03.28.21.19.34; Wed, 28 Mar 2018 21:19:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=VWYPuiuD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751932AbeC2ERQ (ORCPT + 99 others); Thu, 29 Mar 2018 00:17:16 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:51634 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbeC2ERP (ORCPT ); Thu, 29 Mar 2018 00:17:15 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2T4H0If066674; Thu, 29 Mar 2018 04:17:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2017-10-26; bh=IYSa/7Tor4IcJUGstE6G7Aj9MFQt5IbL7nhcZqkat4g=; b=VWYPuiuDZPLSzVzeGdiHQMV8t0vGxQjFdEAbykRGbvMpgBp9Dch5afp8GRwuCuF00ek3 Mnca7x8PA5EwsdgE7prOVCyFS4zbSSO9DrPd8mZWn/MD+VZLZJ5YY2HS9qk0rg/ky+0c 2md0/AqEgbbCDMFcvU7d0qOv0mZk4FX3i9u2Yms0cuMmloJQpfVt3oef7mirJAmCnF7b PwnwzVeN8+5k6o1ick4otrNCKci8JVKyoLeJRdAbvmzcPivynp+fxtHVSYSuVdLe24dH aTWor0kIVzr/HkUfJa6rxXRy9NiJwT+E2pRDhw3RQ50jkN79srMxqyNoFmdud085cKS7 /w== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2h0rywr00w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Mar 2018 04:17:04 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2T4H3uI008653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Mar 2018 04:17:03 GMT Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w2T4H2CI000526; Thu, 29 Mar 2018 04:17:02 GMT Received: from monkey.oracle.com (/98.246.252.205) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 28 Mar 2018 21:17:02 -0700 From: Mike Kravetz To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Michal Hocko , Yisheng Xie , "Kirill A . Shutemov" , Nic Losby , Dan Rue , Andrew Morton , Mike Kravetz Subject: [PATCH 0/1] fix regression in hugetlbfs overflow checking Date: Wed, 28 Mar 2018 21:16:55 -0700 Message-Id: <20180329041656.19691-1-mike.kravetz@oracle.com> X-Mailer: git-send-email 2.13.6 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8846 signatures=668695 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=904 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803290046 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 63489f8e8211 ("hugetlbfs: check for pgoff value overflow") introduced a regression in 32 bit kernels. When creating the mask to check vm_pgoff, it incorrectly specified that the size of a loff_t was the size of a long. This prevents mapping hugetlbfs files at offsets greater than 4GB on 32 bit kernels. The above is in the commit message. 63489f8e8211 has been sent upstream and to stable, so cc'ing stable here as well. I would appreciate some more eyes on this code. There have been several fixes and we keep running into issues. Mike Kravetz (1): hugetlbfs: fix bug in pgoff overflow checking fs/hugetlbfs/inode.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) -- 2.13.6