Received: by 10.213.65.68 with SMTP id h4csp1331184imn; Thu, 29 Mar 2018 02:43:43 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+VttcADcIKvkacm40LGuDwHTN0nrRrcwVFVDDTewkgLpmlbH+/IFLZEq3S770R1LAZYIXc X-Received: by 10.98.10.23 with SMTP id s23mr5841916pfi.204.1522316623193; Thu, 29 Mar 2018 02:43:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522316623; cv=none; d=google.com; s=arc-20160816; b=AKO6VABWn27EglIcNKp+LA3Ibe/HiynjoAoki5I1U9SXsdMLbngTUzA5PHD8hXyVFi jOUFT8h8NRdsWh33rNm4RUPIOoUk7XkibY2H0P6igE9WdJ8Jh0dByaCIeXJqa4tS0YyA RZNYmXfyCkYt5Wg7HR3IJnj0WxKXh82x3cx5eiulLgS0PcWHJlRHLzXaduM/EVjHGfq/ RoYgvszDQZEoo8gVkx645nCxqw3WazfEHnggE8e+K/iNZDi+Mk1nUrkmPI1jUMyptqGY zHTe2esq4NVvb1iPIydDYkf5Antmve2III4fXEpOXX28AtRrMoFBB6nvDU4d1IePlvcj Q2eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:dkim-signature:arc-authentication-results; bh=b73kA6XzY040j3fY2Cuef/65/9IfCjrHi5Xwes5MNTE=; b=NUZ5BRjycJY91jYR4gYgkp5Av4fmiIQtkjq6Yw8bv4dhOfknRyutjlPEHTC5rr08cL TaN0350psr/6eAQM+i5Zmw3eFfYjuhm7d82nNka+hknvwHnggX6trbPdGv2lEUXP/OvC a51fw5lKiBFTUcAO14hkbLua4JojF0IvPIjwtnqxxQjizJUL1bQ2EiieMsbtMlX3h5qG A9tKs1IQ7ZeBgMbzymKrZw44+kZ6VZgbQpXJVFSbT0KWMKRv4MCmX4Poa4HULlpd8o1/ tm3faKLEBCPIh1PGSXkWZI9I4Es3mit6c2z6PHeWdLecODH4yc6saxWYbARhO5TjIN5V VL/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=f3D3TzYu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y19si4183294pfm.63.2018.03.29.02.43.29; Thu, 29 Mar 2018 02:43:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=f3D3TzYu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752232AbeC2JmQ (ORCPT + 99 others); Thu, 29 Mar 2018 05:42:16 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:25359 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbeC2JmO (ORCPT ); Thu, 29 Mar 2018 05:42:14 -0400 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id w2T9g7uP024306; Thu, 29 Mar 2018 04:42:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1522316527; bh=K2rxiO0AVYwe6aNzZ9722x7GayRe+/yf0V4IYzIpQSI=; h=Subject:To:References:CC:From:Date:In-Reply-To; b=f3D3TzYuEgjPyrWKrPHHOUXBcl6dU1LNJ/1vuf/wWTT5nNT0nCoo32MtHmQ+jZfvr DItWpDmF1vNQ4MY59VNUQZA3fehi9ghGqBpOkZoKNgYffipBydBJP9gdYn6twf41QJ BEZ5nh/JLX0y1RFC3laVvzK6SLqtoIHtnAlQnCwY= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id w2T9g6wJ025398; Thu, 29 Mar 2018 04:42:06 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.35; Thu, 29 Mar 2018 04:42:06 -0500 Received: from dflp33.itg.ti.com (10.64.6.16) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1261.35 via Frontend Transport; Thu, 29 Mar 2018 04:42:06 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w2T9g3VK016194; Thu, 29 Mar 2018 04:42:04 -0500 Subject: Re: [PATCH v5 04/12] PCI: endpoint: Setting 64-bit/prefetch bit is invalid when IO is set To: Niklas Cassel , , Lorenzo Pieralisi , Bjorn Helgaas References: <20180328115018.31921-1-niklas.cassel@axis.com> <20180328115018.31921-5-niklas.cassel@axis.com> CC: Niklas Cassel , , From: Kishon Vijay Abraham I Message-ID: <2afdb97d-eb07-031b-bb24-7166d011ee5b@ti.com> Date: Thu, 29 Mar 2018 15:12:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180328115018.31921-5-niklas.cassel@axis.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 28 March 2018 05:20 PM, Niklas Cassel wrote: > If flag PCI_BASE_ADDRESS_SPACE_IO is set, also having any > PCI_BASE_ADDRESS_MEM_* bit set is invalid. > > This sanity check is done in pci_epc_set_bar(), so that we don't need > to do this sanity check in all epc->ops->set_bar() implementations. > > Signed-off-by: Niklas Cassel > --- > drivers/pci/endpoint/pci-epc-core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c > index 109d75f0b7d2..40eea20d21f9 100644 > --- a/drivers/pci/endpoint/pci-epc-core.c > +++ b/drivers/pci/endpoint/pci-epc-core.c > @@ -309,10 +309,13 @@ int pci_epc_set_bar(struct pci_epc *epc, u8 func_no, > { > int ret; > unsigned long irq_flags; > + int flags = epf_bar->flags; > > if (IS_ERR_OR_NULL(epc) || func_no >= epc->max_functions || > (epf_bar->barno == BAR_5 && > - epf_bar->flags & PCI_BASE_ADDRESS_MEM_TYPE_64)) > + flags & PCI_BASE_ADDRESS_MEM_TYPE_64) || > + (flags & PCI_BASE_ADDRESS_SPACE_IO && > + flags & PCI_BASE_ADDRESS_IO_MASK)) > return -EINVAL; If possible I'd like this to be split. But otherwise Acked-by: Kishon Vijay Abraham I > > if (!epc->ops->set_bar) >