Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Shea Levy <shea@shealevy.com>
To:     Daniel Thompson <daniel.thompson@linaro.org>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Palmer Dabbelt <palmer@sifive.com>, Albert Ou <albert@sifive.com>
Subject: Re: [PATCH v4 02/16] riscv: Use generic free_initrd_mem.
In-Reply-To: <7fa4f27c-d421-38cd-aa16-445b364ed9eb@linaro.org>
References: <20180328152714.6103-1-shea@shealevy.com> <20180328203659.18692-1-shea@shealevy.com> <20180328203659.18692-3-shea@shealevy.com> <7fa4f27c-d421-38cd-aa16-445b364ed9eb@linaro.org>
Date:   Thu, 29 Mar 2018 07:12:40 -0400
Message-ID: <87y3ibrv87.fsf@xps13.shealevy.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Daniel Thompson <daniel.thompson@linaro.org> writes:

> On 28/03/18 21:36, Shea Levy wrote:
>> Signed-off-by: Shea Levy <shea@shealevy.com>
>> ---
>>   arch/riscv/mm/init.c | 6 ------
>>   1 file changed, 6 deletions(-)
>>=20
>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>> index c77df8142be2..36f83fe8a726 100644
>> --- a/arch/riscv/mm/init.c
>> +++ b/arch/riscv/mm/init.c
>> @@ -62,9 +62,3 @@ void free_initmem(void)
>>   {
>>   	free_initmem_default(0);
>>   }
>> -
>> -#ifdef CONFIG_BLK_DEV_INITRD
>> -void free_initrd_mem(unsigned long start, unsigned long end)
>> -{
>> -}
>> -#endif /* CONFIG_BLK_DEV_INITRD */
>
> This looks like a change of behavior since the weakly defined code does=20
> not implement a nop.
>
> I'm not saying the change is wrong, but if this is a deliberate bug fix=20
> then we need more than an empty commit message to explain what is=20
> happening here.
>

Right, sorry, will re-send with a proper commit message here.

>
>
> Daniel.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE6ESKvwKkwnxgMLnaXAvWlX2G/icFAlq8yigACgkQXAvWlX2G
/ieUwg//QOJoYqSxnITCFFfNoddzFpiplGiiMWId7+gJ5Fo+cy4ygN4u2Y3JQhg3
fHMeW3xwNepDXhJ9M/pzXU69DhxZEt2+roO9CaGKJYYX8kx9sYPlhMTbjYyg/9ZZ
fgfZaoD05o+Fcq0bJbVhm5yQBIIQWoepbR+vwewa7IjeHyF/enapSuuGycplmn6s
SzKxhbPFguM5kYcHpBcQlRSLREPC1Mqp26/zT8Vt+qZEETnYa2KVHf/aTeKWHNlf
78pwe/JssyXUCE7HVi1lVZRB9EvxUpV40inx5k9gEGrrIsKk2REV1VbfKCRwyjiS
lbZ8KZ9utsh6cHqo6YyVxnNgRI1po4r1pz1BXaMsDOGqgBJY+z6ua0PrcAWctjPG
WZysYd3h5NBxdAQADjwA7hqHD7IsBgUJmiSpmQlZDUJJq4bVnE8EHpkBy6UKiH/L
XDor2xi/maTujsRwC/Pn1S2yRpZQ5XrPPK478xPqOHERlW8rwy9XV14Ye86N26op
sJoKLQYuiSnfaDzsaFrffnXgpfAx+k7DJIq7xpg7IhXe21J9n4nBFv8CZHPJN4rF
nzFCVNZUjwqXWgzmLzdtZxF9y0uV7cOtMIe7SUQ11jkAWkSz8tjv6X5J6F4pEYQK
fFQIkcVvat7Ji8KfNORHAaAbFbWWdVv2Xu+CC4PIL0/O2yJWMPI=
=jCim
-----END PGP SIGNATURE-----
--=-=-=--