Received: by 10.213.65.68 with SMTP id h4csp1418267imn; Thu, 29 Mar 2018 04:32:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx49wE981XM+IpboA+MNCwNZLQ5cyjh0ydkq2RqfdziWtVKf2Lhv4n5Sne9/MDjW8LS1TKdE3 X-Received: by 2002:a17:902:7482:: with SMTP id h2-v6mr8054911pll.264.1522323146808; Thu, 29 Mar 2018 04:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522323146; cv=none; d=google.com; s=arc-20160816; b=WA2OsFbuXjLt0KfLD8t/rMpfRYMvN4f7T5pmMov7SrGmv+WQ9gXH0b7Hpu3vA6RrG7 2kNi9eqRTIDWjejUigNGg9ErkyrmL0iMvNGwRHCnIe0HZHobL2IsSzYbq7XCUqqVMDnl uRyWK4h2gHk8yzV6jQd2eLwdpM58DAOAFKIsbxVLYL4xhM0SawVwwsgJiMnMUbQzFUY1 PFhyh/UCFeudH4A10mVANc9M5V8Xgpdpfd5rAp5uLt7tJ+cmmyGOh5uIADWTuL8p8ADX TMtiex37rIMIgT7UwA7VpTqaUdZZSO/N1S2Zc+cDW2WfrVO0ajWNGd02slsL0PElDZl2 qUZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=vjZeHFfNoCs1L3UO3bGGcySsEBvwixfXg4SBiNIcLBQ=; b=PK8i5PRmi1lAc7E7DK3wJqqp78FO6VLpPSxbDLum9YNWb2I9ay5Me4AlbbkRkHxNpc s5159yH+CLJlYLdLDRVOTxKSUBulqFQi7uOc0PDEcauRQBvIrwK4G7XfkLQAjR1bub3d ec1cx9ZgUwUKRzRXXl+2/1uaI1laB8RMZ5VRd7iZ1LyAG0VtPBVWZxhjkOfMhlbXMcWP AAL6klwIj4NsQ6cBSjSxu/IeN+LXOp0qXW6ESGqcWUwI5NG5J5t6UcEdVzFWPTy5ehXL 1F9Eraq/5Zp1bRMOLydqVoCTtmTmzw8XrGip2N4dSFPW9MF0xSKYYGHb5CSVUQ7PuAPQ 5yNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7-v6si1346213plh.583.2018.03.29.04.32.12; Thu, 29 Mar 2018 04:32:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753096AbeC2LbX (ORCPT + 99 others); Thu, 29 Mar 2018 07:31:23 -0400 Received: from mail.thorsis.com ([92.198.35.195]:42543 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752983AbeC2LbV (ORCPT ); Thu, 29 Mar 2018 07:31:21 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 70A8B3A45EB; Thu, 29 Mar 2018 13:31:23 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u-7KsQfHGZLJ; Thu, 29 Mar 2018 13:31:23 +0200 (CEST) From: Alexander Dahl To: linux-arm-kernel@lists.infradead.org Cc: Alexandre Belloni , Boris Brezillon , Thomas Gleixner , Daniel Lezcano , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/6] clocksource: rework Atmel TCB timer driver Date: Thu, 29 Mar 2018 13:31:18 +0200 Message-ID: <3103570.fW0XyqvKVi@ada> In-Reply-To: <20180329104542.GK13942@piout.net> References: <20180223171558.7037-1-alexandre.belloni@bootlin.com> <3478710.yJBBt3uoRT@ada> <20180329104542.GK13942@piout.net> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on seven.thorsis.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alexandre, Am Donnerstag, 29. M=E4rz 2018, 12:45:42 CEST schrieb Alexandre Belloni: > > This is the result: > >=20 > > INT NAME RATE MAX > >=20 > > 17 [vel timer@fffa] 1837 Ints/s (max: 1912) > > 26 [ vel eth0] 3 Ints/s (max: 11) > >=20 > > This is not much lower than the ~2150 I reported yesterday? > >=20 > > I'm sorry I can just test this on at91sam9g20 currently, I have no > > understanding of the subsystem, I can't do a decent review. >=20 > Hum, are you sure, I went from: >=20 > INT NAME RATE MAX > 16 [evel timer@fc0] 1027 Ints/s (max: 1028) > 21 [ evel at_xdmac] 3 Ints/s (max: 3) > 30 [ evel ttyS0] 2 Ints/s (max: 2) >=20 > to: >=20 > INT NAME RATE MAX > 16 [evel timer@fc0] 6 Ints/s (max: 9) > 21 [ evel at_xdmac] 2 Ints/s (max: 2) > 30 [ evel ttyS0] 2 Ints/s (max: 2) Pretty sure. I rebuilt the whole BSP and added another line to the kernel=20 source to see if the tree I applied the patches to, was actually built: diff --git a/drivers/clocksource/timer-atmel-tcb.c b/drivers/clocksource/ti= mer-atmel-tcb.c index 7fde9cfbf203..f85affc74a86 100644 =2D-- a/drivers/clocksource/timer-atmel-tcb.c +++ b/drivers/clocksource/timer-atmel-tcb.c @@ -222,7 +222,8 @@ static int __init tc_clkevt_register(struct device_node= *node, goto err_slow; clk_disable(tce.clk); =20 =2D clockevents_config_and_register(&tce.clkevt, 32768, 1, bits - 1); + pr_info( "*** bits: 0x%x, BIT(bits): 0x%lx\n", bits, BIT(bits) ); + clockevents_config_and_register(&tce.clkevt, 32768, 1, BIT(bits) - = 1); =20 ret =3D request_irq(tce.irq, tc_clkevt2_irq, IRQF_TIMER | IRQF_SHAR= ED, tce.clkevt.name, &tce); See the more complete serial console output (including the additional=20 message): Starting kernel ... ** 15 printk messages dropped ** Dentry cache hash table entries: 4096 (order: 2, 16384 bytes) Inode-cache hash table entries: 2048 (order: 1, 8192 bytes) Memory: 28624K/32768K available (2934K kernel code, 113K rwdata, 436K rodat= a, 144K init, 73K bss, 4144K reserved, 0K cma-reserved) Virtual kernel memory layout: vector : 0xffff0000 - 0xffff1000 ( 4 kB) fixmap : 0xffc00000 - 0xfff00000 (3072 kB) vmalloc : 0xc2800000 - 0xff800000 ( 976 MB) lowmem : 0xc0000000 - 0xc2000000 ( 32 MB) modules : 0xbf000000 - 0xc0000000 ( 16 MB) .text : 0x(ptrval) - 0x(ptrval) (2936 kB) .init : 0x(ptrval) - 0x(ptrval) ( 144 kB) .data : 0x(ptrval) - 0x(ptrval) ( 114 kB) .bss : 0x(ptrval) - 0x(ptrval) ( 74 kB) SLUB: HWalign=3D32, Order=3D0-3, MinObjects=3D0, CPUs=3D1, Nodes=3D1 Preemptible hierarchical RCU implementation. Tasks RCU enabled. NR_IRQS: 16, nr_irqs: 16, preallocated irqs: 16 clocksource: timer@fffa0000:0,1: mask: 0xffffffff max_cycles: 0xffffffff, m= ax_idle_ns: 115749784805 ns sched_clock: 32 bits at 16MHz, resolution 60ns, wraps every 130055938017ns *** bits: 0x10, BIT(bits): 0x10000 Console: colour dummy device 80x30 Calibrating delay loop... 197.01 BogoMIPS (lpj=3D985088) pid_max: default: 32768 minimum: 301 Mount-cache hash table entries: 1024 (order: 0, 4096 bytes) Mountpoint-cache hash table entries: 1024 (order: 0, 4096 bytes) CPU: Testing write buffer coherency: ok Setting up static identity map for 0x20008400 - 0x2000843c Hierarchical SRCU implementation. devtmpfs: initialized clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns:= 19112604462750000 ns futex hash table entries: 256 (order: -1, 3072 bytes) pinctrl core: initialized pinctrl subsystem NET: Registered protocol family 16 DMA: preallocated 256 KiB pool for atomic coherent allocations gpio-at91 fffff400.gpio: at address 82332323 gpio-at91 fffff600.gpio: at address a4bf53d9 gpio-at91 fffff800.gpio: at address 31e4ab7c pinctrl-at91 ahb:apb:pinctrl@fffff400: initialized AT91 pinctrl driver AT91: Detected SoC: at91sam9g20, revision 1 clocksource: Switched to clocksource timer@fffa0000:0,1 NET: Registered protocol family 2 tcp_listen_portaddr_hash hash table entries: 512 (order: 0, 4096 bytes) TCP established hash table entries: 1024 (order: 0, 4096 bytes) TCP bind hash table entries: 1024 (order: 0, 4096 bytes) TCP: Hash tables configured (established 1024 bind 1024) UDP hash table entries: 256 (order: 0, 4096 bytes) UDP-Lite hash table entries: 256 (order: 0, 4096 bytes) NET: Registered protocol family 1 workingset: timestamp_bits=3D30 max_order=3D13 bucket_order=3D0 io scheduler noop registered (default) fffff200.serial: ttyS0 at MMIO 0xfffff200 (irq =3D 18, base_baud =3D 825600= 0) is a ATMEL_SERIAL console [ttyS0] enabled rtc rtc0: invalid alarm value: 1900-1-29 0:0:0 rtc-at91sam9 fffffd20.rtc: rtc core: registered fffffd20.rtc as rtc0 nand: device found, Manufacturer ID: 0x01, Chip ID: 0xda nand: AMD/Spansion S34ML02G1 nand: 256 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64 Greets Alex