Received: by 10.213.65.68 with SMTP id h4csp1555584imn; Thu, 29 Mar 2018 06:55:31 -0700 (PDT) X-Google-Smtp-Source: AIpwx48yR389DDWWUyDqlBYIq3/X6z7QZXrX4jT2UV+n6scs1ZhanAr4a2O5zhQQhG/rHdRLS62L X-Received: by 2002:a17:902:20cb:: with SMTP id v11-v6mr8719072plg.82.1522331731592; Thu, 29 Mar 2018 06:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522331731; cv=none; d=google.com; s=arc-20160816; b=hB6Q6F7YntNOJXZSdHhIzShjjh8cuuheFoYpqw1M1kN+YbzJY8haR4lZbzBDlATE66 6fkOl0ze2MM/FVBiLy1HUi0CkCERHupPDL+styxXpXIJHHRcLUuRYoUyuZ9IIn2uJxwg 2y7wTGyA4xxr+/j68m0IZIs9qehuS+KpftEeJBxxnI7VNgVX+7e16SedwACPZ+R9ch5d HoiUCrP8Fj8lABijyYki4eyBWwDmfYN1HMngytAqTQ1UNM20zSKHZsHP1zjrAi14K/Xq h3Rtvy6b0FdanwjyFaWLfGx7zfiP0LImcduOicJReR9UJCD7SSZK4ehyXvHQqspCXwuO f1WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=yUZTJ0IozgzYHx77ZRcEJltoAQtMO87+N0/4UJ2HFTY=; b=pu6kNO31ZhXWQPMkm6Rz5kvcuEM0K/BLM1hm8nM60Q0u/sDP3oN9gfCbYXhmy3y1nC Kkk1YmQfKNzwly58/xd5HYJLVvo0IliUwFadIMGKtbAxIVQPkjYLmk5UP/tUgYYGO+98 ynZpCnXDXHrAQ+k48TFN+3CkcOZe4V/tD6LA1jABXwsEQx8Ju0iD6Rg/dBb5RaF3tP1m x9mQYjMiF6Bgr1lg594T08yzC1rUjCXQhBio/P0Ip9Em4eimOCip+k0HSgtaPh+Oy/ny MSlHKAqLQFCkJAxPpL2x8LWjURX+l3k/zwf/WxHmXFA8x6ZDUOThrFNXfcMlp/fSW7UH wfTA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3si4442396pfh.84.2018.03.29.06.55.17; Thu, 29 Mar 2018 06:55:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbeC2Nxp (ORCPT + 99 others); Thu, 29 Mar 2018 09:53:45 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:57199 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbeC2Nxo (ORCPT ); Thu, 29 Mar 2018 09:53:44 -0400 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id C11C610C1184; Thu, 29 Mar 2018 06:53:42 -0700 (PDT) Received: from mailhost.synopsys.com (localhost [127.0.0.1]) by mailhost.synopsys.com (Postfix) with ESMTP id 7F37D5144; Thu, 29 Mar 2018 06:53:42 -0700 (PDT) Received: from pt02.synopsys.com (pt02.synopsys.com [10.107.23.240]) by mailhost.synopsys.com (Postfix) with ESMTP id BB0EE513B; Thu, 29 Mar 2018 06:53:41 -0700 (PDT) Received: from [127.0.0.1] (gustavo-e7480.internal.synopsys.com [10.107.25.102]) by pt02.synopsys.com (Postfix) with ESMTP id ED9ED3DF09; Thu, 29 Mar 2018 14:53:40 +0100 (WEST) Subject: Re: [PATCH v5 00/12] PCI endpoint 64-bit BAR fixes To: Niklas Cassel , "kishon@ti.com" , "cyrille.pitchen@free-electrons.com" , Lorenzo Pieralisi , Arnd Bergmann , Greg Kroah-Hartman , Alan Douglas , Bjorn Helgaas , Jingoo Han , Joao Pinto Cc: Niklas Cassel , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20180328115018.31921-1-niklas.cassel@axis.com> From: Gustavo Pimentel Message-ID: Date: Thu, 29 Mar 2018 14:52:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180328115018.31921-1-niklas.cassel@axis.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Niklas, On 28/03/2018 12:50, Niklas Cassel wrote: > PCI endpoint fixes to improve the way 64-bit BARs are handled. > > > There are still future improvements that could be made: > > pci-epf-test.c always allocates space for > 6 BARs, even when using 64-bit BARs (which > really only requires us to allocate 3 BARs). > > pcitest.sh will print "NOT OKAY" for BAR1, > BAR3, and BAR5 when using 64-bit BARs. > This could probably be improved to say > something like "N/A (64-bit BAR)". > > Niklas Cassel (12): > PCI: endpoint: BAR width should not depend on sizeof dma_addr_t > PCI: endpoint: Simplify epc->ops->set_bar()/pci_epc_set_bar() > PCI: endpoint: Setting BAR_5 to 64-bits wide is invalid > PCI: endpoint: Setting 64-bit/prefetch bit is invalid when IO is set > PCI: endpoint: Setting a BAR size > 4 GB is invalid if 64-bit flag is > not set > PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs > properly > PCI: cadence: Set PCI_BASE_ADDRESS_MEM_TYPE_64 if a 64-bit BAR was > set-up > PCI: endpoint: Handle 64-bit BARs properly > PCI: endpoint: Make epc->ops->clear_bar()/pci_epc_clear_bar() take > struct *epf_bar > PCI: endpoint: Make sure that BAR_5 does not have 64-bit flag set when > clearing > PCI: designware-ep: Make dw_pcie_ep_reset_bar() handle 64-bit BARs > properly > misc: pci_endpoint_test: Handle 64-bit BARs properly > > drivers/misc/pci_endpoint_test.c | 12 +++++---- > drivers/pci/cadence/pcie-cadence-ep.c | 15 ++++++++--- > drivers/pci/dwc/pcie-designware-ep.c | 36 +++++++++++++++++++++------ > drivers/pci/endpoint/functions/pci-epf-test.c | 28 +++++++++++++-------- > drivers/pci/endpoint/pci-epc-core.c | 32 +++++++++++++++--------- > drivers/pci/endpoint/pci-epf-core.c | 4 +++ > include/linux/pci-epc.h | 11 ++++---- > include/linux/pci-epf.h | 2 ++ > 8 files changed, 95 insertions(+), 45 deletions(-) > For the whole series: Tested-by: Gustavo Pimentel Regards, Gustavo