Received: by 10.213.65.68 with SMTP id h4csp1627927imn; Thu, 29 Mar 2018 08:07:03 -0700 (PDT) X-Google-Smtp-Source: AIpwx49IWxNC15cZrRl9sX39Ol6xsocpvrc97j/5SAUsUx8HCtXEP1CmO/2id4psp1L89+dx6+WD X-Received: by 2002:a17:902:720a:: with SMTP id ba10-v6mr8817653plb.294.1522336023796; Thu, 29 Mar 2018 08:07:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522336023; cv=none; d=google.com; s=arc-20160816; b=gWh1WPK3FVqvFx2pW3ycflkVnCYBUYJQDXgOqVG0oVcyqdNp7l3MV1XlQCTGnhdKfR mvIU5GDHj7MEb8lDq5r3AVBkREUdTz4l5/6gXCUEFrOhbmALumKdKBGt5WaDYDq7JRdm CvUa3uaqQ2Lw1kAMZMaCJcXOnSIM0fumfO2F/M47qsmp69j6O1lourBKLwo/vO47pwo0 2P1xnzTMeovXOgZUJhNPelhX0fGTc0LMjPRf/Bj9J25s9X1XhkBM9S0ErXPQSw2sf/Qs 8L6Dkitc11+YMSsMLp7HnK7HhEN1mnwMNz/nQcoe8MjJI2d03g9mc/iN/HpmPfJbXDci ubNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=A3/uTG1k6ebcD8ccz85HW4AnnJ3j6oKf0o0i8kV3x98=; b=bNjhZ3e7rPMKBUp5pIs8sIsjVpDAq6xc3aYiX4fUOHZoVojngcFCiXYTeQKCqjETTd 53mpSB87DhpGFICaQu6eUXSHa6OSvytay/dCam7qojek3zyVdfNXtApXCsUEupUHkMTW DsEc+i/eceKSh1xbH7oaeRu7VWU+5QbRIwvGQbEWTQZOJ25qQhzMzBG65KDMYHTFcoxy GukAYdnXPKIwnpUiA41v0sAOKS0bwsonJlSnGbaZqT1ICFxvveBM6nUWBHQ6T8wJ7aI0 x3sVpPxrRSCNRJYBzWyRUall6RAYxhL6uylF3TcLhMrmYrmEuXEVIhW18frds+mLbl6a b+7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=p1fpRtOX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q87si4583767pfa.385.2018.03.29.08.06.19; Thu, 29 Mar 2018 08:07:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=p1fpRtOX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752514AbeC2O5f (ORCPT + 99 others); Thu, 29 Mar 2018 10:57:35 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46366 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbeC2O5e (ORCPT ); Thu, 29 Mar 2018 10:57:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=A3/uTG1k6ebcD8ccz85HW4AnnJ3j6oKf0o0i8kV3x98=; b=p1fpRtOXvFseM7MV5jJXk/gHNDma45xERXh0N46SQTzEp/Uv5a5AstlFAI1RjT77w4eJTYYs+LhrQgBt5oRZDND1NN7L1wW7j0vGBsCdcl8Gph4AiWmgjQswFnacBDFBG+F0LcObHW20S2rUBJr5zicTUKB/Rm5o/DveVN/X+EQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1f1YzX-0002Gm-VO; Thu, 29 Mar 2018 16:57:27 +0200 Date: Thu, 29 Mar 2018 16:57:27 +0200 From: Andrew Lunn To: Alexandre Belloni Cc: "David S . Miller" , Allan Nielsen , razvan.stefanescu@nxp.com, po.liu@nxp.com, Thomas Petazzoni , Florian Fainelli , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH net-next 3/8] net: mscc: Add MDIO driver Message-ID: <20180329145727.GB25752@lunn.ch> References: <20180323201117.8416-1-alexandre.belloni@bootlin.com> <20180323201117.8416-4-alexandre.belloni@bootlin.com> <20180323204939.GS24361@lunn.ch> <20180329140544.GB12066@piout.net> <20180329144041.GA25752@lunn.ch> <20180329145352.GD12066@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180329145352.GD12066@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > It sounds like the correct fix is for get_phy_id() to look at the > > error code for mdiobus_read(bus, addr, MII_PHYSID1). If it is EIO and > > maybe ENODEV, set *phy_id to 0xffffffff and return. The scan code > > should then do the correct thing. > > > > That could work indeed. Do you want me to test and send a patch? Yes please. Thanks Andrew