Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support
To:     Joerg Roedel <joro@8bytes.org>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc:     "Raj, Ashok" <ashok.raj@intel.com>,
        Sohil Mehta <sohil.mehta@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        David Woodhouse <dwmw2@infradead.org>,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        Gayatri Kammela <gayatri.kammela@intel.com>,
        Ravi V Shankar <ravi.v.shankar@intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Lu Baolu <baolu.lu@linux.intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>
References: <1517619001-148586-1-git-send-email-sohil.mehta@intel.com>
 <20180213140303.42mbzfxpypljy37l@8bytes.org>
 <20180213214002.GA27066@otc-nc-03> <20180213145332.35c73eda@jacob-builder>
 <20180215095337.fccoozdclfnbepi4@8bytes.org>
 <20180215083811.3ec86e49@jacob-builder>
 <20180315131854.s6xmltsvsysublcw@8bytes.org>
 <20180319093714.3afe698b@jacob-builder>
 <20180329084824.fvy7cg2wban4by4n@8bytes.org>
From:   Gary R Hook <gary.hook@amd.com>
Message-ID: <d9657df2-3742-6949-52ca-23d4ca186a7e@amd.com>
Date:   Thu, 29 Mar 2018 10:52:15 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180329084824.fvy7cg2wban4by4n@8bytes.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2018 15:52:18.5008 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: c0f66d19-6c93-4a4b-3643-08d5958d0d76
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0698
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/29/2018 03:48 AM, Joerg Roedel wrote:
> [ Adding Gary from AMD to Cc ]
> 
> On Mon, Mar 19, 2018 at 09:37:14AM -0700, Jacob Pan wrote:
>> On Thu, 15 Mar 2018 14:18:54 +0100
>> Joerg Roedel <joro@8bytes.org> wrote:
>>
>>> On Thu, Feb 15, 2018 at 08:38:11AM -0800, Jacob Pan wrote:
>>>> Just wondering if your concern is on the implementation or the
>>>> debugfs idea in general. Perhaps have some common IOMMU debugfs?
>>>
>>> My concern mainly is that we add interfaces which reveal
>>> potentially security relevant information
>> I don;t think security is any worse than existing kernel page table in
>> debugfs. i.e. /sys/kernel/debug/page_tables
>> This is a debug feature.
> 
> Okay, so here is the way to go: Please introduce a basic debugfs
> facility to the core iommu code. It should basically only create a
> 'iommu/' directory in debugfs where drivers can create their own
> sub-directories. This must be enabled by a new kconfig option
> (CONFIG_IOMMU_DEBUGFS) and the kernel should print a big fat warning at
> boot when it is enabled. This hopefully prevents anyone from enabling it
> for production kernels.

I'm halfway through this. Where would you like to place the invocation 
of the initialization function?

There's an iommu_init() in iommu.c, But it's a core_initcall, which 
doesn't seem like a good spot. Not knowing enough about bring-up here, 
Would adding another __init function be suitable?

Gary