Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 29 Mar 2018 12:09:03 -0400 (EDT)
Message-Id: <20180329.120903.1175452061863560219.davem@davemloft.net>
To:     dongli.zhang@oracle.com
Cc:     xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, wei.liu2@citrix.com,
        paul.durrant@citrix.com
Subject: Re: [PATCH 1/1] xen-netback: process malformed sk_buff correctly
 to avoid BUG_ON()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1522194136-11985-1-git-send-email-dongli.zhang@oracle.com>
References: <1522194136-11985-1-git-send-email-dongli.zhang@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Dongli Zhang <dongli.zhang@oracle.com>
Date: Wed, 28 Mar 2018 07:42:16 +0800

> The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if
> the received sk_buff is malformed, that is, when the sk_buff has pattern
> (skb->data_len && !skb_shinfo(skb)->nr_frags). Below is a sample call
> stack:

We should fix the parts of the kernel which build illegal malformed
SKBs rather than adding checks to every driver in the tree.

I'm not applying this, sorry.