Received: by 10.213.65.68 with SMTP id h4csp1808911imn; Thu, 29 Mar 2018 11:25:56 -0700 (PDT) X-Google-Smtp-Source: AIpwx48AvhMBy/HDRZWrkyHYTZVwI1LE6/eaLZNO25IX7jWM4Zw2TvfBcy59H3g7uImHIQL7hQ6w X-Received: by 2002:a17:902:6a89:: with SMTP id n9-v6mr9586966plk.51.1522347955969; Thu, 29 Mar 2018 11:25:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522347955; cv=none; d=google.com; s=arc-20160816; b=HAJuLo3B5MaHjGzgivtOCxAl+rSPtTCTCORsDQwtYSwQ2+8new6iE8GalFIdDMYNpJ Epcb1VG/RGOXkP7W+iBCqB0dcxf7mf3bcQEIA14EkDwVAfXbmH8E7YwCaEQZAONIQKbD 1/62bSmq8cirjxTOc9QCpkToE+2nXM5BmFrAIT5PAiqlwxz9gI1eKDMYyfp21RZI53jf TkLS5j0Ne3KW6mSA5OK35dSZ3uVeREP2sb8TaRDluEkq6qT52Hb31ZtngzwCSRC8Qr/A Kev/0htzgKFt2mR31mvbdxWu0zgU3+TRcV9XRgqp8MVoa82gJU5ZNHu4z6XcNieaGg0L 5WeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=3tG2ZcZIdJvHIwThMF8z/7flrW5i4tCHwhscY8IQbFI=; b=pjB+DBgk86XCSxB6ekwQAbT11sryKK6OPJuFuTxVSIzpmmH8vEBGeaJDMeK2Yl6/yH 9tdthYIRL/5EiKV7DPXqfkFvyKprUwRVF0xwXS3Kjov6Z0tbbos0gJnAxxC4MW/eKe76 11cjMgkFo2LmZAECarej0Qk0sST/odaXS/DtPoQPzBLQpJ44SBXce7QGmGhw9zVKNTcX A9hm14PKIZZfJ03iPRVjECoBEFzRi4PZqcUjvSW02YEQDO21QUuVK7nalYQWEphxb3Cf CyCbf3TDiHaxxFVe09uFf/7HUaDmfS6tbmApvEG6+k/MrWxedEZu2cV6GbV6NzBJLjJL e5Ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r25si4209173pge.759.2018.03.29.11.25.41; Thu, 29 Mar 2018 11:25:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753406AbeC2SF1 (ORCPT + 99 others); Thu, 29 Mar 2018 14:05:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59296 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751893AbeC2SFZ (ORCPT ); Thu, 29 Mar 2018 14:05:25 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 33648892; Thu, 29 Mar 2018 18:05:24 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Madalin Bucur , "David S. Miller" Subject: [PATCH 4.14 36/43] dpaa_eth: fix error in dpaa_remove() Date: Thu, 29 Mar 2018 20:00:31 +0200 Message-Id: <20180329175734.073816441@linuxfoundation.org> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180329175730.190353692@linuxfoundation.org> References: <20180329175730.190353692@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Madalin Bucur [ Upstream commit 88075256ee817041d68c2387f29065b5cb2b342a ] The recent changes that make the driver probing compatible with DSA were not propagated in the dpa_remove() function, breaking the module unload function. Using the proper device to address the issue. Signed-off-by: Madalin Bucur Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -2860,7 +2860,7 @@ static int dpaa_remove(struct platform_d struct device *dev; int err; - dev = &pdev->dev; + dev = pdev->dev.parent; net_dev = dev_get_drvdata(dev); priv = netdev_priv(net_dev);