Received: by 10.213.65.68 with SMTP id h4csp1883474imn; Thu, 29 Mar 2018 12:54:05 -0700 (PDT) X-Google-Smtp-Source: AIpwx49cEqiRF8656KGuDLPVQcxF9bLfIfLURGOfjGGNQ+AJ4eaRZCsFbC23I0QQyGQp8Iagq63N X-Received: by 10.99.103.197 with SMTP id b188mr6428430pgc.108.1522353245877; Thu, 29 Mar 2018 12:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522353245; cv=none; d=google.com; s=arc-20160816; b=BepP5YGzQ4xQGvkqmBDvI91IG5e+jxu4QGYV1NEhbII73lxXjfVLON14P9dQbqzC0P WAgBKIzv44RBOC/7cASA0miLJjjgb9N8HYjI8SBAECyDjrh6xd0QhO3XXF/XPEF6rOFV h4aw/WMMU0fuqORsvsaimvuWp3YFbmgv/VdYiyV03kZLMx7BCdOrmDhu4l/PdhLudsFs crh3RBbzA0rejcZBKZiUr0uWSn50gNjJ6bqrPJz+HVk1kKIHinOSWpZqVpqlRVFEni47 HwY52pY9EkxMiGRH+ga2Uzz8GaVZNJbCqG/NsTP1iK5QS0ZocHuyxZA4IQwG8K0cpKKg cvLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:arc-authentication-results; bh=I6GSM9SoIRHOhaL9DsRr9STl1tAaqpHKGspNorcVoYM=; b=CDozD15Kb3IFbnZfvlB8T5AOLdTXzwq69fQvWyBJpmSS+LjjcPOeWS4SeneBdH6qdm 8CarQk+lUY1LAU4RRUHS9ilDvWMLGMpO16YGSDDZmEe18jdNyGM8+YzjWXEiAxdwcFN2 1rxoT7FpEfPRV1m+YFYamGrn12CnuSV7UTRPSHw8sFbndHLpMpVKdTPjr73T/141b2Ex WAX5HJcbILl8gBrD92IOSTLpBdGQEQaBpJLqjwrvo25J6kCz0+/XTDoJfa7l7a2ChmXK nju39faB24azCnj91I1ld/OxnoUmD//ebPSvEU5nxsbFQzkLXk+SkOt4CfUhWWLLaeOa dTsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p12si4405302pgv.384.2018.03.29.12.53.48; Thu, 29 Mar 2018 12:54:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=sourceforge.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbeC2Tw2 (ORCPT + 99 others); Thu, 29 Mar 2018 15:52:28 -0400 Received: from mout.web.de ([212.227.17.11]:47121 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbeC2TwZ (ORCPT ); Thu, 29 Mar 2018 15:52:25 -0400 Received: from [192.168.1.2] ([77.182.46.140]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M89mf-1efRqQ3BiL-00velS; Thu, 29 Mar 2018 21:52:07 +0200 Subject: Re: [0/9] UML vector network driver: Adjustments for three function implementations From: SF Markus Elfring To: user-mode-linux-devel@lists.sourceforge.net, Anton Ivanov , Jeff Dike , Richard Weinberger Cc: user-mode-linux-user@lists.sourceforge.net, kernel-janitors@vger.kernel.org, LKML References: Message-ID: <4286effd-df51-78c7-3e65-b8a90e1733f0@users.sourceforge.net> Date: Thu, 29 Mar 2018 21:51:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:6iZjYzb4Ese+JReaILOik42Iwp/csLbvMCA4TaTiNQcTlPXiCN/ qL+zzmI7LhZH7bHpmOo8p8V3djUT8D8wPzxvGjZfSJ52yMHyvq4ozbR1z01BxBV+tArArZt LLFiLGTEeEyUmWR6hgDfHk9Pesrpi8fl5RMhCQp9wX5ycuuqv1JRyTUEtGzqBxq8aaKN5IW vC6Uwg1GyEuaiGTc2UAQA== X-UI-Out-Filterresults: notjunk:1;V01:K0:pV78Ag/F26Y=:j73tnON8BUam6w2SVzr6+A G/axRsmmGnKvMRVoeS6isZk4W+ZUFbSpNKOToflNS78YoPlr0AmcYViMDmdLyk9xcHhM4+zTN s4gvcdka0rE34F2C/2dyT83FmPDhow7WjBzYUYBiQimqIINRj8fGjLd/1ilRI6URnajH3DpB+ wH8+bafcNn+fj3RpnYUo6JNednVy8ydz8ijfiBPbrwL8oQOkiQDbwi9Jgw3+LMBjBYpK9oAJk 1ToPMuh842CC02yov5x2Bs87iQKuSVoZRBu8z4lRoVsPo5Wa3JN+lsroxe58yJ/OQJ2Gf0mln t6GYsj3c5BHx6VZhWzzkf1Sz6c2ZnU+5Rl5FjszIcvUfpjOh9EkAmzVEWtCUAGkx7o1VJzrLI fcWMPi53ZaVCBJnV4LM6tN/I65WCELv7+YQ8MoGuqbFXojYWhiFJa1M4HLq6Rv9+fRRTMIGlx uJMh8zKqNRoygEnnqNE/n3gOwQ83/a62DM1/M+Cymtd9u9+dTWUZXmlW2Z++H2JmjVCXbTW83 ahJ8Scq6DNMbIMUfZvRcjZqVjwOxWGb7rXou4M1pCjmCIx+GTzzberDr6bZVtkb5voNedCZ0g bC3O0Y5MaW9mzLEMK5y3j9026tKJ5Qhb2g0vjal5kQvfQ/Oy6TMfNQeZuuRIs0M/Krf1WsOfR Mq1d51qPdD/tDPWqo0mBMpZ689Ea6BeX4/1ea7H11zr1movOUnEx9UoOdH3M5qFdX30IwA147 p/7GZ2XboZFPeJL0gByYcM9P7ColwgWgWOK53f5gFu/eVN1lcmjfcVtD3KrE2cogJhM2z2jAQ cqOu0Q2JsbTlPInouPrObUZcNgyPnjJt6lgkXgbQw++grHnyEU= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Date: Sun, 11 Mar 2018 16:06:16 +0100 > > Some update suggestions were taken into account > from static source code analysis. … > Delete unnecessary code in user_init_raw_fds() > Less checks in user_init_raw_fds() after error detection > Adjust an error message in user_init_socket_fds() > Delete an unnecessary check before kfree() in user_init_socket_fds() > Delete two unnecessary checks before freeaddrinfo() in user_init_socket_fds() > Less checks in user_init_socket_fds() after error detection > Adjust an error message in user_init_tap_fds() > Less checks in user_init_tap_fds() after error detection > Delete an unnecessary variable initialisation in user_init_tap_fds() … Would you like to pick any idea up from this patch series? Regards, Markus