Received: by 10.213.65.68 with SMTP id h4csp2081471imn; Thu, 29 Mar 2018 17:33:14 -0700 (PDT) X-Google-Smtp-Source: AIpwx48puuMnT/WWHXsOUd+d79R6HfJ4zazC9ikK9l2eYC5Xcbe7sL1uDLoAjiE5IysRpCKjuwV/ X-Received: by 2002:a17:902:7042:: with SMTP id h2-v6mr4702471plt.370.1522369994175; Thu, 29 Mar 2018 17:33:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522369994; cv=none; d=google.com; s=arc-20160816; b=h3sU4XZBqL9DecN00cyNwUfd1F5tC9LTzG92i3OyN9rvz+DJLZ6YfQVubquxXYnMC+ THABj4/2r6lYmAkL/4eFCUHdNQDhyo/P+vSJgUXtzeXDr84xEpWMcRg3qO894LjZHMpI V2DP09CP87zz8BiXGT2KOqFmbylnYBJ+BWYzeQpEgRJAa3WX+uZMAxu9A1cQa7tkLIfa klfOsG1X83FBzWEP+mlJbY5vOkjPa4M1+Bheam42Q4FE6A9YZ5eqQNCalTsNo8O0uGHo yV4qo4RlH0Wvhnbjd4YAslG+vRdcQOt/Oilagf6RF75RPe8Yj2ywJSewOktVzm4Lbj/N VfWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature:dkim-signature:arc-authentication-results; bh=xGKDnkmkN8AdIYr5rucL77yw+uUOgU0xI/CeR5MLPXY=; b=MONWxDeoSKRRG33D3vZl0/z8JI/CVV8WwTudRjW2P01s1VL32YEwOSZOokFOEsKLOP CETxI7tqUZq3yiq7Z3ZwT5eFmjDmhwV/nVea+RFRGNK4Fgha9tLoZfSB9fHkSHUnC31w 1/9w4FAQhIwz11C+9Sf72/QAmU+E4DJxNKeIXZL3fF2FVLSlyvPfIriWBVKrMSR8OK1z N4gU7RiwQln8cVuC9FVbLw58UrtL7yDEPop9ERpzf38q/OiWfcwXP5oYLCoW10vMXpF+ CTBhN+5iIZyhPJ4v5B+qV+GlsZJPP+XkrUKVURDR9uZv5bBMUJFEVECgHZLXB5VySHT8 Ox6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FSe8E7Qg; dkim=pass header.i=@codeaurora.org header.s=default header.b=FSe8E7Qg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s16-v6si6931179plq.268.2018.03.29.17.33.00; Thu, 29 Mar 2018 17:33:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FSe8E7Qg; dkim=pass header.i=@codeaurora.org header.s=default header.b=FSe8E7Qg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752367AbeC3Abw (ORCPT + 99 others); Thu, 29 Mar 2018 20:31:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50822 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752247AbeC3Abv (ORCPT ); Thu, 29 Mar 2018 20:31:51 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B4B6E60131; Fri, 30 Mar 2018 00:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522369910; bh=IuwVp+dFURHm+kXKBjpgQHetMLGeBnS/TEI2lo8ayK4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FSe8E7Qgi2AyvXlvSYylVlIRKKj9Roh05HgKx+GxNwFyicIh6kySh178Z43XHfISI elDnwPe00u9c1ggPWDOEPXJHhS+R61EOdSk6UlenBx/E0vaiTH4lsGbBbyxmn4gy1s BFIz/k1Ei2GwHHfVC4DrtYAVNOVLW0L/DC8Zl13I= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from [172.31.99.126] (rrcs-24-43-127-148.west.biz.rr.com [24.43.127.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tsoni@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 593A860131; Fri, 30 Mar 2018 00:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1522369910; bh=IuwVp+dFURHm+kXKBjpgQHetMLGeBnS/TEI2lo8ayK4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=FSe8E7Qgi2AyvXlvSYylVlIRKKj9Roh05HgKx+GxNwFyicIh6kySh178Z43XHfISI elDnwPe00u9c1ggPWDOEPXJHhS+R61EOdSk6UlenBx/E0vaiTH4lsGbBbyxmn4gy1s BFIz/k1Ei2GwHHfVC4DrtYAVNOVLW0L/DC8Zl13I= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 593A860131 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tsoni@codeaurora.org Subject: Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver To: Stanimir Varbanov , Rishabh Bhatnagar , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Cc: linux-arm@lists.infradead.org, linux-kernel@vger.kernel.org, kyan@codeaurora.org, ckadabi@codeaurora.org References: <1522176722-12691-1-git-send-email-rishabhb@codeaurora.org> <1522176722-12691-3-git-send-email-rishabhb@codeaurora.org> From: Trilok Soni Message-ID: <9d6dad94-3e17-2ca6-2921-3f461e8315ca@codeaurora.org> Date: Thu, 29 Mar 2018 17:31:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stanimir, +/* Get the slice entry by index */ >> +static struct llcc_slice_desc *llcc_slice_get_entry(struct device *dev, int n) > drop this *slice* word from function names Please note that we are activating/de-activating  a "slice" of the LLCC and not a whole LLCC. "slice" makes perfect sense here since the granularity is at the "slice" level and not the complete LLCC. --Trilok Soni