Received: by 10.213.65.68 with SMTP id h4csp151459imn; Fri, 30 Mar 2018 02:55:32 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/nPnFYwrpocfjQ+0bzZIQob1XJpkkhump5KTWzgeXM+zyEZqMNldIQYCRiRamdafozKXnG X-Received: by 10.98.174.5 with SMTP id q5mr9278373pff.155.1522403731974; Fri, 30 Mar 2018 02:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522403731; cv=none; d=google.com; s=arc-20160816; b=Bqd0bemHdogXBQc8Y3vcNQHrqwpoUznG+eLdydjLzbk5rkLWnedFuOASJdR29JE77y LtU9lTOaQg6Sys/B9NW/lr3jNE8a8xfG58u7Kh31dE7M9YX3Cu2T1U2UG4DTl4WOFAHB ZshQ/BFHcneL9x5fw41aZKAWOBCaki4jH06ujuEtZ6jknKAcfUc85RgHcqqJAcrnIBhz IIACAcHwzrq8YudaT/xL8Xd3xjwwcJ244T7XW8pwn64HeKfDR2sFF3C+UfkqQd3Nr9DH PwiPE7TbRp2qwz8RgagDWUU1LoVGblR7Bysdhl6OXY2BNkRo3SSPipcg37hWhUp1fvOP Itzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=smpbBPkwMUVnqNw2Sglea1t96nlIbOIjWMRc59l3I7o=; b=djMpYp3kYHxPoADJNBsi86gzBfIPr97DTFWIqi8yqEQ9pepG9NTFQ6ikb6xbs1RL3z dbBSPPZStgrFFXFnUcUgR8zDm+KLGZUsO2slEuKk99mkBE0R87+zO52aWPviasSLvKiW EILV5WGac4O5nIx9G6wvBAHMYO1D3El+ltjZtFKbgjbKUkmwWsr1KI+vBkpUT4qQgtJ7 SuHvCtU0Qd2oQgnCK280eqjwSsQMD91QUJb81jpedLwnrTzX7eBiEvBCo5bjGpGdbrof cpOMha54HCygwZ2KoIRDaW4lZq+orScMHbtzQzjAnKEpO+cF3vg0fNeMWgTX88ffvvqP pDWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g6-v6si8526159plt.580.2018.03.30.02.55.18; Fri, 30 Mar 2018 02:55:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751345AbeC3JyN (ORCPT + 99 others); Fri, 30 Mar 2018 05:54:13 -0400 Received: from mail.us.es ([193.147.175.20]:55476 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbeC3JyL (ORCPT ); Fri, 30 Mar 2018 05:54:11 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id E64185B853 for ; Fri, 30 Mar 2018 11:53:52 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D7B8DDA7F7 for ; Fri, 30 Mar 2018 11:53:52 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id CC754DA78B; Fri, 30 Mar 2018 11:53:52 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.0 required=7.5 tests=ALL_TRUSTED,BAYES_50, HEADER_FROM_DIFFERENT_DOMAINS,SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 06133DA787; Fri, 30 Mar 2018 11:53:51 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 30 Mar 2018 11:53:51 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [31.4.241.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id A71454265A2F; Fri, 30 Mar 2018 11:53:50 +0200 (CEST) Date: Fri, 30 Mar 2018 11:54:06 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Joe Perches Cc: linux-kernel@vger.kernel.org, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH] netfilter: ipset: Use is_zero_ether_addr instead of static and memcmp Message-ID: <20180330095406.chw56e7rizhmcfuo@salvia> References: <687a4edaed07441681d3bfe3b63aa4feb55b9d61.1521567319.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <687a4edaed07441681d3bfe3b63aa4feb55b9d61.1521567319.git.joe@perches.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 20, 2018 at 10:35:47AM -0700, Joe Perches wrote: > To make the test a bit clearer and to reduce object size a little. > > Miscellanea: > > o remove now unnecessary static const array > > $ size ip_set_hash_mac.o* > text data bss dec hex filename > 22822 4619 64 27505 6b71 ip_set_hash_mac.o.allyesconfig.new > 22932 4683 64 27679 6c1f ip_set_hash_mac.o.allyesconfig.old > 10443 1040 0 11483 2cdb ip_set_hash_mac.o.defconfig.new > 10507 1040 0 11547 2d1b ip_set_hash_mac.o.defconfig.old Applied, thanks Joe.