Received: by 10.213.65.68 with SMTP id h4csp232895imn; Fri, 30 Mar 2018 04:35:24 -0700 (PDT) X-Google-Smtp-Source: AIpwx48zBStb/ealrHbNW8/2RSmgv/MwCIEzENVFFjZtafdjm3AxZ072zVu2/BFsLVz7zGNjRk0S X-Received: by 2002:a17:902:a2:: with SMTP id a31-v6mr12567394pla.204.1522409724901; Fri, 30 Mar 2018 04:35:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522409724; cv=none; d=google.com; s=arc-20160816; b=iMogQB01/GXkA2Vdkbv4+SQR//DDCv1oiQ1xBqZWg8mzBSx8wrYZvakf9XiRZko8Gl tEiFuu+HjCoS/wvZo57+RL0BYSzcEQoUJznItLdb4+uxrmobxJHH+SB9p9lLL6EE/H8P ogpo/MIcPEo1Wwqd1bbYVEN2J6KhGYhij1xJzui2pTpodpk4/5U9DtZhIs0uqgQ3AvAp gOjnnzabLJ6Yg6dM0Af6odqx14EqK/oPC8xXY6SBBUYFlt/q9hQhLtJmTKzUtBjEkyy7 pD0evKrKtmGRz1EBNEYniLpkt8B5ghfNMPBkjlmn5uNMpDcoLja3CrtcN3nBQ9QaNXJJ Q0+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dmarc-filter:arc-authentication-results; bh=cY5h6orC0Lq5G/58+HuYO//5ppI1LwNGYq5k2wJ7KuI=; b=kgGdNmDCKpnbnpXYZSzMD9akH+lBE+QNsHiCkZRGGmw8fuAU07zGpmEBGOfVrCpltr rDHG+dCDzlWtPcXQBfvLI+Z3517aA5EDEVSoXzJLG7cFmzkqF0B/MyRXme36KvKyfSm+ Gis/uANwKJdCEU0wC+2TBCBSTQSJoIpk6mRf4RJLwqs6rRRclHVl76qjolrYJh1O5nWI 95dcmsifHzj+R9sAe/+WjLEBsHvKvvW7KH2p2IviHlubtovTrmgbdnvkU8l0J8TJWRu2 dAM8Y06Yet4quK4MRktXpx+EYTRoSslhDNNzDbQVw2sXCApLwq//lwnG9ITAEZv5e9gD n20w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w69si756521pfd.332.2018.03.30.04.35.10; Fri, 30 Mar 2018 04:35:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbeC3Lcq (ORCPT + 99 others); Fri, 30 Mar 2018 07:32:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:37678 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750794AbeC3Lco (ORCPT ); Fri, 30 Mar 2018 07:32:44 -0400 Received: from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net [81.96.234.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D97582175B; Fri, 30 Mar 2018 11:32:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D97582175B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Fri, 30 Mar 2018 12:32:38 +0100 From: Jonathan Cameron To: Shreeya Patel Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, Michael.Hennerich@analog.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, daniel.baluta@gmail.com Subject: Re: [PATCH v6 2/6] Staging: iio: adis16209: Prefer reverse christmas tree ordering Message-ID: <20180330123238.51d9b2a5@archlinux> In-Reply-To: <3f021293e6183f6fefb597a9a01b762b73d69bc3.1522306893.git.shreeya.patel23498@gmail.com> References: <3f021293e6183f6fefb597a9a01b762b73d69bc3.1522306893.git.shreeya.patel23498@gmail.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Mar 2018 14:43:23 +0530 Shreeya Patel wrote: > Prefer reverse christmas tree ordering of declarations to > improve readability. > > Signed-off-by: Shreeya Patel Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > > Changes in v6 > -Introduce this new patch in the series. > > drivers/staging/iio/accel/adis16209.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/accel/adis16209.c b/drivers/staging/iio/accel/adis16209.c > index 0e6366a..8f4fa6b 100644 > --- a/drivers/staging/iio/accel/adis16209.c > +++ b/drivers/staging/iio/accel/adis16209.c > @@ -270,9 +270,9 @@ static const struct adis_data adis16209_data = { > > static int adis16209_probe(struct spi_device *spi) > { > - int ret; > - struct adis *st; > struct iio_dev *indio_dev; > + struct adis *st; > + int ret; > > indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); > if (!indio_dev)