Received: by 10.213.65.68 with SMTP id h4csp323062imn; Fri, 30 Mar 2018 06:17:27 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+MlKm+eIwYgniqP0oEiM0cC3oDQetiHD7ycpqKEPti+nHcgUq6UdZcMu7/KbLTe/2UKKOc X-Received: by 2002:a17:902:22a:: with SMTP id 39-v6mr13097067plc.128.1522415847872; Fri, 30 Mar 2018 06:17:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522415847; cv=none; d=google.com; s=arc-20160816; b=kX/Lgjoi9a+HrQZClkkhJJN/k+GU6vv5Zhfn6P5Oo0hijHWGnkCL4OrSXoWGQfoaH7 MoCNrGgfLvvf/NQlklQmU/KrkjWavs52htNA24t5Eal8/Wt93qzlnpj+4iTg/kqkVIx+ JEIvaHSipFNLUqYHA5GB86/InwUFBzh6PKiYkACj+E3geQPHz1ijoQBTt94TaTTA7xvi ZGgTunQljbypTBLqSed5ZM6SNp9XSW/X6X0QIaBx3qEXMMVA0PjRp1Rb+Zd1LzypYD5y xQZA+4j3eH6OmIhI+cOPfyqHabniHaQs2HOnxyQVeDZFwpb0CRFpdK2tsKWpo0E4dx1C 9YQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=Q9E1Pt3NUrK7Kid7TtZggV5nX0AewjZkoYddVNtQEdE=; b=e+e4XV9B3HI0Zj2AzGWeQbr0ljg3kIP3ZtXRU8vtfgOX3WfL73fD7I20/dxbb1GS4K tP6LF5/BX9Go5DjHMkWiyCqHXxxKSdkbeZDEy6c2UfpZPWgLUmYkT8OAAg80Ll3P2+BF TpM46MZGBcGtMJcuMhd/wAWYYZ5s1UmSt+64W5EyOAokDy9awMLur4eNQJlF8cYDSKCz lbIQx3qmfjiABt9MUNKe+/B3OCtT7u8aSN3cju+raxhpLsWwNjhJBJEQI7L91ZLwb2/3 qewEwMql7RqrmbmxvyUqDDH4uTn72LtjFjNpfMGG6FWyEunzId+c7toGnoOacuB6vx/k ChTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8-v6si8466984plk.538.2018.03.30.06.17.11; Fri, 30 Mar 2018 06:17:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbeC3NP5 (ORCPT + 99 others); Fri, 30 Mar 2018 09:15:57 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57782 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbeC3NP5 (ORCPT ); Fri, 30 Mar 2018 09:15:57 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: sjoerd) with ESMTPSA id 1C0E5263A29 Received: by beast.luon.net (Postfix, from userid 1000) id BCA603E230E; Fri, 30 Mar 2018 15:15:53 +0200 (CEST) From: Sjoerd Simons To: dri-devel@lists.freedesktop.org Cc: kernel@collabora.com, Jyri Sarha , David Airlie , Tomi Valkeinen , linux-kernel@vger.kernel.org Subject: [PATCH] drm/tilcdc: Defer probe if there are no connectors Date: Fri, 30 Mar 2018 15:15:53 +0200 Message-Id: <20180330131553.9060-1-sjoerd.simons@collabora.co.uk> X-Mailer: git-send-email 2.16.3 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During probe there may not be any connectors yet if e.g. the panel failed or hasn't been probed yet. I hitting this in practice the panels probing was being delayed due to using a gpio backlight. Fix this by returning -EPROBE_DEFER so the probing will be retried. Signed-off-by: Sjoerd Simons --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 1afde61f1247..59f0a44bb6e3 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -380,7 +380,7 @@ static int tilcdc_init(struct drm_driver *ddrv, struct device *dev) if (!priv->external_connector && ((priv->num_encoders == 0) || (priv->num_connectors == 0))) { dev_err(dev, "no encoders/connectors found\n"); - ret = -ENXIO; + ret = -EPROBE_DEFER; goto init_failed; } -- 2.16.3