Received: by 10.213.65.68 with SMTP id h4csp438741imn; Fri, 30 Mar 2018 08:22:25 -0700 (PDT) X-Google-Smtp-Source: AIpwx49TIpyULfkbY9DAyVn84itJ1xXidPvuDiRD1dn5EHBt5DVWYHUP4dKoLLfCG3UnrEhWyULb X-Received: by 10.98.227.16 with SMTP id g16mr9939246pfh.171.1522423345498; Fri, 30 Mar 2018 08:22:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522423345; cv=none; d=google.com; s=arc-20160816; b=sMi5rLY6S6S5cwtb6U1OhhwrXnF4TDLKSJ+pI6h3XJAaTzugC6LNyQRrdKAuuj+nzD zovmljcLCkgv/ShSwxOLOzPKVni4UWt8GnA28GL+YRaXq0u7XVidpQJeBX8yG/SYCUSK rS2//P0njYnziRelNuZh6eUU+ORagLGZU20EHOke8rLBFmdvpSgfWjMN5v19donGc3Si XiTHqGhc27B8rFaiISF8Se9EbHxvE0ge7ljJk8cLQFQKaNDtGRUbqAzOrdWJUA4RGCUX /OMD7nTL1xWHGTNZFLnwOmP4YvYUA84+2I5tpfnGUB+HP977YvoGcUGDw5gd0K3TtNfa IkTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=FV0NDg/x1ZLvMiAPXhE1SKZRXn7+vHSEjCFtz8wRH4U=; b=K6niCTMpyGaiwn7UzoSmnUOFNxL68mKCehcCA7aFDzIPxKmq2QQMXBigvkl+UnN395 uPfJHQWnWcorEUsoXZ43ozCIPB4/RFXd8gI5+V87uiNWv4R+XMr4jOubRHtb3Oh5Xvyg iHLV/9yviH+KGdMttb8XECc5rvjLZO+iE1fPdmnJGws9D44nmI2gt+J3DqLq46iM1FFH K4mrl+c6qi/OUWObgl61zLO1xDyJnZABZwtwXXLAMRUAohicdqYiuCvMZBHljEOdVunP M+uV/D6Cy4DTTDcoHWqMd2++w5xRjcmOgDz/81//Be7CQO83/f1q1Lxfua8S5xkr1TGU KOlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n7si5391245pgv.607.2018.03.30.08.22.11; Fri, 30 Mar 2018 08:22:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbeC3PSL (ORCPT + 99 others); Fri, 30 Mar 2018 11:18:11 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:59430 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751195AbeC3PSJ (ORCPT ); Fri, 30 Mar 2018 11:18:09 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from haswell.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 11216171-1500050 for multiple; Fri, 30 Mar 2018 16:01:38 +0100 Received: by haswell.alporthouse.com (sSMTP sendmail emulation); Fri, 30 Mar 2018 16:01:37 +0100 From: Chris Wilson To: linux-kernel@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org, Chris Wilson , Steven Rostedt Subject: [PATCH v2 2/2] trace: Mention trace_clock=global when warning about unstable clocks Date: Fri, 30 Mar 2018 16:01:32 +0100 Message-Id: <20180330150132.16903-2-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180330150132.16903-1-chris@chris-wilson.co.uk> References: <20180330150132.16903-1-chris@chris-wilson.co.uk> X-Originating-IP: 78.156.65.138 X-Country: code=GB country="United Kingdom" ip=78.156.65.138 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mention the alternative of adding trace_clock=global to the kernel command line when we detect that we've used an unstable clock across a suspend/resume cycle. Signed-off-by: Chris Wilson Cc: Steven Rostedt --- kernel/trace/ring_buffer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index dcf1c4dd3efe..88098d7fac06 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -2637,7 +2637,8 @@ rb_handle_timestamp(struct ring_buffer_per_cpu *cpu_buffer, sched_clock_stable() ? "" : "If you just came from a suspend/resume,\n" "please switch to the trace global clock:\n" - " echo global > /sys/kernel/debug/tracing/trace_clock\n"); + " echo global > /sys/kernel/debug/tracing/trace_clock\n" + "or add trace_clock=global to the kernel command line\n"); info->add_timestamp = 1; } -- 2.16.3