Received: by 10.213.65.68 with SMTP id h4csp537248imn; Fri, 30 Mar 2018 10:15:03 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/skoCULqOWh7feaKFp8TzW4iOp/cbGhehlbQUufYGv7MW41bh2pdAZ4CRkj0yT1fzJ673m X-Received: by 10.98.174.23 with SMTP id q23mr10523102pff.103.1522430102989; Fri, 30 Mar 2018 10:15:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522430102; cv=none; d=google.com; s=arc-20160816; b=kNuERB4AxA35ihMIjANIFTCPR6HiB41c4IfQCZf/H42fRXlS1DmPJyFBkLDRrAYEiX aGokZ9GkNLPB3K7L/FvmYnFRgub5iKxD2J6+wxsQzB+yQ3iwL5LHY+LUPb5ujaK1O1rH Tixq0f2c+N5QEjSGN3iGfICbUZ8tZHrmdffY53T3qnGcNBTUKaS2+9hN+B0eZR19C/Vy hJ7qLK9e4lAcgLgAaKggnMQgjwZE6EYyACbJ3LW1smbFt/3mBUMIVdFWFvMx9DiYZ/B5 kFn1KjLjA+4QKlWyn17ydGzNHWEjCCJr2lQTzNEpbqQRauE7fyuI57NmOgYD7MpkMlDN awzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=hk3pAhaz12JJOWC2VNXF51+o7tvSFjUnPlWOVySdJ+E=; b=BnBOVX5aiRJbGKMphurIOI46T7aOUz+h+euLz3vFV8M0t8ghYe3BMhzNs/KiKwlRap ZFOQVqVW+YMMqFs+oOoPzGfeCSEwwM0b+k6UI5kalzJiM7nH019nEdHMjUHlE4rpLW2d zBF+/Wx8pSJp/lYKC+ae9woj2uSjr1e7yQjWpXUFlE6V/HD07BExD2sSyZDeTA1/VP3k gGkKoORCW9PNs3gMCdjjl96W3a9DrXdUiQBtXiC24lzdUd7IxwGUZupBBBbF+wdm/t7C lQyvMMs8BWpmM1YbLoXWwxEZbxIKjaLGuQJ4VdaxpCRssSrUnDRxkJ+SlfoaCau9Whbv 895w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=TlfbdT7E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d76si6460935pfe.240.2018.03.30.10.14.49; Fri, 30 Mar 2018 10:15:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=TlfbdT7E; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752197AbeC3RN3 (ORCPT + 99 others); Fri, 30 Mar 2018 13:13:29 -0400 Received: from vern.gendns.com ([206.190.152.46]:38325 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750927AbeC3RN1 (ORCPT ); Fri, 30 Mar 2018 13:13:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hk3pAhaz12JJOWC2VNXF51+o7tvSFjUnPlWOVySdJ+E=; b=TlfbdT7EFijzw/aE+h1x3AAMf8 cd1L7f+aQUTv0dlSYfX9yYhsJZvkmkh7MkbG0/bsScZsBKVhbpolwzOd2TbFQ/uBc8DpDe4jNUn/T yIscdc7bb6CkhNMqa971981tIdKfzeR6SjvIEyEszE86KmMpYXMLlZDl/++E3WFhm8oq6nzzTqqzY HcYKYVZOiJYC4AoThiS1jc/YpcAxGW9q2pZ561e04QKsaDSOXEy1ygbZPL0V6FWFG2zOrp6Gnr9zo W2t17JcmNNuNRG9aaxAW6n6rZNVYmc0tc5yB1y7xmVWAR9y+/LT0uRUPGU1XcAvNsPEFzFXPItYqm eSVA0ccw==; Received: from [192.135.141.193] (port=55191 helo=gerda.local) by vern.gendns.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89_1) (envelope-from ) id 1f1xae-003oNx-74; Fri, 30 Mar 2018 13:13:24 -0400 Subject: Re: [PATCH v5 4/8] remoteproc/davinci: add the missing retval check for clk_enable() To: Bartosz Golaszewski , Sekhar Nori , Kevin Hilman , Rob Herring , Mark Rutland , Russell King , Michael Turquette , Stephen Boyd , Ohad Ben-Cohen , Bjorn Andersson , Philipp Zabel Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-remoteproc@vger.kernel.org, Bartosz Golaszewski References: <20180330152856.12297-1-brgl@bgdev.pl> <20180330152856.12297-5-brgl@bgdev.pl> From: David Lechner Message-ID: <6d4dcee6-6480-03fb-c0f8-f750d22f8cf6@lechnology.com> Date: Fri, 30 Mar 2018 12:13:28 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180330152856.12297-5-brgl@bgdev.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/30/18 10:28 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The davinci platform is being switched to using the common clock > framework, where clk_enable() can fail. Add the return value check. > > Signed-off-by: Bartosz Golaszewski > Acked-by: Suman Anna > --- Reviewed-by: David Lechner