Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 30 Mar 2018 19:56:45 +0100 (BST)
From:   James Simmons <jsimmons@infradead.org>
To:     NeilBrown <neilb@suse.com>
cc:     Oleg Drokin <oleg.drokin@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 01/17] staging: lustre: remove invariant in
 cl_io_read_ahead()
In-Reply-To: <152229760825.27689.17083243052405696738.stgit@noble>
Message-ID: <alpine.LFD.2.21.1803301956160.9681@casper.infradead.org>
References: <152229732768.27689.4800156943561963977.stgit@noble> <152229760825.27689.17083243052405696738.stgit@noble>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> This invariant can fail as ci_type is somtimes CIS_INIT.
> 
> According to Jinshan Xiong, or of the most recent significant
> change to this code, "We should get rid of it."
> 
> So do that.

Reviewed-by: James Simmons <jsimmons@infradead.org>
 
> Fixes: 1e1db2a97be5 ("staging: lustre: clio: Revise read ahead implementation")
> Cc: Jinshan Xiong <jinshan.xiong@intel.com>
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>  drivers/staging/lustre/lustre/obdclass/cl_io.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> index ab84e011b560..fcdae6029258 100644
> --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c
> +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c
> @@ -599,7 +599,6 @@ int cl_io_read_ahead(const struct lu_env *env, struct cl_io *io,
>  	int		       result = 0;
>  
>  	LINVRNT(io->ci_type == CIT_READ || io->ci_type == CIT_FAULT);
> -	LINVRNT(io->ci_state == CIS_IO_GOING || io->ci_state == CIS_LOCKED);
>  	LINVRNT(cl_io_invariant(io));
>  
>  	cl_io_for_each(scan, io) {
> 
> 
>