Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 30 Mar 2018 19:58:58 +0100 (BST)
From:   James Simmons <jsimmons@infradead.org>
To:     NeilBrown <neilb@suse.com>
cc:     Oleg Drokin <oleg.drokin@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 07/17] staging: lustre: ldlm: free resource when
 ldlm_lock_create() fails.
In-Reply-To: <152229760844.27689.4330202028940942080.stgit@noble>
Message-ID: <alpine.LFD.2.21.1803301958530.9681@casper.infradead.org>
References: <152229732768.27689.4800156943561963977.stgit@noble> <152229760844.27689.4330202028940942080.stgit@noble>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> ldlm_lock_create() gets a resource, but don't put it on
> all failure paths. It should.

Reviewed-by: James Simmons <jsimmons@infradead.org>
 
> Signed-off-by: NeilBrown <neilb@suse.com>
> ---
>  drivers/staging/lustre/lustre/ldlm/ldlm_lock.c |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> index b8fd778d9832..614caa4a9b0e 100644
> --- a/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> +++ b/drivers/staging/lustre/lustre/ldlm/ldlm_lock.c
> @@ -1551,8 +1551,10 @@ struct ldlm_lock *ldlm_lock_create(struct ldlm_namespace *ns,
>  		return ERR_CAST(res);
>  
>  	lock = ldlm_lock_new(res);
> -	if (!lock)
> +	if (!lock) {
> +		ldlm_resource_putref(res);
>  		return ERR_PTR(-ENOMEM);
> +	}
>  
>  	lock->l_req_mode = mode;
>  	lock->l_ast_data = data;
> @@ -1595,6 +1597,8 @@ struct ldlm_lock *ldlm_lock_create(struct ldlm_namespace *ns,
>  	return ERR_PTR(rc);
>  }
>  
> +
> +
>  /**
>   * Enqueue (request) a lock.
>   * On the client this is called from ldlm_cli_enqueue_fini
> 
> 
>