Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] blktrace: fix comment in blktrace_api.h
To:     Souvik Banerjee <souvik1997@gmail.com>
Cc:     Eric Biggers <ebiggers@google.com>,
        "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Shaohua Li <shli@fb.com>, linux-kernel@vger.kernel.org
References: <20180330193243.26044-1-souvik1997@gmail.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <c13a34d5-9e4f-6c57-2b56-63dcb6c9ae27@kernel.dk>
Date:   Fri, 30 Mar 2018 14:17:07 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <20180330193243.26044-1-souvik1997@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/30/18 1:32 PM, Souvik Banerjee wrote:
> The `__u64 time` field of the blk_io_trace struct refers to
> the time in nanoseconds, not in microseconds. It is set in
> __blk_add_trace, which does the following:
> 
>     t->time = ktime_to_ns(ktime_get());
> 
> ktime_to_ns returns ktime_t in nanoseconds, not microseconds.

Thanks, applied. Back way back when it used to be in microseconds, iirc,
I'm guessing the comment dates to back then.

-- 
Jens Axboe