Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] nvmet: fix nvmet_execute_write_zeroes function
To:     Keith Busch <keith.busch@intel.com>
Cc:     linux-kernel@vger.kernel.org, hch@lst.de,
        linux-nvme@lists.infradead.org, sagi@grimberg.me
References: <1522444730-2060-1-git-send-email-rosattig@linux.vnet.ibm.com>
 <20180330212439.GA28945@localhost.localdomain>
From:   =?UTF-8?Q?Rodrigo_Rosatti_Galv=c3=a3o?= 
        <rosattig@linux.vnet.ibm.com>
Date:   Fri, 30 Mar 2018 18:48:18 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <20180330212439.GA28945@localhost.localdomain>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Message-Id: <93622938-f532-b8ac-2bca-fe40ed759e71@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> Doesn't that mean your host is using this command wrong? The NLB is a
> 0's based value, we're supposed to +1 to get the correct block count.

Keith, I tested passing different values to the c (number of blocks) and 
s (64-bit LBA of first block to access) parameters, and it was failing. 
When I removed the +1, the command worked fine.

I used a simple script to validate this:

for s in {0..20}
     do
             for c in {0..20}
             do
                     nvme write-zeroes /dev/nvme0 -n 10 -s $s -c $c
             done
     done


Is there some other way to test it?

-- 
Rodrigo R. Galvão
Intern - Linux Technology Center - IBM