Received: by 10.213.65.68 with SMTP id h4csp362785imn; Fri, 30 Mar 2018 23:14:01 -0700 (PDT) X-Google-Smtp-Source: AIpwx48j1ucJ0StwrH45z97+M2MXDYAl/LDrjj7adVPbK98WM0Vh7NJGnRfeB2r4BAZZfF1OWk4C X-Received: by 2002:a17:902:3124:: with SMTP id w33-v6mr1966904plb.119.1522476841742; Fri, 30 Mar 2018 23:14:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522476841; cv=none; d=google.com; s=arc-20160816; b=Hlo6VPDMcrer4O4aK219Jezz337Jarn2XMwYuELHXPqmkoioB5PNltKnEvCds8hiYk 0cCPxx+17PLbF/Qc4Aq4dtk1BddV5ePihlBpsv24bNawaKhxO2tEAPZxhbRDmqmE9eHz DbaWAJq/2pYLJZX1Ebtii2VF2sINiKqgvFKaOSQQ08oo6aqwGumglR+3qTjGOgJxyuOR lrFp+j6CeeJhE0U093CcMdVB1TBTm6A/zAi0RJsmtgMIurIOy1rSy0uXgy55nCagnUjR yfdAAKd9Qn+GzTvomAD/ftuSFUXAHzWBRanS8Qbf0XZGx0OE9qV2xr0tFiL71QmQf8oO M7zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=toZsHcJ5V4Fb9J9FAQx56aAn4a5VxmvX4VFMjwp/Po4=; b=wlhzBRErPLqAzdcLMqO5luG7eUBLrgIcIy8f5BmcSDD15qDpJAVnZr7RqCsZmdonQ2 DxH/pXk+b8wf3evVhfoz0iufUHWuzV2dQbATT+AsdNqYvfywZul4zEiK1Ru41XowdHQj rcLGr2Dp2yMQXX4aRKf64uSwJHy4YNQm6ZSWulTmTZUp95HvcIGJ4jiMTlK+tlwg8PwS KITw83scm9VdLVHv1Vin+T2Ra5sUh1BEIsvLxtdenTQfZZsOpGcCN8X/9rZxkWMRMN3+ WbjHWf5sC21sZ1+gOatI9ePOF3UpSeYdheM3Wg1YFWq21r8UFqhsja2d1V4ZKBAzYZmD md8A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z11-v6si10118942pln.732.2018.03.30.23.13.47; Fri, 30 Mar 2018 23:14:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753488AbeCaGLs (ORCPT + 99 others); Sat, 31 Mar 2018 02:11:48 -0400 Received: from mout.perfora.net ([74.208.4.194]:43637 "EHLO mout.perfora.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753374AbeCaGK2 (ORCPT ); Sat, 31 Mar 2018 02:10:28 -0400 Received: from kahja.local ([73.170.116.139]) by mrelay.perfora.net (mreueus002 [74.208.5.2]) with ESMTPSA (Nemesis) id 0Lr0tB-1eNt592DEB-00edeB; Sat, 31 Mar 2018 08:10:24 +0200 From: Quytelda Kahja To: gregkh@linuxfoundation.org, wsa@the-dreams.de Cc: driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Quytelda Kahja Subject: [PATCH v2 71/75] staging: ks7010: Remove dummy address set. Date: Fri, 30 Mar 2018 23:08:51 -0700 Message-Id: <20180331060855.9452-71-quytelda@tamalin.org> X-Mailer: git-send-email 2.16.3 In-Reply-To: <20180331060855.9452-1-quytelda@tamalin.org> References: <20180331060855.9452-1-quytelda@tamalin.org> X-Provags-ID: V03:K0:2RZxplgVOMXvPKWTfkh9ZXh3ZC+bp6b0Rg4BBcTfnVa25+MA5mK uVl+54QknTg0+2dYmRbrUDXWGRNUTg94XAkIgLpus3o8tSuRDjr12pEHB7X4KUpfYwi7dEn wtbVqWRY4HO/WJAg6u9deTF8rkxBWKKVTm1q/O8WTQ0vI2hQuTJQfx1SWM5CEPnAoNsdQlG JUCU0P4doATlqP+udJb3g== X-UI-Out-Filterresults: notjunk:1;V01:K0:lhEpFCQ+Iuw=:1UX8w/2eSSJGhxXhbgV4F/ 5xz/yQEvA3TaTS19xqEiO+mye9zBgaVWRBDJA4LENC5PohPbAq0IWNrZu+o4w41ugvzSE+7EC ngPufu0tlXkaote2iB/unB2D3mHDRzuzrADhv31iccLo6HBxYTG+x3cz4LAv/kXXemHC9BACd mjMe6aahtfbrJkNWVtY0BzGQ9vh3bne3AjQjlZ54R5xpMWwkifmJY8YpQL2XXhnM4GXwdAR2t 183LDxQMgwTwWLimIWWplh9IAC/8xwJb2cFJtT8uYY9vykOhMjWA9wBq8vcNRWmGXsQfAc3xU miIHZdUB05IEmgmgEPQJC3HuyjgiwPrA6Zf6LrNdM6COWf5nSmeiRlh/Z6oRVN6fVy+KNcktk kfdGBX7DsY/EzkL1D8fkQ/4hcyz0k8z99smmvlIX2yF1a9vVSAIhxhOS9COiU14MEqZ9sEacr y0WrYjsduzd6pqnzxybr6YV28hxn1kxOeHpvltfG4s2Buhq1qOYDzjF4Zx9Dgv73nx13kP3vh 80Ey5xEOwqyho2i2Az0qcO6rt7obhuTET0R2R6zWMjsEI2UJEThg40W5MQG/j541Qb9JEBK7r +46D12AYyXNARNnv/R+EDSaOmnqj9zxwYISY9BDUQ38TAE+aX79tW2d+yEsVxUXWKzAaxZ6Dy GwSj/mGfZWUsJxL5cEPWO0cU9rl5lOE7MsWnu9Qc4Z1Rf82BSLLHALzv+d6Dx4Rv7J63i3wJi MryqY4MRGheFLukAbstyOc5bYgv2peKG/0yz3Q== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Setting a dummy address during the driver probe is not necessary. The dev_addr field is already zeroed out from alloc_etherdev(). Signed-off-by: Quytelda Kahja --- drivers/staging/ks7010/ks_wlan_net.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index 5c5569000fce..afbc472baa05 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -2852,9 +2852,6 @@ int ks_wlan_close(struct net_device *dev) /* Operational parameters that usually are not changed. */ /* Time in jiffies before concluding the transmitter is hung. */ #define TX_TIMEOUT (3 * HZ) -static const unsigned char dummy_addr[] = { - 0x00, 0x0b, 0xe3, 0x00, 0x00, 0x00 -}; static const struct net_device_ops ks_wlan_netdev_ops = { .ndo_start_xmit = ks_wlan_start_xmit, @@ -2882,9 +2879,6 @@ int ks_wlan_net_start(struct net_device *dev) atomic_set(&update_phyinfo, 0); timer_setup(&update_phyinfo_timer, ks_wlan_update_phyinfo_timeout, 0); - /* dummy address set */ - ether_addr_copy(dev->dev_addr, dummy_addr); - /* The ks_wlan-specific entries in the device structure. */ dev->netdev_ops = &ks_wlan_netdev_ops; dev->wireless_handlers = &ks_wlan_handler_def; -- 2.16.3