Received: by 10.213.65.68 with SMTP id h4csp448361imn; Sat, 31 Mar 2018 01:43:52 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/hc7crxsf+Lhm/a0NJ/nu79RGwWwGBbf56PSKLqYwFt6t7Bk7BGY/644TcqezoZ5F42flU X-Received: by 2002:a17:902:ac8a:: with SMTP id h10-v6mr2279727plr.290.1522485831960; Sat, 31 Mar 2018 01:43:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522485831; cv=none; d=google.com; s=arc-20160816; b=uf+hh7XVZtPW89lxBye1O4sYYg7NEkdxvwGjMIu4htUhYuiWKLZrL8a50f74yYnpld zqc9/JpaT8xQeVa+prQYX1le8kyrvF6vnBSrRODGnfYSQ4g4vVYXp+KaVBDuD1eqniv6 x1TTIRSQUK6LjqkMguWLwJN2HuJlXP1IMXotlMEWL/kWL9/yuhpWayWH/Ax0uCEzEKuS +uJyl/tT4lELzs8vHhDXsT8kG1tPsfpj5dqPl7Cknud2RhDHbkV+MvGcm3bhipOlYu+h dmV845WJVFDSaEKagoZJGDNFpQO2u3oyyKZQrBikRxNlbFYIvh6NomLi74tUCNX99pqa dHEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=DJ4bV79OHpvMUIICQnwEjm4WdOgzSLvG1QbDIrmeHGo=; b=RE87rUUHu7Cg1t3fgO5+TXHRg2OnIe8y0Q9al2rT3D2w4ul2pIf54MQuaLIX0xQl4G F/ZmebEOwHbo/F+xZaDN6LH/FQQyhdM8oAt60w3zM+XaYpdeV5dMne33SG1sCzGiPief b8tPOFm0d7HAWySchIfru0ONqViRex4KXT4E29Si0uqH+5wV7ef9881FscoD+gnDp0NK pptE785E65C6PQHGPsswee7JwZWZSs6CciaL7t8oDoFFKed7fx5ZMMgpIu+xcM7uICT1 uZMRFlLRKgzg3a3KugttvXC6OvocsKwjLp5zVKF5rmyvvzTWAtccz/Aq1HlrV+FORnu7 o/3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=g/L+dtnz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10si6644992pge.245.2018.03.31.01.43.37; Sat, 31 Mar 2018 01:43:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=g/L+dtnz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbeCaImO (ORCPT + 99 others); Sat, 31 Mar 2018 04:42:14 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:60324 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbeCaImM (ORCPT ); Sat, 31 Mar 2018 04:42:12 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2V8U2m0020935; Sat, 31 Mar 2018 08:42:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=DJ4bV79OHpvMUIICQnwEjm4WdOgzSLvG1QbDIrmeHGo=; b=g/L+dtnzAUH6sXsrLYnYe2p3sJn77m5e0gcY3Dql4ZKFNAUcNeXVLUfTspnVBK3fUh5y gyzCX6HmjT/3xmFOlJ3DxO79e3raDxywzcJm7adXb2TYZ0s+EofOfy9bRv3GcwoRQj2u xw3pC7a+lpg5hMPHA8avogJVji/41X7X9HRo4SX4x1uiyfqaPMuv3d2waZCIpgDIpF+w V3K95mKbxEYGZfx5Ecw6ENfe9sirvSzKIkimF2eadD4X+Sm29jI+GG1ObZX/yZ0NM4QZ 39MIO3PPIhMuYjnsW7YS9aSLW3yqZBpWBKKlQ/PdSF72U36+yrHXfLI6WtXISBD3H9qg ag== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2h26vf03ca-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 31 Mar 2018 08:42:04 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w2V8g4KW018301 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 31 Mar 2018 08:42:04 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w2V8fx6Q019776; Sat, 31 Mar 2018 08:41:59 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 31 Mar 2018 01:41:59 -0700 Date: Sat, 31 Mar 2018 11:41:50 +0300 From: Dan Carpenter To: Joe Perches Cc: Quytelda Kahja , gregkh@linuxfoundation.org, wsa@the-dreams.de, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to calculate array sizes. Message-ID: <20180331084150.e6uottdsdagtywbp@mwanda> References: <20180331060855.9452-1-quytelda@tamalin.org> <1522478173.2210.53.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522478173.2210.53.camel@perches.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8848 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=753 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803310085 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote: > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote: > > This macro, provided in 'linux/kernel.h', will calculate the size > > more succinctly than a division operation. > > It's nice that you send patches, but please try to send a > cover letter with your patch series. > There are obviously times when a cover letter is required but what's the point of that for this particular series? What do you want the cover letter to say here that isn't obvious to everyone just from glancing at their inbox? > Also, 75 patches is quite a lot for a staging patch series. > > Please try to send fewer patches in your series, say a > maximum of 20 or so and see what happens to those patches > before sending the next set. Do we really care about that for staging? I can review the first 67 patches basically automatically so they take me about 5 seconds each. I feel like splitting it up risks introducing more conflicts so it actually makes the process harder/worse. regards, dan carpenter