Received: by 10.213.65.68 with SMTP id h4csp508324imn; Sat, 31 Mar 2018 03:24:16 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+nZVsR5zOvWihs4cVzVdVrO+4io6DEDx1HjK4Fv7hlPxWFfvyq6R6f4GgrvnTXS7oss/eA X-Received: by 10.99.120.138 with SMTP id t132mr1592832pgc.280.1522491856536; Sat, 31 Mar 2018 03:24:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522491856; cv=none; d=google.com; s=arc-20160816; b=kybiw7fDewtm0QiavkciiBgSFCSGMo1uK67nQcibFaWeE0QsPTlKsjZr6q+jbPyvHJ nZnaOMTTxo8IysLz7YQquhpixdQfcliScniAThQLnHva54vducaiYLBTZtaXYAiEaq9i u5vIAb6JNFboGQ3u3iZzriKJWebjasyiqANKi/kwvZi4tyL2Jj1/sIey0K/VfBhCTnak BKPfqvUpO2FDUfY/muZq019r4m9HNJ0MNfvwEVg+35TJaboStVZ/k8prDNA8yuFXGMzT UimVdhBERdHjmycaTW2leZjuXSrj2Z95xEvTB/ckx39BATWrDkvKwRzBCnNUYjZ1ggMv 3L1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date:arc-authentication-results; bh=VK9JNyqLGvxcZqGahoXlB0Nhrxv/ixy2HH+OQMBiA7I=; b=jNp3VgHtqGbSqdcQvh6fJVhGNBLhX9zhaNZCnifqY0+rVrsBNP3ADl3ip1c9Cb0z2y zjQOrvtWrlt0Bmc6ed4fQliFGNz3/MZlgoSMtwuVoGv8LdqkPeMkWOizPygfCI4JKqiC Ldb8LGmAnDNIXxQeM7Bb46dJbdvaONQkf6iyyIj2oeD93qOyKXTbzajTy7GL3k0PzSQH B7nQvFQTZa221xe1dWe9EY2gTBtFs/8mN1jr+6Fgzuz+OS+E1Fqf4jdoCqeRxVDcqDBX tDvmDt+XartdxINZxsPOBqS3VbglFpxyp8giUt46eDbAEnMUaONPR6LPrn/W9FLi2NGk M8IA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id az3-v6si2212123plb.422.2018.03.31.03.24.02; Sat, 31 Mar 2018 03:24:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbeCaKUc (ORCPT + 99 others); Sat, 31 Mar 2018 06:20:32 -0400 Received: from terminus.zytor.com ([198.137.202.136]:55519 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbeCaKUa (ORCPT ); Sat, 31 Mar 2018 06:20:30 -0400 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTP id w2VAK7AZ2262103; Sat, 31 Mar 2018 03:20:07 -0700 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id w2VAK7r22262100; Sat, 31 Mar 2018 03:20:07 -0700 Date: Sat, 31 Mar 2018 03:20:07 -0700 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Andy Shevchenko Message-ID: Cc: sohil.mehta@intel.com, lkp@intel.com, hpa@zytor.com, tglx@linutronix.de, mitake@dcl.info.waseda.ac.jp, peterz@infradead.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, andriy.shevchenko@linux.intel.com Reply-To: torvalds@linux-foundation.org, mitake@dcl.info.waseda.ac.jp, peterz@infradead.org, lkp@intel.com, tglx@linutronix.de, hpa@zytor.com, sohil.mehta@intel.com, andriy.shevchenko@linux.intel.com, mingo@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20180119143322.16555-1-andriy.shevchenko@linux.intel.com> References: <20180119143322.16555-1-andriy.shevchenko@linux.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:x86/platform] x86/io: Define readq()/writeq() to use 64-bit type Git-Commit-ID: 3d94548927a96f35da57984e3410f8b53757435a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 3d94548927a96f35da57984e3410f8b53757435a Gitweb: https://git.kernel.org/tip/3d94548927a96f35da57984e3410f8b53757435a Author: Andy Shevchenko AuthorDate: Fri, 19 Jan 2018 16:33:22 +0200 Committer: Ingo Molnar CommitDate: Sat, 31 Mar 2018 11:41:43 +0200 x86/io: Define readq()/writeq() to use 64-bit type Since non atomic readq() and writeq() were added some of the drivers would like to use it in a manner of: #include ... pr_debug("Debug value of some register: %016llx\n", readq(addr)); However, lo_hi_readq() always returns __u64 data, while readq() on x86_64 defines it as unsigned long. and thus compiler warns about type mismatch, although they are both 64-bit on x86_64. Convert readq() and writeq() on x86 to operate on deterministic 64-bit type. The most of architectures in the kernel already are using either unsigned long long, or u64 type for readq() / writeq(). This change propagates consistency in that sense. While this is not an issue per se, though if someone wants to address it, the anchor could be the commit 797a796a13df ("asm-generic: architecture independent readq/writeq for 32bit environment") where non-atomic variants had been introduced. Note, there are only few users of above pattern and they will not be affected because they do cast returned value. The actual warning has been issued on not-yet-upstreamed code. Potentially we might get a new warnings if some 64-bit only code assigns returned value to unsigned long type of variable. This is assumed to be addressed on case-by-case basis. Reported-by: lkp Tested-by: Sohil Mehta Signed-off-by: Andy Shevchenko Cc: Hitoshi Mitake Cc: Linus Torvalds Cc: Mehta, Sohil Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20180119143322.16555-1-andriy.shevchenko@linux.intel.com Signed-off-by: Ingo Molnar --- arch/x86/include/asm/io.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h index 95e948627fd0..365f5ba9222b 100644 --- a/arch/x86/include/asm/io.h +++ b/arch/x86/include/asm/io.h @@ -94,10 +94,10 @@ build_mmio_write(__writel, "l", unsigned int, "r", ) #ifdef CONFIG_X86_64 -build_mmio_read(readq, "q", unsigned long, "=r", :"memory") -build_mmio_read(__readq, "q", unsigned long, "=r", ) -build_mmio_write(writeq, "q", unsigned long, "r", :"memory") -build_mmio_write(__writeq, "q", unsigned long, "r", ) +build_mmio_read(readq, "q", unsigned long long, "=r", :"memory") +build_mmio_read(__readq, "q", unsigned long long, "=r", ) +build_mmio_write(writeq, "q", unsigned long long, "r", :"memory") +build_mmio_write(__writeq, "q", unsigned long long, "r", ) #define readq_relaxed(a) __readq(a) #define writeq_relaxed(v, a) __writeq(v, a)