Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1522505573.11653.1.camel@perches.com>
Subject: Re: [PATCH v2 01/75] staging: ks7010: Use the ARRAY_SIZE() macro to
 calculate array sizes.
From:   Joe Perches <joe@perches.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Quytelda Kahja <quytelda@tamalin.org>, gregkh@linuxfoundation.org,
        wsa@the-dreams.de, devel@driverdev.osuosl.org,
        driverdev-devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org
Date:   Sat, 31 Mar 2018 07:12:53 -0700
In-Reply-To: <20180331084150.e6uottdsdagtywbp@mwanda>
References: <CAFLvi23=E6QubTGX0=cHjbJGB=Vx5OJ7d16E2R4HZTscmJuuSw@mail.gmail.com>
         <20180331060855.9452-1-quytelda@tamalin.org>
         <1522478173.2210.53.camel@perches.com>
         <20180331084150.e6uottdsdagtywbp@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2018-03-31 at 11:41 +0300, Dan Carpenter wrote:
> On Fri, Mar 30, 2018 at 11:36:13PM -0700, Joe Perches wrote:
> > On Fri, 2018-03-30 at 23:07 -0700, Quytelda Kahja wrote:
> > > This macro, provided in 'linux/kernel.h', will calculate the size
> > > more succinctly than a division operation.
> > 
> > It's nice that you send patches, but please try to send a
> > cover letter with your patch series.
> > 
> 
> There are obviously times when a cover letter is required but what's the
> point of that for this particular series?

practice

> > Also, 75 patches is quite a lot for a staging patch series.
> > 
> > Please try to send fewer patches in your series, say a
> > maximum of 20 or so and see what happens to those patches
> > before sending the next set.
> 
> Do we really care about that for staging?

It seems like it matters most for staging as the submitters
are the least experienced nd most likely to get something
wrong.

Start small and build.