Received: by 10.213.65.68 with SMTP id h4csp1079322imn; Sat, 31 Mar 2018 18:44:26 -0700 (PDT) X-Google-Smtp-Source: AIpwx49ubYAr6AInl/+k22IXyiiN1e0Xje1YcZC8SnW9T/Dkmp9lwVKWX8+cZaLuUwJ8q5zi28T1 X-Received: by 10.98.223.149 with SMTP id d21mr3455635pfl.160.1522547066247; Sat, 31 Mar 2018 18:44:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522547066; cv=none; d=google.com; s=arc-20160816; b=nd846N1QImVyUVHAT1XFTlUZQ66Sysrw71s18nVxQeBmOxMcQpG8TcUmpxHORusmiW H+5NHuIgw8pQIWeFPParQzFX9vnyiDbVEBldEITBNZnphnqrvFnu4DwD9BgxjjlnjW4f 0j7bXV/sSZdG+0E8OHdUmv8miPycREVKTJcQEHZQhT+ABa3gmcCfXKpTDQI47rAK42SN KRjFIvEBtzT01nq72YxozD9dI+BqIrwBRa98XZOGwyLZWfeGftvnR9OUalSS7evRJI1b 20o4e+0EH+kfh83s6UrM1VZ9tZ+5NIsk8Msd3Xit/DGSy1B5jNXoZ8jyiatFL0dB1vqD 2B+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:from:references:in-reply-to :message-id:cc:to:arc-authentication-results; bh=FBZ6qazx8SMZmn+d6Q2SI7KIBmWbDFSij4u+ZI3fJ/U=; b=xUELERM0EVY92A+CADfIJSKyvkH19AlO1RdhXXfFDHlYY86jk+ji8QuhoeI9wvkOoA Xwgc0A8eonuBHLbzbs2B7Hz9YC5qAk+cSYrJBZvt/FhgO8elvMhLqsqJPJ15af1GSzqr IAuHi6nTCyR2yvaep2+rlq44AgAp8il2eUsOxEKjcwITg7b8UjpzaGmZGeHZPVQ2C1Nn AIxCka30II9QbvmV9S+7cd5/AtpEqaXvGfgjPN8ymRr5h+eT1q7uFZ/evW1wK0ulxbI5 AL3q5VxmaeW3Ejf+ZLwwBjY45APUeCuLPCk+JbFJc17eb3tQRPorlAABfeU01egJ73xZ 33ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u187si7913261pgc.451.2018.03.31.18.44.12; Sat, 31 Mar 2018 18:44:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbeDABmL (ORCPT + 99 others); Sat, 31 Mar 2018 21:42:11 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:47384 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753073AbeDABlI (ORCPT ); Sat, 31 Mar 2018 21:41:08 -0400 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 35C4022915; Sat, 31 Mar 2018 21:41:05 -0400 (EDT) To: Geert Uytterhoeven Cc: Laurent Vivier , Jens Axboe , linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Message-Id: <455c2ccbea2f83947630e3068ecadf4ab4434fb9.1522546571.git.fthain@telegraphics.com.au> In-Reply-To: References: From: Finn Thain Subject: [PATCH 07/12] block/swim: Remove extra put_disk() call from error path Date: Sat, 31 Mar 2018 21:41:05 -0400 (EDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cc: Laurent Vivier Cc: Jens Axboe Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/block/swim.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/swim.c b/drivers/block/swim.c index 87c70fcce875..19d7d27468c7 100644 --- a/drivers/block/swim.c +++ b/drivers/block/swim.c @@ -873,7 +873,6 @@ static int swim_floppy_init(struct swim_priv *swd) &swd->lock); if (!swd->unit[drive].disk->queue) { err = -ENOMEM; - put_disk(swd->unit[drive].disk); goto exit_put_disks; } blk_queue_bounce_limit(swd->unit[drive].disk->queue, -- 2.16.1