Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180329212932.GA27107@flask>
References: <1522198134-2709-1-git-send-email-wanpengli@tencent.com>
 <1522198134-2709-3-git-send-email-wanpengli@tencent.com> <20180329212932.GA27107@flask>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Sun, 1 Apr 2018 19:12:29 +0800
Message-ID: <CANRm+CzM0ucS1=bGxTTQ3eEfBojD5mSza0NCaiDFN_GPiuig3w@mail.gmail.com>
Subject: Re: [PATCH v3 2/2] KVM: X86: Add Force Emulation Prefix for "emulate
 the next instruction"
To:     =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Andrew Cooper <andrew.cooper3@citrix.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Liran Alon <liran.alon@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2018-03-30 5:29 GMT+08:00 Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>:
> 2018-03-27 17:48-0700, Wanpeng Li:
>> From: Wanpeng Li <wanpengli@tencent.com>
>>
>> There is no easy way to force KVM to run an instruction through the emul=
ator
>> (by design as that will expose the x86 emulator as a significant attack-=
surface).
>> However, we do wish to expose the x86 emulator in case we are testing it
>> (e.g. via kvm-unit-tests). Therefore, this patch adds a "force emulation=
 prefix"
>> that is designed to raise #UD which KVM will trap and it's #UD exit-hand=
ler will
>> match "force emulation prefix" to run instruction after prefix by the x8=
6 emulator.
>> To not expose the x86 emulator by default, we add a module parameter tha=
t should
>> be off by default.
>>
>> A simple testcase here:
>>
>> #include <stdio.h>
>> #include <string.h>
>>
>> #define HYPERVISOR_INFO 0x40000000
>>
>> #define CPUID(idx, eax, ebx, ecx, edx) \
>>     asm volatile (\
>>     "ud2a; .ascii \"kvm\"; cpuid" \
>>     :"=3Db" (*ebx), "=3Da" (*eax), "=3Dc" (*ecx), "=3Dd" (*edx) \
>>         :"0"(idx) );
>>
>> void main()
>> {
>>       unsigned int eax, ebx, ecx, edx;
>>       char string[13];
>>
>>       CPUID(HYPERVISOR_INFO, &eax, &ebx, &ecx, &edx);
>>       *(unsigned int *)(string + 0) =3D ebx;
>>       *(unsigned int *)(string + 4) =3D ecx;
>>       *(unsigned int *)(string + 8) =3D edx;
>>
>>       string[12] =3D 0;
>>       if (strncmp(string, "KVMKVMKVM\0\0\0", 12) =3D=3D 0)
>>               printf("kvm guest\n");
>>       else
>>               printf("bare hardware\n");
>> }
>>
>> Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
>> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>> Cc: Liran Alon <liran.alon@oracle.com>
>> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
>> ---
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> @@ -146,6 +146,9 @@ bool __read_mostly enable_vmware_backdoor =3D false;
>>  module_param(enable_vmware_backdoor, bool, S_IRUGO);
>>  EXPORT_SYMBOL_GPL(enable_vmware_backdoor);
>>
>> +static bool __read_mostly force_emulation_prefix =3D false;
>> +module_param(force_emulation_prefix, bool, S_IRUGO);
>> +
>>  #define KVM_NR_SHARED_MSRS 16
>>
>>  struct kvm_shared_msrs_global {
>> @@ -4843,8 +4846,21 @@ EXPORT_SYMBOL_GPL(kvm_write_guest_virt_system);
>>  int handle_ud(struct kvm_vcpu *vcpu)
>>  {
>>       enum emulation_result er;
>> +     int emulation_type =3D EMULTYPE_TRAP_UD;
>> +
>> +     if (force_emulation_prefix) {
>> +             char sig[5]; /* ud2; .ascii "kvm" */
>> +             struct x86_exception e;
>> +
>> +             kvm_read_guest_virt(&vcpu->arch.emulate_ctxt,
>> +                             kvm_get_linear_rip(vcpu), sig, sizeof(sig)=
, &e);
>> +             if (memcmp(sig, "\xf\xbkvm", sizeof(sig)) =3D=3D 0) {
>> +                     emulation_type =3D 0;
>> +                     kvm_rip_write(vcpu, kvm_rip_read(vcpu) + sizeof(si=
g));
>> +             }
>> +     }
>>
>> -     er =3D emulate_instruction(vcpu, EMULTYPE_TRAP_UD);
>> +     er =3D emulate_instruction(vcpu, emulation_type);
>>       if (er =3D=3D EMULATE_USER_EXIT)
>>               return 0;
>>       if (er !=3D EMULATE_DONE)
>
> The code afterwards is going to inject an #UD if the emulation failed.
> I think that preserving the cpu state and forwarding the emulation
> failure to userspace would be more useful.  The change would probably be
> best as:
>
>                 if (memcmp(sig, "\xf\xbkvm", sizeof(sig)) =3D=3D 0) {
>                         kvm_rip_write(vcpu, kvm_rip_read(vcpu) + sizeof(s=
ig));
>                         return emulate_instruction(vcpu, 0) =3D=3D EMULAT=
E_DONE;
>                 }
>
> Looks great otherwise, thanks.

Do it in v4. :)

Regards,
Wanpeng Li