Received: by 10.213.65.68 with SMTP id h4csp1631187imn; Sun, 1 Apr 2018 10:34:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx48+YPFHLlHobzC/SNXK5X5YKCQro9+McC1SXgkQwPUjz/MXOBXLCEReMU/XV6+YJzi/PQTC X-Received: by 2002:a17:902:8348:: with SMTP id z8-v6mr6768532pln.311.1522604044236; Sun, 01 Apr 2018 10:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522604044; cv=none; d=google.com; s=arc-20160816; b=ne8xivSolFAO6NVgAWPxKX+R+NTUXIqwau3GihNz/t45w59b4FLNSbGzXXzrcLMKQX JK/zZGVEQmb4KeSApG2Nue9v+5suX5hiTJ+obZXWDnAkE9amUw0ZDuXuYxrT3GVyoMLE 2lLp0/Y7l7L1UYun7E/PRwSvIDTgLHx3uL98UT0xY4RqixMj+hv/qBNTLusoIfOUuxHL 3lYZD0TNj/SAXGIiSQ2TVPIsQ201FFeiz14Vl+7Bk8jlx4eGCs7xbYy40QPaSgP2ZBo+ yerdoUMlhUwt3gwySKnoVdISSHg15VZ8ERXJUSTWDpQ6tccVzIuPv4AvQllU65/5SIB1 onQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=Nh/1GkDna8YhtYhT7yKel60TPCvwEYGQmbhth3HJ8yI=; b=xcKztY4fDsNJS+a0ETT1MFsrsIrRZLaQv5e7u8bQB+Vjy2+SXx8hBpzDAQOL+dSKQb trG92HYF1aqzUfUXKhJcQGxGpuVGW/s6Fd0htYtHx2cUOJ4UVLo9S+pX5ROGzzgXwyak dPRqfxUJkVOIyBZPLxwILIIsK3RhkLOE8z6LyGAUKW5CzcacEeyW+6Nlr+BAHdJiswM5 KYnk6ODudh0mppUkA5cupk1B1ypW17uyiniYpkTSEnWDGVavy5HNdf2HtZpkKTreDnEx LPD//254EPwJWUmMTzJIW2rkIzjqqcX9t/tNOpGWz6YzA7+cVIaagyhmjJatTpDMldgN UvMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yahoo.com header.s=s2048 header.b=S3J6f3wh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a33-v6si12888543pla.618.2018.04.01.10.33.50; Sun, 01 Apr 2018 10:34:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@yahoo.com header.s=s2048 header.b=S3J6f3wh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816AbeDARco (ORCPT + 99 others); Sun, 1 Apr 2018 13:32:44 -0400 Received: from sonic313-26.consmr.mail.gq1.yahoo.com ([98.137.65.89]:39915 "EHLO sonic313-26.consmr.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720AbeDARcm (ORCPT ); Sun, 1 Apr 2018 13:32:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1522603962; bh=Nh/1GkDna8YhtYhT7yKel60TPCvwEYGQmbhth3HJ8yI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=S3J6f3wh/nc7MpVLf/FjPsIHBq3ywo8/hqo3HCu2ECGD7HSgqP2KQCzQSACQKh8c+jkFBPDp21PB1e3ak0mZqwKhL+dRe8qfdPs8yBGf45oVMcT3eCcqClnRa0fmUUJ5RTZuSfyeu9hwkYRdZujCcoedln5b5hqKOihh1F19/QJyucOEw2r1JLD6hYKJI0VBikOvNQsEGwoiRsuvErrWYXdhDw1ADBbCeeENFWJhAJT0sdwU31RNCJTwpxdwpVgGhdMbEHUSHlKCEEpRbOykEj6iQ1t/ipJpH+VT6AFEtsYOGaKB1jZdrGLfgCFKGnboXaBX0KMVK9GSY3JrLfnYyA== X-YMail-OSG: 9vOvwUEVM1kapPbBmDS6XMki5q8zsCB.mu48keGH4_OfPXaUIMDQWbTCmALmkKu wGLWfBlD4hXNxuSsGDvNzJHv0fmR4UI0_InfJ2BYsXRimX3Z62mZZDKX9p2f3qynkwIcIfnpPop3 Mt9VHHkKFh2CY9dU0DEGDNwqAWD0wobt5BhjheSjfCMYRHvgkumPczj0AhIpfVNMtseAxBPLfUFr am8J0_lYr4_tmjuUOuiBVDAUizjdAHY6UgiCHJ0WGvTp3ndLb33Xtq0Dd__GSBGF3OURp73uhBOO jFZombdFK0a5xKTsHXWSArmqhWYgDcA7efXGDFJRLmEOnJgtM1m38ajdMywPBcuw2oWVPiSERpVu CfEUe6_0orI7l9hyA3lJp6NPnExE2qhrEWe3_xUkb5Rm66JQN.s5auZtvHI8BxoYOUw9rf8kC1.E RdBm0r47IBqeiqyGzJqq7G01vgm2YdkFuH10DiJqTAol3XUp8M1nH_ngJRaAXy3KvM7R__nqCh0Z 0JSN8Qzg58HoDsKYKIGPO3eQetLq21g-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Sun, 1 Apr 2018 17:32:42 +0000 Received: from c-67-169-65-224.hsd1.ca.comcast.net (EHLO [192.168.0.104]) ([67.169.65.224]) by smtp421.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID cca1fff0ff03396adce5d925ee37ca2f; Sun, 01 Apr 2018 17:32:39 +0000 (UTC) Subject: Re: [PATCH 0/4] security: Split out hook definitions into lsm_hook_types.h To: Sargun Dhillon , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Cc: penguin-kernel@i-love.sakura.ne.jp, keescook@chromium.org, igor.stoppa@huawei.com, jmorris@namei.org References: From: Casey Schaufler Message-ID: <06c4e61e-399f-a1f8-bd45-a27d0eb4571b@schaufler-ca.com> Date: Sun, 1 Apr 2018 10:32:32 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/2018 3:17 AM, Sargun Dhillon wrote: > This moves all of the LSM hooks type information into a separate file, > lsm_hook_types.h. This enables us to use this file, along with macros > to generate the security_hook_heads struct, as well as the security > hooks union without having to duplicate definitions. > > This will be useful for further datastructures which want to use > the set of security hooks in a completely unrolled way, along > with the type information there within. Can you explain what this patch set is trying to accomplish? I see no value. I see massive complexity. Why is this better than what is there now?