Received: by 10.213.65.68 with SMTP id h4csp1745027imn; Sun, 1 Apr 2018 13:51:09 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+ED4VTanqW3rxkUKl7YDlbZSZGRbsaozgG+hSUjLcBqS8kuPQNuBr7yeLmaZUtNVp1sZPO X-Received: by 10.101.74.82 with SMTP id a18mr4663513pgu.312.1522615869700; Sun, 01 Apr 2018 13:51:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522615869; cv=none; d=google.com; s=arc-20160816; b=yqH3WksSVvTdkJAtuUmGEhy/Wrso7pXhgZ0NLMLfetCDPUJHCT7XNjbfb62vxgQzGt h6PhTlxNZihxbUhwy+Bn0CzIBwDRcGTMW6+c6evXUZpQQAI/cCpoy9KFB08E3XG9hl7P NNM7upMx9kAgT/UuOl4wQHflcqrEfWXnpbB0r3HVDdZLtcmUOvRgIX7bJweU60sXGcqa FfEFJVTUZee2FXrhCNyVZ+/cnlTDxtXvNQZOV09j176w0thbF7R6EGUzoLfRIAB0LBZo cDbidkezQwX7N93OdDz8vdgBCiw5/5ZdAQGXCO6GQ5Xjh8yghILEnIq0Fzugevrg1h+H mWmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:to:from:subject :organization:arc-authentication-results; bh=v5SYoh5ME8WmV3uZX0zGHeUWHgBTAyGuncvun5Trqwg=; b=HZT5LPchsx9rS7NCAUs0nBTRYkck0tf/6TIiErjH9DX0MbAWa0B+brYsMG2eax928t SHd44Rav5jA98iZCvEaqcrRP5Z3xPh2cItx3kOMEBR5SYd4WAUvlHreoWcLUvO1ylLjz sCG4cH+SSNqS9t1iruDShoN6Xc4HsneGZK9U4JqPLN+Lnu0L1PybZY2e6UkZ5Aydxmxj jSTDKsl3j01zF4QHkBJezkWgLy7BpRMIkmvsRbGhKmLhW7wTOJGemdpe68GOma9zT/d/ k8Caibca4fSliZqZkCibVSEX0q1rj/MlI/fly4VT27o3ywJC0Y5BquWwel5WVrrqmusb NzDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h80si9911385pfd.260.2018.04.01.13.50.56; Sun, 01 Apr 2018 13:51:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754283AbeDAUlz (ORCPT + 99 others); Sun, 1 Apr 2018 16:41:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:50632 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754268AbeDAUlx (ORCPT ); Sun, 1 Apr 2018 16:41:53 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A9725BD9F for ; Sun, 1 Apr 2018 20:41:52 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-59.rdu2.redhat.com [10.10.120.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59173D7E08; Sun, 1 Apr 2018 20:41:52 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 Subject: [PATCH 16/45] C++: Disable VERIFY_OCTAL_PERMISSIONS() for the moment From: David Howells To: linux-kernel@vger.kernel.org Date: Sun, 01 Apr 2018 21:41:51 +0100 Message-ID: <152261531188.30503.1879167170677309447.stgit@warthog.procyon.org.uk> In-Reply-To: <152261521484.30503.16131389653845029164.stgit@warthog.procyon.org.uk> References: <152261521484.30503.16131389653845029164.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Sun, 01 Apr 2018 20:41:52 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Sun, 01 Apr 2018 20:41:52 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Disable VERIFY_OCTAL_PERMISSIONS() for the moment as it's unclear as to why g++ doesn't like it. Signed-off-by: David Howells --- include/linux/kernel.h | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 59089f76c7d8..06b7e3a79c7a 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -931,15 +931,6 @@ static inline void ftrace_dump(enum ftrace_dump_mode oops_dump_mode) { } #endif /* Permissions on a sysfs file: you didn't miss the 0 prefix did you? */ -#define VERIFY_OCTAL_PERMISSIONS(perms) \ - (BUILD_BUG_ON_ZERO((perms) < 0) + \ - BUILD_BUG_ON_ZERO((perms) > 0777) + \ - /* USER_READABLE >= GROUP_READABLE >= OTHER_READABLE */ \ - BUILD_BUG_ON_ZERO((((perms) >> 6) & 4) < (((perms) >> 3) & 4)) + \ - BUILD_BUG_ON_ZERO((((perms) >> 3) & 4) < ((perms) & 4)) + \ - /* USER_WRITABLE >= GROUP_WRITABLE */ \ - BUILD_BUG_ON_ZERO((((perms) >> 6) & 2) < (((perms) >> 3) & 2)) + \ - /* OTHER_WRITABLE? Generally considered a bad idea. */ \ - BUILD_BUG_ON_ZERO((perms) & 2) + \ - (perms)) +#define VERIFY_OCTAL_PERMISSIONS(perms) \ + (perms) #endif