Received: by 10.213.65.68 with SMTP id h4csp2184704imn; Mon, 2 Apr 2018 02:48:14 -0700 (PDT) X-Google-Smtp-Source: AIpwx49rW+PijEH5+x1pgZNvTvkbYSkjTO7WO6SmpCPKBrCfdsusO/XPe9qVJwOI4mQlR4POpCN1 X-Received: by 2002:a17:902:a24:: with SMTP id 33-v6mr9301797plo.72.1522662494106; Mon, 02 Apr 2018 02:48:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522662494; cv=none; d=google.com; s=arc-20160816; b=cmUoWtgtP+jQq03snmDZDHV/GazR+PZIAAktONj+kS/XMZTu/oMW94XnrEgQbA3NH5 ionZMm2Oj+n2EryKnv1raNT3VJNa+1d81PUZrZ6GGIhaQdWiiX++7EWgB4wkgZPj+j5y /wduJ9haJKm/4VLbuBsVbZ3SEFdOJn+BUC3sju2FBu7pw8rRPI9rhN6DNF0lcqH2xCMq C6hp6992qGMP4WfVJ6xIywVBjGI31n5DRej63TWOA2+vzlx3bu7P4ylPC4uEbssOf8kn IzTWGoJGBNB2vuhSScGfV1DbZnJChF2iTrbQH93fz2yfxJZdroaMQOHvRTMhZ7V9XEUL U2QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=jrNPNZImdT0WFBDiFo3d8DqZprnOQHIzzTz9muG/dNg=; b=Ojj4vtlQxcrKeuwTLaLp824xFMQbFU+oHPaLObWni2+9DPwhyaUHsgx+c0yKW7mBQ5 wzTanqgFrjqzfD/euEqebDlUILGupPBV2JM6Qf/DgY0nlcGj6QiX4FwuO1aaD9kvah5Z rQ7ToZcTjMhYXRcVMm5fhS/rBDvePNobpdk/tojXOe4hMI+QrLQBFw7d9maX7lTSzRxK y2litJroNCH6vA+7Wd6ig9CzmZvQkNUWjsnBawsalzIo9jQT3XgaDXjnCB1rTsFr72Hm DdORaTEy2L0UJsRO+kXGi+Z+CA1qxzCsvtJtntSUysxApSDi7WnTAX/xgXL52wfYG2WE 50Tw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p24si9570696pgn.797.2018.04.02.02.47.58; Mon, 02 Apr 2018 02:48:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754265AbeDBJqp (ORCPT + 99 others); Mon, 2 Apr 2018 05:46:45 -0400 Received: from mga18.intel.com ([134.134.136.126]:36486 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbeDBJqn (ORCPT ); Mon, 2 Apr 2018 05:46:43 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2018 02:46:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,395,1517904000"; d="scan'208";a="47246896" Received: from bee.sh.intel.com (HELO bee) ([10.239.97.14]) by orsmga002.jf.intel.com with ESMTP; 02 Apr 2018 02:46:41 -0700 Received: from kbuild by bee with local (Exim 4.84_2) (envelope-from ) id 1f2w2y-000DM9-G8; Mon, 02 Apr 2018 17:46:40 +0800 Date: Mon, 2 Apr 2018 17:45:48 +0800 From: kbuild test robot To: rao.shoaib@oracle.com Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, joe@perches.com, willy@infradead.org, brouer@redhat.com, linux-mm@kvack.org, Rao Shoaib Subject: Re: [PATCH 1/2] Move kfree_call_rcu() to slab_common.c Message-ID: <201804021616.HByAT8F9%fengguang.wu@intel.com> References: <1522647064-27167-2-git-send-email-rao.shoaib@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522647064-27167-2-git-send-email-rao.shoaib@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on rcu/rcu/next] [also build test WARNING on v4.16 next-20180329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/rao-shoaib-oracle-com/Move-kfree_rcu-out-of-rcu-code-and-use-kfree_bulk/20180402-135939 base: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) include/linux/init.h:134:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:135:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:268:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/init.h:269:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/printk.h:200:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:32:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:34:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:37:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:38:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:40:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:42:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:43:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:45:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:46:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/mem_encrypt.h:49:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/qspinlock.h:53:32: sparse: attribute 'indirect_branch': unknown attribute include/linux/workqueue.h:646:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/workqueue.h:647:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/wait_bit.h:41:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:34:12: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:35:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/numa.h:62:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:64:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:173:8: sparse: attribute 'indirect_branch': unknown attribute include/linux/vmalloc.h:174:8: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:174:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:176:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:178:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/fixmap.h:180:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/apic.h:254:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/apic.h:430:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/io_apic.h:184:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:113:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:125:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/smp.h:126:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:110:33: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:112:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:114:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:118:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/percpu.h:126:12: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:63:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:64:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:65:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:66:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/memory_hotplug.h:221:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/mmzone.h:1292:15: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:2421:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:2422:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/fs.h:3329:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/hrtimer.h:497:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/kmemleak.h:29:33: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/kasan.h:29:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/kasan.h:30:6: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/pgtable.h:28:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/slab.h:135:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/slab.h:758:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/mm.h:1753:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/mm.h:1941:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/mm.h:2083:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/mm.h:2671:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/swiotlb.h:39:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/swiotlb.h:124:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/swiotlb.h:9:12: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/swiotlb.h:10:12: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/swiotlb.h:11:13: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/swiotlb.h:12:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/dma-contiguous.h:85:5: sparse: attribute 'indirect_branch': unknown attribute arch/x86/include/asm/vdso.h:44:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/cred.h:167:13: sparse: attribute 'indirect_branch': unknown attribute include/linux/nsproxy.h:74:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/io.h:47:6: sparse: attribute 'indirect_branch': unknown attribute include/linux/netdevice.h:302:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/netdevice.h:4056:5: sparse: attribute 'indirect_branch': unknown attribute include/linux/ftrace.h:462:6: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:59:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:95:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:120:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:150:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:191:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:231:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:285:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/bpf.h:315:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/xdp.h:28:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/xdp.h:53:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/xdp.h:155:1: sparse: attribute 'indirect_branch': unknown attribute include/trace/events/xdp.h:190:1: sparse: attribute 'indirect_branch': unknown attribute kernel/bpf/core.c:1546:31: sparse: incorrect type in return expression (different address spaces) @@ expected struct bpf_prog_array [noderef] * @@ got sn:4>* @@ kernel/bpf/core.c:1546:31: expected struct bpf_prog_array [noderef] * kernel/bpf/core.c:1546:31: got void * kernel/bpf/core.c:1550:17: sparse: incorrect type in return expression (different address spaces) @@ expected struct bpf_prog_array [noderef] * @@ got rray [noderef] * @@ kernel/bpf/core.c:1550:17: expected struct bpf_prog_array [noderef] * kernel/bpf/core.c:1550:17: got struct bpf_prog_array * >> kernel/bpf/core.c:1558:9: sparse: cast removes address space of expression kernel/bpf/core.c:1621:34: sparse: incorrect type in initializer (different address spaces) @@ expected struct bpf_prog **prog @@ got struct bpf_prog *struct bpf_prog **prog @@ kernel/bpf/core.c:1621:34: expected struct bpf_prog **prog kernel/bpf/core.c:1621:34: got struct bpf_prog *[noderef] * kernel/bpf/core.c:1644:31: sparse: incorrect type in assignment (different address spaces) @@ expected struct bpf_prog **existing_prog @@ got struct bpf_prog *struct bpf_prog **existing_prog @@ kernel/bpf/core.c:1644:31: expected struct bpf_prog **existing_prog kernel/bpf/core.c:1644:31: got struct bpf_prog *[noderef] * kernel/bpf/core.c:1666:15: sparse: incorrect type in assignment (different address spaces) @@ expected struct bpf_prog_array *array @@ got struct bpf_prog_astruct bpf_prog_array *array @@ kernel/bpf/core.c:1666:15: expected struct bpf_prog_array *array kernel/bpf/core.c:1666:15: got struct bpf_prog_array [noderef] * kernel/bpf/core.c:1672:31: sparse: incorrect type in assignment (different address spaces) @@ expected struct bpf_prog **[assigned] existing_prog @@ got structstruct bpf_prog **[assigned] existing_prog @@ kernel/bpf/core.c:1672:31: expected struct bpf_prog **[assigned] existing_prog kernel/bpf/core.c:1672:31: got struct bpf_prog *[noderef] * include/trace/events/bpf.h:59:1: sparse: Using plain integer as NULL pointer include/trace/events/bpf.h:95:1: sparse: Using plain integer as NULL pointer include/trace/events/bpf.h:120:1: sparse: Using plain integer as NULL pointer include/trace/events/bpf.h:191:1: sparse: Using plain integer as NULL pointer include/trace/events/bpf.h:231:1: sparse: Using plain integer as NULL pointer include/trace/events/bpf.h:285:1: sparse: Using plain integer as NULL pointer include/trace/events/bpf.h:315:1: sparse: too many warnings vim +1558 kernel/bpf/core.c 324bda9e6c Alexei Starovoitov 2017-10-02 1542 324bda9e6c Alexei Starovoitov 2017-10-02 1543 struct bpf_prog_array __rcu *bpf_prog_array_alloc(u32 prog_cnt, gfp_t flags) 324bda9e6c Alexei Starovoitov 2017-10-02 1544 { 324bda9e6c Alexei Starovoitov 2017-10-02 1545 if (prog_cnt) 324bda9e6c Alexei Starovoitov 2017-10-02 @1546 return kzalloc(sizeof(struct bpf_prog_array) + 324bda9e6c Alexei Starovoitov 2017-10-02 1547 sizeof(struct bpf_prog *) * (prog_cnt + 1), 324bda9e6c Alexei Starovoitov 2017-10-02 1548 flags); 324bda9e6c Alexei Starovoitov 2017-10-02 1549 324bda9e6c Alexei Starovoitov 2017-10-02 1550 return &empty_prog_array.hdr; 324bda9e6c Alexei Starovoitov 2017-10-02 1551 } 324bda9e6c Alexei Starovoitov 2017-10-02 1552 324bda9e6c Alexei Starovoitov 2017-10-02 1553 void bpf_prog_array_free(struct bpf_prog_array __rcu *progs) 324bda9e6c Alexei Starovoitov 2017-10-02 1554 { 324bda9e6c Alexei Starovoitov 2017-10-02 1555 if (!progs || 324bda9e6c Alexei Starovoitov 2017-10-02 1556 progs == (struct bpf_prog_array __rcu *)&empty_prog_array.hdr) 324bda9e6c Alexei Starovoitov 2017-10-02 1557 return; 324bda9e6c Alexei Starovoitov 2017-10-02 @1558 kfree_rcu(progs, rcu); 324bda9e6c Alexei Starovoitov 2017-10-02 1559 } 324bda9e6c Alexei Starovoitov 2017-10-02 1560 :::::: The code at line 1558 was first introduced by commit :::::: 324bda9e6c5add86ba2e1066476481c48132aca0 bpf: multi program support for cgroup+bpf :::::: TO: Alexei Starovoitov :::::: CC: David S. Miller --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation