Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stuyoder@gmail.com" <stuyoder@gmail.com>,
        Ruxandra Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        Razvan Stefanescu <razvan.stefanescu@nxp.com>,
        Roy Pledge <roy.pledge@nxp.com>
Subject: RE: [PATCH v3 4/4] bus: fsl-mc: add bus rescan attribute
Thread-Topic: [PATCH v3 4/4] bus: fsl-mc: add bus rescan attribute
Thread-Index: AQHTwr0wQpewYSPXPk2gS/MBZ86FQqPd97CAgA+QFuA=
Date:   Mon, 2 Apr 2018 13:46:13 +0000
Message-ID: <HE1PR04MB3212736F979C78C2269D9D6BE0A60@HE1PR04MB3212.eurprd04.prod.outlook.com>
References: <cover.1521818402.git.ioana.ciornei@nxp.com>
 <2ea1db0e7d43255f8d13f6c3cb4ce3d12df89eef.1521818403.git.ioana.ciornei@nxp.com>
 <20180323154953.GC382@kroah.com>
In-Reply-To: <20180323154953.GC382@kroah.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5a5ce4cd-7c19-4e8b-d2d5-08d598a01abe
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2018 13:46:13.9008
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3050
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > Introduce the rescan attribute as a bus attribute to synchronize the
> > fsl-mc bus objects and the MC firmware.
> >
> > To rescan the fsl-mc bus, e.g.,
> > echo 1 > /sys/bus/fsl-mc/rescan
> >
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> > ---
> > Changes in v2:
> >   - added proper documentation in /Documentation/ABI/
> >   - updated the MAINTAINERS file
> > Changes in v3:
> >   - no change
> >
> >  Documentation/ABI/stable/sysfs-bus-fsl-mc |  7 +++++
> >  drivers/bus/fsl-mc/fsl-mc-bus.c           | 48
> +++++++++++++++++++++++++++++++
> >  2 files changed, 55 insertions(+)
> >
> > diff --git a/Documentation/ABI/stable/sysfs-bus-fsl-mc
> > b/Documentation/ABI/stable/sysfs-bus-fsl-mc
> > index e530e8c..0663fbd 100644
> > --- a/Documentation/ABI/stable/sysfs-bus-fsl-mc
> > +++ b/Documentation/ABI/stable/sysfs-bus-fsl-mc
> > @@ -4,3 +4,10 @@ KernelVersion:	4.16
> >  Contact:	Ioana Ciornei <ioana.ciornei@nxp.com>
> >  Description:	Root dprc rescan attribute
> >  Users:		Userspace drivers and management tools
> > +
> > +What:		/sys/bus/fsl-mc/rescan
> > +Date:		March. 2018
> > +KernelVersion:	4.16
>=20
> Same comments as previous review.
>=20
> > +Contact:	Ioana Ciornei <ioana.ciornei@nxp.com>
> > +Description:	Bus rescan attribute
>=20
> Again, describe this better please.
>=20
> > +Users:		Userspace drivers and management tools
> > diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c
> > b/drivers/bus/fsl-mc/fsl-mc-bus.c index 9d02984..80010d1 100644
> > --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> > +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> > @@ -172,11 +172,59 @@ static ssize_t rescan_store(struct device *dev,
> >
> >  ATTRIBUTE_GROUPS(fsl_mc_dev);
> >
> > +static int scan_fsl_mc_bus(struct device *dev, void *data) {
> > +	struct fsl_mc_device *root_mc_dev;
> > +	struct fsl_mc_bus *root_mc_bus;
> > +
> > +	if (!fsl_mc_is_root_dprc(dev))
> > +		goto exit;
> > +
> > +	root_mc_dev =3D to_fsl_mc_device(dev);
> > +	root_mc_bus =3D to_fsl_mc_bus(root_mc_dev);
> > +	mutex_lock(&root_mc_bus->scan_mutex);
> > +	dprc_scan_objects(root_mc_dev, NULL);
> > +	mutex_unlock(&root_mc_bus->scan_mutex);
> > +
> > +exit:
> > +	return 0;
> > +}
> > +
> > +static ssize_t bus_rescan_store(struct bus_type *bus,
> > +				const char *buf, size_t count)
> > +{
> > +	unsigned long val;
> > +
> > +	if (kstrtoul(buf, 0, &val) < 0)
> > +		return -EINVAL;
> > +
> > +	if (val)
> > +		bus_for_each_dev(bus, NULL, NULL, scan_fsl_mc_bus);
> > +
> > +	return count;
> > +}
> > +static BUS_ATTR(rescan, 0220, NULL, bus_rescan_store);
>=20
> BUS_ATTR_RO()?
>=20
>=20

Since this is a write-only attribute, a BUS_ATTR_WO would be needed but the=
re is no WO macro defined.

Ioana

>=20
> > +
> > +static struct attribute *fsl_mc_bus_attrs[] =3D {
> > +	&bus_attr_rescan.attr,
> > +	NULL,
> > +};
> > +
> > +static const struct attribute_group fsl_mc_bus_group =3D {
> > +	.attrs =3D fsl_mc_bus_attrs,
> > +};
> > +
> > +static const struct attribute_group *fsl_mc_bus_groups[] =3D {
> > +	&fsl_mc_bus_group,
> > +	NULL,
> > +};
>=20
> ATTRIBUTE_GROUPS()?
>=20
> thanks,
>=20
> greg k-h