Received: by 10.213.65.68 with SMTP id h4csp2551623imn; Mon, 2 Apr 2018 09:33:08 -0700 (PDT) X-Google-Smtp-Source: AIpwx49tS7qVVefvv3yI5PoB3V/G5GE6TvF5nq+QaSquMpaMsUJQCNcBRJtMOmowSi9S0GmAevS/ X-Received: by 2002:a17:902:7e42:: with SMTP id a2-v6mr10526946pln.13.1522686788413; Mon, 02 Apr 2018 09:33:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522686788; cv=none; d=google.com; s=arc-20160816; b=mwdEBXrqLRVMc5ZcpatdkJYeBozvR2MH7aV+X+ShQ8tW23URoPyqJ1/U+tKbITBJR6 Te6LjKplNf8gM9m6k3/qVw6MiyFTk48VHTY4wEov2izgu5Yev3l4KXrVWyWogoeFpOr2 iR3lYsDWpuN/adihKWUBgQQZqaaG8m2SsUpkwzQuI8hmhcLdrZBMKaE5BlHZBrhU31bI lFDGXlRDPByz0L6DA8GWx5MAi7bgt8NVGv/hZR05kndKuEeBAt2yuhFmSiFsKg8N0r4K ZhTLnSatj4HYHLqFJHW1xYR1MzJG3Nu3tp0+iLDR83WmREo/bldE9AYm4TjgbkplW4A9 c+Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject:arc-authentication-results; bh=A/Z+/2isO4Eysw/zCNbPEnnBEFbOr9UAAJbYCelKT/Y=; b=fNxV+kKdg/Z+oVUp/mm0AYcZzNzAgnkcwNEPjdN+YgfNmCWRLWMsErAaZBdOK7xHzL Dn11dnbrE3AKEgpvxQanKlT95Dggl17mA6EmyHXI2ONka1sOwC2gKO/IW2WLmrHHCPX2 iZ56i2hv98D6H0K1IC5hdFfCRNRRmvbZ8dZs/iabHeMeYs3H7Ejmnz4G6pxZEFwVeFY7 jrwwmjdOo3xnlRpMnj//03dXbWRCYc4rFiReDXkque1Sqd4CEttG6OviVANQecIAMQXY nuMsLnKEM60ZXdixnqE/NK/d8byW9ve7SmgVWhIbQannBDLpL7ifVs9HQP3BazOMACO2 HQtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y191si453125pfb.80.2018.04.02.09.32.53; Mon, 02 Apr 2018 09:33:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752978AbeDBQbl (ORCPT + 99 others); Mon, 2 Apr 2018 12:31:41 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:44072 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbeDBQbk (ORCPT ); Mon, 2 Apr 2018 12:31:40 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w32GTa0U029261 for ; Mon, 2 Apr 2018 12:31:40 -0400 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0a-001b2d01.pphosted.com with ESMTP id 2h3p9jwe7n-1 (version=TLSv1.2 cipher=AES256-SHA256 bits=256 verify=NOT) for ; Mon, 02 Apr 2018 12:31:39 -0400 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 2 Apr 2018 10:31:38 -0600 Received: from b03cxnp08026.gho.boulder.ibm.com (9.17.130.18) by e38.co.us.ibm.com (192.168.1.138) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 2 Apr 2018 10:31:35 -0600 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w32GVZok6226358; Mon, 2 Apr 2018 09:31:35 -0700 Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 413A5BE039; Mon, 2 Apr 2018 10:31:35 -0600 (MDT) Received: from rosattig.br.ibm.com (unknown [9.18.239.102]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP id 19D3BBE03A; Mon, 2 Apr 2018 10:31:33 -0600 (MDT) Subject: Re: [PATCH v2] nvmet: fix nvmet_execute_write_zeroes function To: Keith Busch Cc: linux-kernel@vger.kernel.org, hch@lst.de, linux-nvme@lists.infradead.org, sagi@grimberg.me References: <1522680581-10220-1-git-send-email-rosattig@linux.vnet.ibm.com> <20180402145813.GE28945@localhost.localdomain> From: Rodrigo Rosatti Galvao Date: Mon, 2 Apr 2018 13:31:33 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180402145813.GE28945@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18040216-0028-0000-0000-00000962DF9A X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008790; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000255; SDB=6.01012099; UDB=6.00515790; IPR=6.00791369; MB=3.00020377; MTD=3.00000008; XFM=3.00000015; UTC=2018-04-02 16:31:37 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18040216-0029-0000-0000-00003A362005 Message-Id: <10c64856-15bf-eed8-c9db-33b4d9ea58f3@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-04-02_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1804020183 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I'm terribly sorry, but the +1 actually needs to be outside the > le16_to_cpu. The above will work on little-endian machines, but not big. No problem at all. Thank you for helping on this. I'm going to send a V3 with this change. -- Rodrigo R. Galvão Intern - Linux Technology Center - IBM