Received: by 10.213.65.68 with SMTP id h4csp2553261imn; Mon, 2 Apr 2018 09:34:57 -0700 (PDT) X-Google-Smtp-Source: AIpwx48qhpGeHwutlEOLOnO55xDSQM4fKNq/okbolijwrVJCvxWpfAS5cxcYxknOVycfo/ApEMbH X-Received: by 2002:a17:902:6b07:: with SMTP id o7-v6mr10555952plk.136.1522686896963; Mon, 02 Apr 2018 09:34:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522686896; cv=none; d=google.com; s=arc-20160816; b=cOh2PfZWhpnx2HE+z2uYJEaa4h5FRJyLm8adkam6b4xC/7KHGMuV2NmpLPXOTThNqS RNGpOVNjD86pQOxFt26hoPsgdQJBmQQi1OoD0n95ZlXaa6UOAqkCWtZL9FOGBV3bdu3X Bu7mcQiGa+y2Y5J1NDUXH85HDjCJIGx8x7B8cwxGhalmQU3QkIgZSkNp8Y1UZ0Zle3C5 W15wTi9a/fDzfS/IK5eQGlxuylQft0LVzo8iNH+n+1vgRgKX88jabxqr6gnofNmIG+SJ I4CljmxgQ5bptpTApyRjN7Sf/Df9VGeHSpQdv5LdDg+j5gaNRYguP+mXz2RfLs3RLdy+ 2J2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=MmMjcuwOkzvLUu8S9yYD5OzMmFZn06M7kpXdUAwCdo8=; b=Se6CJDgZhYsQpUG+6+YVWOC47ms4BWB13DT4xUbam596VCV7SqYqGAYE+lksHxaQPJ jp088GtDpLm3ve423nTd4UT95oCj/NibjB9vVWQ0t1j2ffrosY1hLaorngUD5paLD3uv hFBHUYndIeoXCOAOrfHMfxllVT4m2Hmjx1fB0RzHOmJpqFMkORufCv5ibktF/7oKV2Zy i4UqgGG9s87Nfsih4Hy0NvNcTzsgeSb/E+Jvuw9RycDSyVxy7x4FDOIcjnoYLOrW9SGa 0jNH7xoiqIfr2H1B7gki/2E6I9fK7G6k6AueUasHiFYOOKfcU9ZsiCS5u8syBo+K4Wj0 KWgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PFjxVtHh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j66si437216pgc.566.2018.04.02.09.34.42; Mon, 02 Apr 2018 09:34:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=PFjxVtHh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753142AbeDBQcz (ORCPT + 99 others); Mon, 2 Apr 2018 12:32:55 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49074 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbeDBQcx (ORCPT ); Mon, 2 Apr 2018 12:32:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=MmMjcuwOkzvLUu8S9yYD5OzMmFZn06M7kpXdUAwCdo8=; b=PFjxVtHhoHaLpYW8ampLfmlKW56V9DxFOonTYA/AeLZgovXwe//PVZ0GW5ZZwJitAV1l6Pcw5YzmNuLk8L3aRUFXmbACn766rUqil4VpcFSujUsdg1GXrUxdyJ9dpwQwiWg2NzbTD7LwID4hJUEduP0PTWmgNyVhQdE3ge5J+iI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1f32Nu-0004Am-I0; Mon, 02 Apr 2018 18:32:42 +0200 Date: Mon, 2 Apr 2018 18:32:42 +0200 From: Andrew Lunn To: Tim Harvey Cc: Guenter Roeck , Mark Rutland , devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Dmitry Torokhov , linux-kernel@vger.kernel.org, Rob Herring , Wim Van Sebroeck , Mark Brown , linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Subject: Re: [v3,4/4] watchdog: add Gateworks System Controller support Message-ID: <20180402163242.GC14165@lunn.ch> References: <1522250043-8065-5-git-send-email-tharvey@gateworks.com> <20180330010757.GA12896@roeck-us.net> <20180330181954.GA17580@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The 'use case' we have been using this in for a couple years is that > users who want to use this watchdog will enable it externally (we have > a command in the bootloader) and if enabled the kernel driver (that > I'm proposing here which we've been using out-of-tree) will register > the watchdog device and the userspace watchdog process can open the > device and start tickling it. If the watchdog is never enabled (or > disabled via the bootloader command) the kernel driver fails to probe > and the SoC's watchdog can be used. Hi Tim Is there any reason not to give the user the choice to use both watchdogs? Normally you write drivers to expose the hardware, and then let the users choice if they want to use it. Andrew