Received: by 10.213.65.68 with SMTP id h4csp2776475imn; Mon, 2 Apr 2018 13:54:20 -0700 (PDT) X-Google-Smtp-Source: AIpwx49jo8qx2D4RAsfMSZTsQvAcIASw+tK+p3EwS7N6GtgGt3wZAchIWuASS9UPutI1l/UOhFQU X-Received: by 10.167.130.76 with SMTP id e12mr8463450pfn.192.1522702460142; Mon, 02 Apr 2018 13:54:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522702460; cv=none; d=google.com; s=arc-20160816; b=UCWQ82Agb+w8fSXSAJZXNTb5US+iBIWO+Ggs1I4EkHtQDogSI/rMfGnjLLmtshpbqV pomiqeWNGA+3qQ0tpFjfDOxn9gQAwiPo5KdYh5n+yQmxInq0eT6K368esFfjvns5nnjf 8JvkqkgPLhTJIdfV+q4+aZJ/bY626Xlheu+GKyBAvyEDBzxCp1h1plpzCJzlqo+ieSmj eR/Y/0XUsgd3QfJcv3bnuznFT5ph3/MWCvPWqkdt5EJyKeQTgtZHCZXIFwv+q/k5WgbE 5pIzwCRykIkDUkIzCdy1ZavvBGzBcL9Si7Gw3Y1uD/jdR0se4KtzK5RaHNxV2udDXQEk RhoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=+aVn3qOJ3wCDyEhDJCVWZ+myihWRGWghUXUssuBc0jw=; b=J9WVVYyY5cZp/xxZiP6tnqF7a6b6i3u2zn4kaEmvx9AcVYgFvPPCqCIRVL2F8foaXS VH6BadD49fqVsaCWcNjbewDbqHmYPFPTUMt+v4+pObysWt6qntL3x13hFYx86onr6F4F Nkuw5IhGnLSMcQ+jm2kglHOa4LCjwodHPD4E8wBUFBNxu4L5g/uEdjywgGOMrzbfcyzT cAwz8eN7zHnFlJKK3tq/l7Qz8rTi7YV1tfN0RP1EFXP8uQW4hJXViLzbmGdTHsqXFJfa Xfq07R5YmVGu1m6kC5GMHBwkgqOjAGm9CpFq79bLQxXgJtSxAUJmCNaCDrpbPw9xoyJt ALVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f3si713330pgn.383.2018.04.02.13.54.05; Mon, 02 Apr 2018 13:54:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754349AbeDBUw6 (ORCPT + 99 others); Mon, 2 Apr 2018 16:52:58 -0400 Received: from osg.samsung.com ([64.30.133.232]:35974 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753116AbeDBUw4 (ORCPT ); Mon, 2 Apr 2018 16:52:56 -0400 Received: from localhost (localhost [127.0.0.1]) by osg.samsung.com (Postfix) with ESMTP id 12EA424A08; Mon, 2 Apr 2018 13:52:56 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at dev.s-opensource.com Received: from osg.samsung.com ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZsMcEgihaFDb; Mon, 2 Apr 2018 13:52:54 -0700 (PDT) Received: from localhost.localdomain (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) by osg.samsung.com (Postfix) with ESMTPSA id 7ACE4249F6; Mon, 2 Apr 2018 13:52:54 -0700 (PDT) From: Shuah Khan To: valentina.manea.m@gmail.com, shuah@kernel.org, gregkh@linuxfoundation.org Cc: Shuah Khan , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usbip: vhci_hcd: Fix usb device and sockfd leaks Date: Mon, 2 Apr 2018 14:52:32 -0600 Message-Id: <20180402205232.21659-2-shuahkh@osg.samsung.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180402205232.21659-1-shuahkh@osg.samsung.com> References: <20180402205232.21659-1-shuahkh@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org vhci_hcd fails to do reset to put usb device and sockfd in the module remove/stop paths. Fix the leak. Signed-off-by: Shuah Khan --- drivers/usb/usbip/usbip_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/usbip_common.h b/drivers/usb/usbip/usbip_common.h index 473fb8a87289..bf8afe9b5883 100644 --- a/drivers/usb/usbip/usbip_common.h +++ b/drivers/usb/usbip/usbip_common.h @@ -243,7 +243,7 @@ enum usbip_side { #define VUDC_EVENT_ERROR_USB (USBIP_EH_SHUTDOWN | USBIP_EH_UNUSABLE) #define VUDC_EVENT_ERROR_MALLOC (USBIP_EH_SHUTDOWN | USBIP_EH_UNUSABLE) -#define VDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_BYE) +#define VDEV_EVENT_REMOVED (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | USBIP_EH_BYE) #define VDEV_EVENT_DOWN (USBIP_EH_SHUTDOWN | USBIP_EH_RESET) #define VDEV_EVENT_ERROR_TCP (USBIP_EH_SHUTDOWN | USBIP_EH_RESET) #define VDEV_EVENT_ERROR_MALLOC (USBIP_EH_SHUTDOWN | USBIP_EH_UNUSABLE) -- 2.14.1