Received: by 10.213.65.68 with SMTP id h4csp2785729imn; Mon, 2 Apr 2018 14:04:14 -0700 (PDT) X-Google-Smtp-Source: AIpwx49R13FpW/EHFHAiZvM4TsLAa3/Y7GVsmktpjIOeGo2a19PevPL+xgqr+VfhCONEaMOxPpLm X-Received: by 10.99.63.205 with SMTP id m196mr7074124pga.82.1522703054130; Mon, 02 Apr 2018 14:04:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522703054; cv=none; d=google.com; s=arc-20160816; b=hA0CfvD2SvSbA1u5/kuGRn8YY5Fo9DxubJQ0MgLGxTNuyRn1KMG7xkl50Gu2RiH7YI WLLmBBhf76gC6oho379TEhKzdRNtPQOW+E1mMOW2cEe2KriZjeCq+g5Hnxz+ihmxWb/j FirWC2+W5SZOiDFIkG1Z/KyBk75R7HsdBmOBsb55pRVm/VHe2jh8vn54Si+0IQY3HDpn Xcq2nPKqiOxpKh2Gp5qobLlswxeEf/TTm3O2OjocKk0sFJ2JU+qVeWapX1vs05/NWhSb FY7snr8VFLeLjiLjExxdXQ9C83LDPdkzVdtG1GbkUErT+6Z9qcfVeoFQdku6kq9cd1Sa Na3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=gsaQ79ml/QFv1hFm3rko31w0EjDVJAVJ0Nxqn3kZvZY=; b=sGpbFVzsOoOBQkDQHU0agPUQQ3BelXSxjl1HpblDeY2zVfAd60FkCunQlMdi2yJLdC 9Jfm1aOoIqi4pr3m4uePZxYbteRbRf0fw5DiVMz1iyxpqxoA18vH2CuiWCECIRCxwpdo mY33YPIlpbj19uB+d7PpdNEUlV3aqhg112vE2nRCnVQ/ElN+TJfHxlPs7Hpo2bzZjZcW oZrzZ0iCqSdWd70FFo2l3fc+whtcHBjCF9Xn0ZAXXPlE08WPS4X0592MFxHap49+dQHi Ma4cHQpQ+bpIx4DWk58ExSCO4OqVlXm64J6QjFfgeLxRL1PtbKE/NuwU0A1oUTX2n2jm q2VA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aZsghnRm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21si779403pgc.569.2018.04.02.14.03.57; Mon, 02 Apr 2018 14:04:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=aZsghnRm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753355AbeDBVCq (ORCPT + 99 others); Mon, 2 Apr 2018 17:02:46 -0400 Received: from mail-ua0-f174.google.com ([209.85.217.174]:39215 "EHLO mail-ua0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321AbeDBVCo (ORCPT ); Mon, 2 Apr 2018 17:02:44 -0400 Received: by mail-ua0-f174.google.com with SMTP id m47so9708372uae.6; Mon, 02 Apr 2018 14:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gsaQ79ml/QFv1hFm3rko31w0EjDVJAVJ0Nxqn3kZvZY=; b=aZsghnRm8MhQ/wLgmVfXE1YkpZLcQM+52in98FIurY6UCUZ5XCrAvNpvvrGqgip2/x qcu+h03J82ij7KbzLCTIbjKbKNYvvVIv/4t8Mj9vPFGgO0Ef316ge1x5N4umPLDNO1EO zrmySxQGMs+dX1mbAjjo94VsnFQHxSBTsyqEjTvTQ9040+dgokZ8pc0Xwz9oweUWfcbU GOBPVTKP4m87RK158wXNPZG+iAz8ZyMeN9LmECsLic2D3Hvp1PzX3odp+b5KmNmWIhKX D7aKdlGiGYOgNzY/PxgeOkK4eMxNvsMuU4fASgiFfSwfyP0vtETSkmtmdaz1IxcfwIzW VlVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gsaQ79ml/QFv1hFm3rko31w0EjDVJAVJ0Nxqn3kZvZY=; b=lm5mh4L6pwHKRP+z45+7zY8ZKxZL5xSCHsHmJoBVMw3m8Qmlgl2+86HrhOSbAlRRZb LbLELEoOtrLDoHtvCWzZmxM5Ka2cUxiZtOf/mlyVX6gk7TksjppVSEkBuDspnO+YHURL JwBn3z47Iai+vqEyvu5B1Dviq5E/7ByQ17fiEM947u1ux3TTgnWmcZ+lh2mBDV5Biw+6 AMbok90VgpArveeuZ6E6W0FjEN/Vi+YacVg7f3SWN3KPQAPrb7Aq6To8yW2dfI9Oaczg dDqdb+fvmtjK1S1Z718VKKQKyq6QnObLQ5ucJlk00+r+RUqXQL9GXOhdfPScs+mIFb6+ VLKg== X-Gm-Message-State: AElRT7Hx74eF01AFQ+E1+oWRntrdaCI8ZmAFcvD6tw4lMZl8G5qrX0pD xh57ysyjIjE4sH8Va5xDO4V5acmm/TzKzm6vsHA= X-Received: by 10.176.112.153 with SMTP id m25mr6505025ual.191.1522702963730; Mon, 02 Apr 2018 14:02:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.222.149 with HTTP; Mon, 2 Apr 2018 14:02:13 -0700 (PDT) In-Reply-To: <20180402202951.GE388343@devbig577.frc2.facebook.com> References: <20180402202951.GE388343@devbig577.frc2.facebook.com> From: Sitsofe Wheeler Date: Mon, 2 Apr 2018 22:02:13 +0100 Message-ID: Subject: Re: [BISECTED][REGRESSION] Hang while booting EeePC 900 To: Tejun Heo Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Stefan Haberland , Jan Hoeppner , Bart Van Assche Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On 2 April 2018 at 21:29, Tejun Heo wrote: > > Can you see whether the following patch makes any difference? > > Thanks. > > diff --git a/block/blk-timeout.c b/block/blk-timeout.c > index a05e367..f0e6e41 100644 > --- a/block/blk-timeout.c > +++ b/block/blk-timeout.c > @@ -165,7 +165,7 @@ void blk_abort_request(struct request *req) > * No need for fancy synchronizations. > */ > blk_rq_set_deadline(req, jiffies); > - mod_timer(&req->q->timeout, 0); > + kblockd_schedule_work(&req->q->timeout_work); > } else { > if (blk_mark_rq_complete(req)) > return; That patch seems to fix the issue. -- Sitsofe | http://sucs.org/~sits/