Received: by 10.213.65.68 with SMTP id h4csp2868167imn; Mon, 2 Apr 2018 15:54:35 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/hltj2tl3sL1bq5dzNgOKD5k308Q5EYwmUaIthaTmZzVylvpEQG8x4DihJ/QOOpbYOSGFP X-Received: by 10.98.87.150 with SMTP id i22mr2282413pfj.119.1522709675221; Mon, 02 Apr 2018 15:54:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522709675; cv=none; d=google.com; s=arc-20160816; b=pLTXrB58Y4xi1QqwYgg4vBMe1jRRIn8ehcrqHzPyxJsX3MjWs/Nr+Ke4czzhojZN9P f68uvXDbbwAzTSXgvehf4aTqv3yxoFsGi4oxkLNENob+hxi/llNLyvfJrFY+9C05Z5fy HW/QY0kjKliITQ7l6YHu0GfQ5A76WT0g3ZdI7VghIdd92EV8afsB9ySj5NzWzsArNOBe 4H2b5iDknHrjcyCRh789Qv4bJofDMv/5Xp5y4txFdA/L12AOtm3Gd2P5V+ftHosqSHyw IIJibfbcdtUBTFRjL6mTzla9pfISwM6kUH7yrkaqZIx8Cp/nRFLmMVtiJA37LWnmwFvp SIig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=euZqFX4nYthcut/Ma7Y4MgY2eldmYe8dasJRyom0fhg=; b=W22qc5DGwpeuM8ygKO/UNy+jS+/ul97aRErmfZSfm3OgI047wRaQAtsgb7BpOVSpn2 TA9msHjIdHQEPcCqiz0Zk933q7gTwKAMy0cJwn98FL0mw5M9ZyHPhfYgrRQ1IfzlapKX e2uQtPVsbPZ+wcJTcxVn33FHbZooCcVPgJHwtyLmCM/IJ6SKTsm80a7XpdXRe+aUMXJp BbpRLb2gMeNBod911mjyyuuSDv3JNB+yWiisINb15E/b7oelzBZ20/XrWzKO0XuXvP9v lzcJl3ib1am6F6G1UosVB9AjRqGwO1gunUyEZ4EAdG9mjhk0LGf1j/mOYyUAV2rsW/Ym W4LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b=qeRpO8fh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m32-v6si1273783pld.174.2018.04.02.15.54.21; Mon, 02 Apr 2018 15:54:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nexus-software-ie.20150623.gappssmtp.com header.s=20150623 header.b=qeRpO8fh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754731AbeDBWvP (ORCPT + 99 others); Mon, 2 Apr 2018 18:51:15 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:53725 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754583AbeDBWvN (ORCPT ); Mon, 2 Apr 2018 18:51:13 -0400 Received: by mail-wm0-f49.google.com with SMTP id p9so28819163wmc.3 for ; Mon, 02 Apr 2018 15:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=euZqFX4nYthcut/Ma7Y4MgY2eldmYe8dasJRyom0fhg=; b=qeRpO8fhLc/LcIyX6Tst9Br0zrG2Jw6TCvZI4VeT6NHK15HSH3kt5C3OZr/GDNXgqN wQRfGqUVYQFBx6W/aHOlYaiwoDXvJm+7OqvMO/A+JRVy3eQqNtFcBT1qnnDvk6uzP/r1 FPpdkTdeUm7G6gMY4eJDOV7theUfU6okRgRsimaFuOchUYOp+0KA7VwGQeOIKL1bGtNI WpXPaqXrYi9PKbFWok3A6B7NoEbIjviJg2vWBJUqzjfxuXhhH/IpZnDlHm3ZChQbkwUM iNeKKZehuBonhCN1jrnzPR782Az+9RX5bTRbdw0MBYC4prw7KA30MLrbg91v068SQAvg 6CTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=euZqFX4nYthcut/Ma7Y4MgY2eldmYe8dasJRyom0fhg=; b=oLnfQSjgdhVflaarZGmPJ1OOKgadn13OYYvCtTx2V5Se7uplGXH2ASd6XW6yrw0m4l rJRIBCr2xE0zswdAQsJThasifVzWIU8VnFvggYiS1Ktim2rnVKWk25boIphZ0IfSfnDk VXY4C0Dt+qqoZD+IN4nfcmX3pDp5xu4B7mUXMuAJtp+aeALN11pkuh4k2rv6DDe1rHRH TMLiTS1vAcfygfeCbkTgcNaXawtOfgGyUfM7R7Uittr0HOtoZiwLJcDHvBl6ikFp7dlr FhU8agWgOhxsURWEoY9kpI0n2blxYP6OA7tNAjtZwu40PJdjK1HMIdijhXtjF0jswMu1 pIuA== X-Gm-Message-State: AElRT7EmBtZTkikm6mtwcU6u5UajN7tUHMBRiiDod7MDwvru8mx+Yp3D HVOsfY3wUT9RDxnHPgxGWg/oXg== X-Received: by 10.80.213.11 with SMTP id u11mr14209854edi.281.1522709472661; Mon, 02 Apr 2018 15:51:12 -0700 (PDT) Received: from [192.168.192.37] ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id h64sm807449edc.86.2018.04.02.15.51.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Apr 2018 15:51:12 -0700 (PDT) Subject: Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc_enable To: Trent Piepho , "linux-kernel@vger.kernel.org" , "alexandre.belloni@free-electrons.com" Cc: "shawn.guo@linaro.org" , "stefan@agner.ch" , "bianpan2016@163.com" , "a.zummo@towertech.it" , "stable@vger.kernel.org" , "guy.shapiro@mobi-wize.com" , "Frank.Li@freescale.com" , "linux-rtc@vger.kernel.org" References: <1522264445-2398-1-git-send-email-pure.logic@nexus-software.ie> <1522282337.10662.268.camel@impinj.com> <1522450739.10662.278.camel@impinj.com> From: Bryan O'Donoghue Message-ID: <4f9434c7-6977-caef-2fac-5da79364304b@nexus-software.ie> Date: Mon, 2 Apr 2018 23:51:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1522450739.10662.278.camel@impinj.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/03/18 23:59, Trent Piepho wrote: > However, I think that even if the driver fails to probe if there is a > timeout at probe time, it's still possible to hang later if there are > not limits to the hardware polling loops, such as the ones I added. I agree with your patch in principle for this the reason you've outlined. My patch though should still be applied to fix non-starting @ source. /aside - I don't have your patch in my inbox - if you could resend and cc me I'll review it for you. --- bod