Received: by 10.213.65.68 with SMTP id h4csp2882966imn; Mon, 2 Apr 2018 16:13:28 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+POyOy8pFXEy3TAMtODWmtYlEUglholRHxAGz6/6WoWCKa4bByaEAtWIJRaK2jcQosofzl X-Received: by 10.98.171.7 with SMTP id p7mr8710749pff.215.1522710808126; Mon, 02 Apr 2018 16:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522710808; cv=none; d=google.com; s=arc-20160816; b=KkEePmLt7L3TW4b9SSfRvUzhmZ/IHjNPM/71p0h58o33TOlV+SRzr9Dhx/OV63dZ8n B+vQx4ShZ1wHGs2F/3vLfV+z5oYvaFbSdyb8OucDP5+UY0+Z8IFaSRWNkjCOlL3UoLKm 3ViLozBRgOBeA82v5SK/OFXuKF0ZWBy9mU/AGDxVfyN4m0c9PMd5FUxELdiLh9P/q3Td hCo+bXUqZDn8pbNPghOXROrT+wivm2uOEDbsqiV22OkA9fzs2EdQ713f7sctF2zmf0qv yag17udCya/DLUbb2kRUElUicGKyhEptZ4phxH7ti/+IbrN2Jbj4g0FmquZdFx+yrwCo p46A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=kkXpwjChjmGvmEs/1xQARC4AnRfHBvp+/NKodBr8bC8=; b=OJbLWXaEKuFUkg0iA411QP0zsULTDa1qUbwj1iGwjOaA6y/UCErEmjYOXa+5BBVWsS sR5Y0sEWhJwCsau5PtIjlU51cBR0Vq3bptZYBlJvTES217+cXAHEYaNmh+phuNy0fU0L aLpkfHvuZoBSU02rB1Ck8iyPmJ4PyDzFf45M1f+ufuKM+9D9yO71oT1jpgUgwCROYdFS 1w8ei/iQtWpS/Zf7zX3xryEIjo1t9jq7F86mxD4ofi1AQdmIjjhJxRmgiPb8TuE4bDWL l7uG0LbY68BkeJfofOG3DekYoN3Xw1nbi16PyoxOYQsEhcj7YiLnKb8YiFRSWKhoLc15 WlNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=cXWoHfKz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w3si892873pge.719.2018.04.02.16.13.10; Mon, 02 Apr 2018 16:13:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=cXWoHfKz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754586AbeDBXL7 (ORCPT + 99 others); Mon, 2 Apr 2018 19:11:59 -0400 Received: from mail-pl0-f42.google.com ([209.85.160.42]:43490 "EHLO mail-pl0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754550AbeDBXL6 (ORCPT ); Mon, 2 Apr 2018 19:11:58 -0400 Received: by mail-pl0-f42.google.com with SMTP id c21-v6so2587735plz.10 for ; Mon, 02 Apr 2018 16:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=kkXpwjChjmGvmEs/1xQARC4AnRfHBvp+/NKodBr8bC8=; b=cXWoHfKzZS+O8jVMqtsU0e2OE79btUFevskKFgCEuZGrc50PG6z658l0pVW8vzFKBP TQcggMs4x7KeWLFTml+YPCM8b+H+qlu/r7Bg7pWya1xq+5mrcQmNT5IaeRFzdaNGmN7j fK0d5TOyeTjD8Xeg1x1MdLmGk9I1zRKGDWUVR2IZ9Ze9rYK52//RHDS6JTjlQ5GvtKY0 hn3/jcavHgJZoKtAYpKFDNJbJ8mBdjN6wKiXD/GhbOcHbWeSByGQRW7F/MxsloJY6U7g 9kJTLXnoflxfwoqNTab/mHTqhGGs5GtuwW0qHMRurgP8e48pUP2akW4dO0G95WmW5Hdq 4ocQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=kkXpwjChjmGvmEs/1xQARC4AnRfHBvp+/NKodBr8bC8=; b=DHeMTmge6S5jRsL3uAUyj7h2yWS6hZS0UE+8JyONKjydT7H1a5/UnoWpuhfcWFVzqJ 0RyAfujwod1+PZc0Mr3LaiHe25iXr/pQavShAGm7Xz0Es2c2LtKdk2EVJoQyDsrH3b6x bFQ3+nU22Ujw1pDFn3j9nnPR1uARYwA4vrAOQ42l4ShDD3rysMivIMTs6kTQefchUvn2 GT1bxLF2AhsUPZzYUMkrIwL00aasKcyc0WZQwgl1BbIgDNEqzkrDdbjZn2rXnuWENDfc keC9e1RdoB/AdfC5jwUNev8fFb+a6t27yG/liLrjaQsp8m75syd6A2anAeCo4cjo1jzU 8WfA== X-Gm-Message-State: AElRT7FD7bMCO41+ACZBp6qtS4a6hJARB2RNtJ5zPY9U23hE6Z7+k4UT usvIjMXyeLdnps5zT+QL6N21yQ== X-Received: by 2002:a17:902:bb87:: with SMTP id m7-v6mr11751683pls.103.1522710717369; Mon, 02 Apr 2018 16:11:57 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id w12sm2376687pfi.180.2018.04.02.16.11.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Apr 2018 16:11:56 -0700 (PDT) Date: Mon, 2 Apr 2018 16:11:55 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Laurent Dufour cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org, akpm@linux-foundation.org, kirill@shutemov.name, ak@linux.intel.com, mhocko@kernel.org, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Thomas Gleixner , Ingo Molnar , hpa@zytor.com, Will Deacon , Sergey Senozhatsky , Andrea Arcangeli , Alexei Starovoitov , kemi.wang@intel.com, sergey.senozhatsky.work@gmail.com, Daniel Jordan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com, npiggin@gmail.com, bsingharora@gmail.com, Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org Subject: Re: [PATCH v9 13/24] mm: Introduce __lru_cache_add_active_or_unevictable In-Reply-To: <1520963994-28477-14-git-send-email-ldufour@linux.vnet.ibm.com> Message-ID: References: <1520963994-28477-1-git-send-email-ldufour@linux.vnet.ibm.com> <1520963994-28477-14-git-send-email-ldufour@linux.vnet.ibm.com> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Mar 2018, Laurent Dufour wrote: > The speculative page fault handler which is run without holding the > mmap_sem is calling lru_cache_add_active_or_unevictable() but the vm_flags > is not guaranteed to remain constant. > Introducing __lru_cache_add_active_or_unevictable() which has the vma flags > value parameter instead of the vma pointer. > > Signed-off-by: Laurent Dufour Acked-by: David Rientjes