Received: by 10.213.65.68 with SMTP id h4csp3408597imn; Tue, 3 Apr 2018 04:33:07 -0700 (PDT) X-Google-Smtp-Source: AIpwx49w8RZ/IXKcd8p8Ltk+PHmIKw+Tqm4rdTw4qiS+TR27Ua/kEyORPPMCb2r19wrSD4RB5dMG X-Received: by 2002:a17:902:3181:: with SMTP id x1-v6mr13680790plb.269.1522755187435; Tue, 03 Apr 2018 04:33:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522755187; cv=none; d=google.com; s=arc-20160816; b=gp8P2hotsIjfvf4I8ogjNYainXmiv9y0Qo11LQqRjtqk4t5KVFA4URVPiigZr7Db6/ N3cl2YtQRWJCOOVL/XMzYmatK13Y5bHZPSnTuZoXlRUrMX2mem7JiGATyhHdYUEyIcCU jv97OOVBNmk7yBMFZlCD8vMQ10wq15w8+lUI8ZVsh568WxSG5b4MMPYaZgWXYANYkoHB jWfymi4emYbGGfGHvD7AAjTRUOeBXPIJBWqxL6QHMlAHdjedBFNhbktbvS3As6YuO//0 eTytm8dq1mAjeV+svr7jL1e5RX4xQVAFZQELiDcsqB8xhPuL7SvWLW3bAmheN9QmCqe+ sGHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=JbY4YqCKbc8fpivLbikSFjKngcRBSAfnWmTUgVftJTQ=; b=Y1EI6cnr+PqYdV9MYYY6x+7R/8h0uhJDcg7USjpe6GjxCDb8bjKhD6wF3azz2R+oM2 p6DQQkkNQ6Clk/DpkXcwGxFlHlSsHUNu2Xdv35ePsqk18RFAvtYlWOVV6N1RNS0oRurA Tss2VKWCEBOplxUA0HZBGvY8bPo9lzLxGDwtUjGwLgVnr8dwcs1T5dh20a17K4Xv/qMy pApMoSOgW8CVC3Xb0erScMk2/R+49xPrZ/gb/4L/Yqp1BFNRVku4Bq/NY3hcx6e1KFbY qgeLEg00YYPCtNQp93hXtc4im/GJAt0GxqRbgUYYZsB4uG6c8uwtXsxYe2kpPf2IpVvn dOXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=G2y2L62g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h2si1908523pfn.191.2018.04.03.04.32.53; Tue, 03 Apr 2018 04:33:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=G2y2L62g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932118AbeDCLbk (ORCPT + 99 others); Tue, 3 Apr 2018 07:31:40 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:46718 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932066AbeDCLbj (ORCPT ); Tue, 3 Apr 2018 07:31:39 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w33BH1Z4186768; Tue, 3 Apr 2018 11:31:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=JbY4YqCKbc8fpivLbikSFjKngcRBSAfnWmTUgVftJTQ=; b=G2y2L62gFf85fFKyd96fnu1WT8/oHAKWzaveWuGlrXxxD2GPm8YAmuefXjZI1nnq+V5Y lfKVXIOOf4sLxjTTxPkNIrDIk1+myiIKSli92A40Si9PXzRPgspifrIUIZ9TyNa2p8IN 9aqltbad1ZuPgNfQ3YSy9YblCb5D854YHV54PXpABnouSCfZdEIZHuGy00Ivj/oxw8rW UhTUKBTqOkXxC729JDNIQ0q6XIYdOXQoFrQsRryEF4TQS3nM9Bq1vhtLH0t1lukxMKUo tFKaYtafWAZXVtzlV6NKbavJgnl/oFzfIGDrJfhEzsSMDAXtDfOVCTZP1iW+T4FM17er jA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2h48kqr1yc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Apr 2018 11:31:29 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w33BCKvg003518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Apr 2018 11:12:20 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w33BCIaJ012369; Tue, 3 Apr 2018 11:12:19 GMT Received: from mwanda (/197.254.35.146) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 03 Apr 2018 04:12:18 -0700 Date: Tue, 3 Apr 2018 14:12:10 +0300 From: Dan Carpenter To: Ji-Hun Kim Cc: gregkh@linuxfoundation.org, baijiaju1990@gmail.com, forest@alittletooquiet.net, devel@driverdev.osuosl.org, y.k.oh@samsung.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, santhameena13@gmail.com Subject: Re: [PATCH v4 1/2] staging: vt6655: check for memory allocation failures Message-ID: <20180403111210.utskcq6255k6o6tq@mwanda> References: <1522389115-1124-1-git-send-email-ji_hun.kim@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522389115-1124-1-git-send-email-ji_hun.kim@samsung.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8851 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=551 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804030118 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This will crash. Please see my comments that I just posted to v3. regards, dan carpenter