Received: by 10.213.65.68 with SMTP id h4csp3484980imn; Tue, 3 Apr 2018 05:54:40 -0700 (PDT) X-Google-Smtp-Source: AIpwx49noYFFwDyD6POkYlU8aaL02uEclHlSMafE9hwwiEESNVCX7wRkqqbtSisWNfw9TkTWpbgx X-Received: by 2002:a17:902:8d96:: with SMTP id v22-v6mr14329398plo.373.1522760080933; Tue, 03 Apr 2018 05:54:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522760080; cv=none; d=google.com; s=arc-20160816; b=TVBI41318oyRJT/fibv9bLDEOh5O6tGqNs2N6LG97zhhAKY88lresTtMuM+ESJprf7 VI6WgK0FQjeNWwpepk29O0EITDOzPjBRTXTLv1ntUwizNel9JHhvNe5a/k0C4wOV26wa hzjR/SGUFPYWsZ8k9unEPcsXcWngg8TRsHXEWAzTYhOIYblr6EfyDTmlx/ZkBDR/dvjd EWCH+LfHCdrAKfEKbgJZpq4vUwn9VqTQFbeefQLq3pMZvBs4z/fLzuaHPg2Ah4hCADyJ oB6Ehh1nrTLr9SJI2vyBrrHT+e7TAUce9aq2hKqR072g/biRTl4M12K4MXuZ+VxobjV/ V7bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=aOOOHiH3sYeVjO2u1Z+Q8SL1bgqNKOKqF5mrDlA+H4E=; b=ewwg+F1xxWmG8NAAM4Rqg3YBDrfb8Wt35P/fPvz4l0pZcIaqT/suhO2BDPFxwXaC7T vbA74cgtSfJiAyTDGkwddw2WLEcTVowQOzPSMa2hOTov7kvwKuDkhdMYwuMMZPbXYDfZ mf4UuvqN+q+pLTsN8OWRUotXVHsWJWFEBQ9XG/VvA6qhrW64qEbDTyjwTFoPBMs+yjko vzjnA0cb/TI2WFgOYTFA94+QfM2v0JRdLi0PB4AzsRj2iUBl/Ijv8B8x8WI3A8NjLp+K TyiH2R3E1HUYi+qNB/FEg4HnsS9Y8h4fcFoSmdek7pgrqX89KVllYe9bvix927UoacqB Su6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4-v6si453372pls.314.2018.04.03.05.54.26; Tue, 03 Apr 2018 05:54:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932157AbeDCMxV (ORCPT + 99 others); Tue, 3 Apr 2018 08:53:21 -0400 Received: from foss.arm.com ([217.140.101.70]:60616 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932087AbeDCMxT (ORCPT ); Tue, 3 Apr 2018 08:53:19 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 56EDB1529; Tue, 3 Apr 2018 05:53:19 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.207.54]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C39A3F25D; Tue, 3 Apr 2018 05:53:17 -0700 (PDT) Date: Tue, 3 Apr 2018 13:53:12 +0100 From: Lorenzo Pieralisi To: Niklas Cassel Cc: Kishon Vijay Abraham I , Niklas Cassel , cyrille.pitchen@free-electrons.com, Jingoo Han , Joao Pinto , Bjorn Helgaas , Niklas Cassel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 06/12] PCI: designware-ep: Make dw_pcie_ep_set_bar() handle 64-bit BARs properly Message-ID: <20180403125312.GA18128@e107981-ln.cambridge.arm.com> References: <20180328115018.31921-1-niklas.cassel@axis.com> <20180328115018.31921-7-niklas.cassel@axis.com> <45971780-3a46-061d-bb76-2f450401c797@ti.com> <20180402193703.GB23587@flawful.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180402193703.GB23587@flawful.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 02, 2018 at 09:37:03PM +0200, Niklas Cassel wrote: > On Thu, Mar 29, 2018 at 03:17:11PM +0530, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Wednesday 28 March 2018 05:20 PM, Niklas Cassel wrote: > > > Since a 64-bit BAR consists of a BAR pair, we need to write to both > > > BARs in the BAR pair to setup the BAR properly. > > > > > > Signed-off-by: Niklas Cassel > > > --- > > > drivers/pci/dwc/pcie-designware-ep.c | 11 +++++++++-- > > > 1 file changed, 9 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/pci/dwc/pcie-designware-ep.c b/drivers/pci/dwc/pcie-designware-ep.c > > > index 5a0bb53c795c..571b90f88d84 100644 > > > --- a/drivers/pci/dwc/pcie-designware-ep.c > > > +++ b/drivers/pci/dwc/pcie-designware-ep.c > > > @@ -138,8 +138,15 @@ static int dw_pcie_ep_set_bar(struct pci_epc *epc, u8 func_no, > > > return ret; > > > > > > dw_pcie_dbi_ro_wr_en(pci); > > > - dw_pcie_writel_dbi2(pci, reg, size - 1); > > > - dw_pcie_writel_dbi(pci, reg, flags); > > > + if (flags & PCI_BASE_ADDRESS_MEM_TYPE_64) { > > > + dw_pcie_writel_dbi2(pci, reg, lower_32_bits(size - 1)); > > > + dw_pcie_writel_dbi(pci, reg, flags); > > > + dw_pcie_writel_dbi2(pci, reg + 4, upper_32_bits(size - 1)); > > > + dw_pcie_writel_dbi(pci, reg + 4, 0); > > > + } else { > > > + dw_pcie_writel_dbi2(pci, reg, size - 1); > > > + dw_pcie_writel_dbi(pci, reg, flags); > > > + } > > > > > > I think this should work too? > > dw_pcie_writel_dbi2(pci, reg, lower_32_bits(size - 1)); > > dw_pcie_writel_dbi(pci, reg, flags); > > > > if (flags & PCI_BASE_ADDRESS_MEM_TYPE_64) { > > dw_pcie_writel_dbi2(pci, reg + 4, upper_32_bits(size - 1)); > > dw_pcie_writel_dbi(pci, reg + 4, 0); > > } > > > > Hello Kishon, > > I agree, your suggestion is more neat. > > > Kishon, please tell me if you insist that the long if-statement > in pci_epc_set_bar() should be split, since there are 5 different > conditions. Because imho, having 5 succeeding if-statements isn't > clearer than having 1 long if-statement. > > If Kishon agrees with me, then the review comment in this mail > seems to be the only review comment. > And in that case, perhaps Lorenzo wouldn't mind fixing this up. > Or perhaps Lorenzo prefers if I reroll the whole patch series? I updated it myself in my pci/endpoint branch, please have a look, I can't guarantee we can merge this for this cycle though, I will ask Bjorn; apologies I could not be online for a while. Lorenzo > Kind regards, > Niklas