Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 3 Apr 2018 16:52:02 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Xidong Wang <wangxidong_97@163.com>
Cc:     Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        Xidong Wang <2711406067@qq.com>, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] taging: fbtft: fix memory leak
Message-ID: <20180403135202.3lj4dwafogo5bwrf@mwanda>
References: <1522761268-7176-1-git-send-email-wangxidong_97@163.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1522761268-7176-1-git-send-email-wangxidong_97@163.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

There is a typo in the subject.  It should be "Staging" instead of
"taging:".

On Tue, Apr 03, 2018 at 09:14:28PM +0800, Xidong Wang wrote:
> From: Xidong Wang <2711406067@qq.com>
> 
> In function fbtft_framebuffer_alloc(), the memory allocated by
> framebuffer_alloc() is not released on the error path that txbuflen > 0
> and txbuf, which holds the return value of devm_kzalloc(), is NULL.
> This will result in a memory leak bug.


The txbuf chunk seems to have been dropped.  You're right that it needs
to be fixed as well.

        if (txbuflen > 0) {
                txbuf = devm_kzalloc(par->info->device, txbuflen, GFP_KERNEL);
                if (!txbuf)
-                        goto alloc_fail;
+			 goto err_info;

regards,
dan carpenter