Received: by 10.213.65.68 with SMTP id h4csp3600013imn; Tue, 3 Apr 2018 07:44:06 -0700 (PDT) X-Google-Smtp-Source: AIpwx49K/pEStQGNvetFzy8xz7lEOT40GHDpEeD/tdz/wkKufR8mO3vlusmx1rglH4k+CEGedt86 X-Received: by 2002:a17:902:788e:: with SMTP id q14-v6mr14824864pll.396.1522766646829; Tue, 03 Apr 2018 07:44:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522766646; cv=none; d=google.com; s=arc-20160816; b=NFUGP3J6KyS+1cpGj0bV1LQiCHv1PqX7TYGJ8RNvERsv5m8qxk0wmt/iqGc1td2WE9 ZBvSl4nFLH+gHgF+MdW1LD9rdnsYNYva0ex2Bk4RKPIFh2gkgR+T8rk2Fg4iDG86VM/r jOVHGnvCkB0uQBc0uHXTeLJ1yfuKdUQopU5X3ceqnAaExmcD1kpPZt+8o2hQCJ6cFeB1 bGqSlXEmAP8xPmXfMUANP82uMCeEs7xqV3eAQygc0HQyD/k61cNxusBNVX98zB9MdAlj //UzQh8o4+9rnSGXlLfMnR69BNeY2vq89U8euNYhkqk+VhYh3ImmpqzhRng8yvLJ9yvQ oW0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=xHDnZMEyufTeaIYB6cAeqX75rT1uyPI8iWaFe8MLXVI=; b=QYirUsa4+5hywBjxiN4Brod5FXxTES3I3BDbcWcfApEyRpuANj2Qjo6F2dLd6UVYko tKXLTtJqL54h783r1XMbLeORKiRArQcEhRTX2RdAXWdZ/xFGYAobwORNUOsGdJQfHXnD M4BlvxR015C3QWPmQoUV+5TyZBtURsQIRqUm99wPHMjuER0H6iiqrp93EW+e7UNrk1dN QnuKluHrmz+U0V5VqTsSc/9GQzWYYjyBwR/tD1q8y7WD/au5Xi8ApecvnrzqOS9uIL03 Xo98jPbd356edqOfs1aC50gGdw5rWxS3tAFgoiID7L80X+7ZZLC7hGufvXDsaNkC31sm LSTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si714871plo.228.2018.04.03.07.43.53; Tue, 03 Apr 2018 07:44:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752011AbeDCOm1 (ORCPT + 99 others); Tue, 3 Apr 2018 10:42:27 -0400 Received: from mail.bootlin.com ([62.4.15.54]:50227 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbeDCOmX (ORCPT ); Tue, 3 Apr 2018 10:42:23 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 01C3A20713; Tue, 3 Apr 2018 16:42:22 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [37.71.171.242]) by mail.bootlin.com (Postfix) with ESMTPSA id CC9922066A; Tue, 3 Apr 2018 16:42:11 +0200 (CEST) Date: Tue, 3 Apr 2018 16:42:11 +0200 From: Alexandre Belloni To: Bryan O'Donoghue Cc: Trent Piepho , "linux-kernel@vger.kernel.org" , "shawn.guo@linaro.org" , "stefan@agner.ch" , "bianpan2016@163.com" , "a.zummo@towertech.it" , "stable@vger.kernel.org" , "guy.shapiro@mobi-wize.com" , "Frank.Li@freescale.com" , "linux-rtc@vger.kernel.org" Subject: Re: [RESEND] rtc: snvs: Fix usage of snvs_rtc_enable Message-ID: <20180403144211.GM14180@piout.net> References: <1522264445-2398-1-git-send-email-pure.logic@nexus-software.ie> <1522282337.10662.268.camel@impinj.com> <1522450739.10662.278.camel@impinj.com> <4f9434c7-6977-caef-2fac-5da79364304b@nexus-software.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4f9434c7-6977-caef-2fac-5da79364304b@nexus-software.ie> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02/04/2018 at 23:51:12 +0100, Bryan O'Donoghue wrote: > On 30/03/18 23:59, Trent Piepho wrote: > > However, I think that even if the driver fails to probe if there is a > > timeout at probe time, it's still possible to hang later if there are > > not limits to the hardware polling loops, such as the ones I added. > > I agree with your patch in principle for this the reason you've outlined. > > My patch though should still be applied to fix non-starting @ source. > > /aside - I don't have your patch in my inbox - if you could resend and cc me > I'll review it for you. > It is available in mbox format here: http://patchwork.ozlabs.org/patch/887090/mbox/ -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com