Received: by 10.213.65.68 with SMTP id h4csp3666755imn; Tue, 3 Apr 2018 08:47:43 -0700 (PDT) X-Google-Smtp-Source: AIpwx48lvGpTEpjOJpF7/zrvgEuGImTkZfWq7ez2k2VTJI4wxqIbiHKWSAGcgZuckzXIhlu1K8Fe X-Received: by 2002:a17:902:2f:: with SMTP id 44-v6mr14749909pla.187.1522770463171; Tue, 03 Apr 2018 08:47:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522770463; cv=none; d=google.com; s=arc-20160816; b=Q7mVVx8OQ4wbEqmSt4ex6e6qhBerHEwykCGO+wLzssg5BA4ifdZpjdqUsRAzqVSnzt GOBw4tHGWC7jVjGPrDNsp9JP2/zoce2XIUScIi4vNxLBdy32znOZjdmSLL3IqVDP+CVh gfklcbd57yQuXm9iO9EdztreFTRiuuTWFVxjgi/LnpracK22O8hrSstkLuVEi0bHBp3f EvX5a8+OQ97HrwPxYBnDkKZ2vyQNzidddkGG5s1G9wilZvOC6K5jv7oxnbEzi9wm5pIc ky5lZaJOB1OuSsdAubARkmDHugJPKESe0zv0vndhzvQ3rqiF2YZTlTp8nhQoa+DSfBxy h0Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=aw58kvtCKfWH4QM/dUNaNdUM6zOg6S7O/tYojmu9M00=; b=bamKxlf3t523hHChtUvYxSMAwz8xGm1vh4HV/eHd5IRFvzv63slws9tcqPR22kDfsj 2fSq7rdKzfLmQOI+6K7t6tD3ibvjCN7ak3rNxBi7w+0fl7+zxhA379Qbmw2NXowDENNG fS7uArdjUoStE0IIUVYr1l2qq9pPTV75zP7uyBj/8U9ZWKQzdQd6y60Ut1pmYFlH9M3x SnLBr07JMIBOEhFGWHGxGModfz4WFN6BCceNM8Vt7iFOCysZz+Wuv39LCxaZkHnUu481 wc796YkCx2MME0OOPhphOMGSIGpKbNp+P/Bf0PnUvyX9zlf9LPGP9uOyyjoQjJcACf8z 3mYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@orpaltech.com header.s=mailru header.b=R6Bk7brP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3si574788pfh.84.2018.04.03.08.47.29; Tue, 03 Apr 2018 08:47:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@orpaltech.com header.s=mailru header.b=R6Bk7brP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752660AbeDCPpx (ORCPT + 99 others); Tue, 3 Apr 2018 11:45:53 -0400 Received: from smtp57.i.mail.ru ([217.69.128.37]:49298 "EHLO smtp57.i.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbeDCPo7 (ORCPT ); Tue, 3 Apr 2018 11:44:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=orpaltech.com; s=mailru; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=aw58kvtCKfWH4QM/dUNaNdUM6zOg6S7O/tYojmu9M00=; b=R6Bk7brPZ80WF2cNV7Ci7YlqgDidwRltXYupvm/8QSZSWqoyrqdsZY++hy3cwOlre+FtRp/KKQJxHmds2mYDuiRH1g2ysC4YK8dbL/MD+7K8I2+uQI/65A28HgATuT561o4ML/iZQ88LJOVsPc4K1qUqqGESWIam5MgYPtGgqQU=; Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1f3O7E-0002Dz-Rr; Tue, 03 Apr 2018 18:44:57 +0300 From: Sergey Suloev To: Mark Brown , Maxime Ripard , Chen-Yu Tsai Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sergey Suloev Subject: [PATCH v3 4/6] spi: sun6i: use completion provided by SPI core Date: Tue, 3 Apr 2018 18:44:47 +0300 Message-Id: <20180403154449.2443-5-ssuloev@orpaltech.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180403154449.2443-1-ssuloev@orpaltech.com> References: <20180403154449.2443-1-ssuloev@orpaltech.com> Authentication-Results: smtp57.i.mail.ru; auth=pass smtp.auth=ssuloev@orpaltech.com smtp.mailfrom=ssuloev@orpaltech.com X-7FA49CB5: 0D63561A33F958A505A817744D892096840FE9263A247D77F6CCE0BD96863144725E5C173C3A84C3A1C30C8AFC676C8B8FCF3E344E8F691A2219AA581D1B0840C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-Mailru-Sender: C5364AD02485212F3ACDC11E67D84917604D420E97150EFE5351951060103B38069BFC61DABEEB110841D3AAAB1726C63DDE9B364B0DF289264D2CD8C2503E8C22A194DADEED8EEDCA01A23BA9CD1BE7ED14614B50AE0675 X-Mras: OK Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As long as the completion is already provided by the SPI core then there is no need to waste extra-memory on this. Also a waiting function was added to avoid code duplication. Changes in v2: 1) Fixed issue with passing an invalid argument into devm_request_irq() function. Signed-off-by: Sergey Suloev --- drivers/spi/spi-sun6i.c | 52 ++++++++++++++++++++++++++++--------------------- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c index c09ad10..0912404 100644 --- a/drivers/spi/spi-sun6i.c +++ b/drivers/spi/spi-sun6i.c @@ -99,8 +99,6 @@ struct sun6i_spi { struct clk *mclk; struct reset_control *rstc; - struct completion done; - const u8 *tx_buf; u8 *rx_buf; int len; @@ -246,6 +244,30 @@ static int sun6i_spi_prepare_message(struct spi_master *master, return 0; } +static int sun6i_spi_wait_for_transfer(struct spi_device *spi, + struct spi_transfer *tfr) +{ + struct spi_master *master = spi->master; + unsigned int start, end, tx_time; + unsigned int timeout; + + /* smart wait for completion */ + tx_time = max(tfr->len * 8 * 2 / (tfr->speed_hz / 1000), 100U); + start = jiffies; + timeout = wait_for_completion_timeout(&master->xfer_completion, + msecs_to_jiffies(tx_time)); + end = jiffies; + if (!timeout) { + dev_warn(&master->dev, + "%s: timeout transferring %u bytes@%iHz for %i(%i)ms", + dev_name(&spi->dev), tfr->len, tfr->speed_hz, + jiffies_to_msecs(end - start), tx_time); + return -ETIMEDOUT; + } + + return 0; +} + static int sun6i_spi_transfer_one(struct spi_master *master, struct spi_device *spi, struct spi_transfer *tfr) @@ -267,7 +289,6 @@ static int sun6i_spi_transfer_one(struct spi_master *master, if (tfr->len > sspi->fifo_depth) return -EMSGSIZE; - reinit_completion(&sspi->done); sspi->tx_buf = tfr->tx_buf; sspi->rx_buf = tfr->rx_buf; sspi->len = tfr->len; @@ -358,21 +379,9 @@ static int sun6i_spi_transfer_one(struct spi_master *master, reg = sun6i_spi_read(sspi, SUN6I_TFR_CTL_REG); sun6i_spi_write(sspi, SUN6I_TFR_CTL_REG, reg | SUN6I_TFR_CTL_XCH); - tx_time = max(tfr->len * 8 * 2 / (tfr->speed_hz / 1000), 100U); - start = jiffies; - timeout = wait_for_completion_timeout(&sspi->done, - msecs_to_jiffies(tx_time)); - end = jiffies; - if (!timeout) { - dev_warn(&master->dev, - "%s: timeout transferring %u bytes@%iHz for %i(%i)ms", - dev_name(&spi->dev), tfr->len, tfr->speed_hz, - jiffies_to_msecs(end - start), tx_time); - ret = -ETIMEDOUT; - goto out; - } + /* Wait for completion */ + ret = sun6i_spi_wait_for_transfer(spi, tfr); -out: sun6i_spi_write(sspi, SUN6I_INT_CTL_REG, 0); return ret; @@ -380,7 +389,8 @@ out: static irqreturn_t sun6i_spi_handler(int irq, void *dev_id) { - struct sun6i_spi *sspi = dev_id; + struct spi_master *master = dev_id; + struct sun6i_spi *sspi = spi_master_get_devdata(master); u32 status; status = sun6i_spi_read(sspi, SUN6I_INT_STA_REG); @@ -389,7 +399,7 @@ static irqreturn_t sun6i_spi_handler(int irq, void *dev_id) if (status & SUN6I_INT_CTL_TC) { sun6i_spi_write(sspi, SUN6I_INT_STA_REG, SUN6I_INT_CTL_TC); sun6i_spi_drain_fifo(sspi, sspi->fifo_depth); - complete(&sspi->done); + spi_finalize_current_transfer(master); return IRQ_HANDLED; } @@ -496,7 +506,7 @@ static int sun6i_spi_probe(struct platform_device *pdev) } ret = devm_request_irq(&pdev->dev, irq, sun6i_spi_handler, - 0, dev_name(&pdev->dev), sspi); + 0, dev_name(&pdev->dev), master); if (ret) { dev_err(&pdev->dev, "Cannot request IRQ\n"); goto err_free_master; @@ -518,8 +528,6 @@ static int sun6i_spi_probe(struct platform_device *pdev) goto err_free_master; } - init_completion(&sspi->done); - sspi->rstc = devm_reset_control_get_exclusive(&pdev->dev, NULL); if (IS_ERR(sspi->rstc)) { dev_err(&pdev->dev, "Couldn't get reset controller\n"); -- 2.16.2