Received: by 10.213.65.68 with SMTP id h4csp3753013imn; Tue, 3 Apr 2018 10:04:57 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+QZ94YpTiOZa1pTOaQ/jXP0hGorcPkmWV/WUtbt0I2F0XcuEs2+hlyPyEEYL/aig35pbKE X-Received: by 10.98.72.74 with SMTP id v71mr11063390pfa.241.1522775097454; Tue, 03 Apr 2018 10:04:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522775097; cv=none; d=google.com; s=arc-20160816; b=WG0qhEGes9F3pqiL/ij2RINGTZMPGpOwiOglQR8iCsGfFAVOiQdoiLcLhEz7YmzpIo Ok3FYFiMLUXXni67cM4ZomtgUGT/ndqrXAJCzA4JBg/y6vM9/t6u1C1ukWwbfid/dwtK soqVYF9ifNcGLfR5jyITgqiBVCKE7poskU9hZnlzw17eWxN8HVsN4EG9xvczyEM3zphp nKalkzBzGzLNNrpfijJqF7GBM+xzqj+FJQPRci+M2XT3fyyBVhOqXrf8ahsEFQchcpd5 loclLR2BMHvIbuoYD+Su8G9ujGDXXEZeWi+asES/HW54WLZ97Y2uzMoiEcPUcVauie9E fD3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=rjnEJKdZFEzRpeTEOA1hZ2VgyGA1ri5Pxv9KjWgoY4w=; b=BvV9j39SRvbdA86s4LrRTf2c1+DrVmesfAynI03iK7IDbSLmAuaig+AUvFkWvAK38d 7tIrt+si5CMXkEyfbyhQWB3TOojmL6VMgAlBjrxwFJX5tn8HPf1gjlX7ZCNLuC/n6h3a b89L+HgTjz0Ds2f3H/rh94sItozOOD7AGZ8myhUookwfMN0IID4cwU6AFgm6++p/62GQ Ds5zz7l3T7NPsKJF4RdwbPfLX+SQRED+iWYnYpDo84OxAMO0/HtdL/fTMTfOQdt8rKVs Av1yM83o+ufzToXJ0MyZPW+ANr1g50kq9pZfLbkodRIRzalgYuL4yL3Pq/xWpDMCP0wE tygw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JSo9leSm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p77si2488973pfk.294.2018.04.03.10.04.42; Tue, 03 Apr 2018 10:04:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JSo9leSm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752480AbeDCRCw (ORCPT + 99 others); Tue, 3 Apr 2018 13:02:52 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:44836 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbeDCRCt (ORCPT ); Tue, 3 Apr 2018 13:02:49 -0400 Received: by mail-qt0-f194.google.com with SMTP id j26so19943350qtl.11; Tue, 03 Apr 2018 10:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rjnEJKdZFEzRpeTEOA1hZ2VgyGA1ri5Pxv9KjWgoY4w=; b=JSo9leSmJ2hM+vO5H91SCR8mCcJdOl8zD1r3cpniRUu6M/MY7569m5f5nsxOTYX4TL iY6/m2Ycv4zzD/ys9aXDIOgl6DcQkODkQSBQPjKXP8tACtvXij2OmMk8mP7NBEQeq4nr 1M2yTiS3GTXbk04Pi3KbQvH+jZ2zC3xsAt3lUQD4mqIPzi2FlYjPeHRYfOyT2Tu+MGOI K064ccAcvnGbph0G3vUcovupXREjYbWgq9ix6s5XXQJft0U/CnPvTx7P3W1UjlXLF8Bi HpdpSLoGeWWEsp2crOBzFceeclv6sXLKZm7fYJEZPXA2+HGCGTSrXVTPU5fPvpE8vMeo TPcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=rjnEJKdZFEzRpeTEOA1hZ2VgyGA1ri5Pxv9KjWgoY4w=; b=RP2i50fM6gZpWtKEFchIEZgYuKvbuwsZgpx9GL+/IiJsJWN4n//vHinYKyZyr+H1kw bqELTtIBLiuZIoTm4gNB715PzM3A3uY3QjZsCtzcMoDg7q0VA9xnmSP+u6kOF4vdXwdK xJb9sTNELo57wh8r/KAPhXfvx++8FApfNV8ns1878ula//Ud+eew+5bSQlYR5F2C/mhg DH2eIKV236fFPe77gNCRoN9BjIu3cuOreGBXGtxEovsAODDKdrPwR0vR43atuGPixlW/ CeGe8R6wwsgGryuL84sIfx6rJX7dd9YpImHqUtdtAuOaO6FjaIcmxtv5TY2u+3lNTrFy zDtA== X-Gm-Message-State: ALQs6tALyYIOSPTZ0oeCGGzqsOfMxBBCA8ut7e7NK4vjenBE2PebLkSC RQ2ftb++0VIn7A6xFS12eDY= X-Received: by 10.200.23.152 with SMTP id o24mr21668002qtj.255.1522774968793; Tue, 03 Apr 2018 10:02:48 -0700 (PDT) Received: from [10.69.41.93] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id p199sm2327782qke.31.2018.04.03.10.02.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Apr 2018 10:02:47 -0700 (PDT) Subject: Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer To: Sean Wang Cc: netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , open list , linux-mediatek@lists.infradead.org References: <20180402232414.19671-1-f.fainelli@gmail.com> <1522721904.18424.51.camel@mtkswgap22> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Message-ID: Date: Tue, 3 Apr 2018 10:02:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1522721904.18424.51.camel@mtkswgap22> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/02/2018 07:18 PM, Sean Wang wrote: > On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote: >> We would be passing 0 instead of NULL as the rsp argument to >> mt7530_fdb_cmd(), fix that. >> > > Acked-by: Sean Wang > > BTW, does the part of the commit message should be updated with "passing > NULL instead of 0"? I don't follow you, the commit message indicates what we were doing which implies it was wrong and fixes it. Would you want me to reword that part? -- Florian