Received: by 10.213.65.68 with SMTP id h4csp3775930imn; Tue, 3 Apr 2018 10:25:53 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/+A9I8/oKX7ScfChgfKWHbYz6CT6Rvsc4d7ZxYNBlw/QhCel+hpw84Q8f3HnA6uq9XADBA X-Received: by 10.98.217.139 with SMTP id b11mr11338056pfl.113.1522776353910; Tue, 03 Apr 2018 10:25:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522776353; cv=none; d=google.com; s=arc-20160816; b=yYG8licWaABiPprdeXBLb0cFUHMKLU25gIrqh2o6W273PRTdcFs+bYJZiZBjuXUAf/ uHcklhbX4amJcMNM6EmYCSVMDAp3Gkl7B6jQz0dfdGDmg6PmbhmPcDxPJBTdqjXxr8up gukPV4jG0K7sZhWGmdyZMgKNXCcdGc4MK53gnoKOaZkOmt9hfDhC+khmTHhS/cNUGOOC m8PGU6KKM1+DTOzHtjqFNtC4MZUZ4LINlmZMRUuZ4cng5QSTq5KyHGakOaRHEwX+EGtI ByLGfbpQdLhCWr+1kLj45hgPsTaTQLxU0w3wcrnaJiwvCQ9UkmjUaozOwR1PL/kPxQEb DVrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=YrqVyUfswuEjZBCviR+F3VOzXCQ3qxgt8GykPyOKF78=; b=IIOBucuT2Tyz5rf4s9G9wOiiFFfm24C2CFsKhkLZGMfKlrPpZp51ngReDSOpPz6a71 KXqJHm4hIZiHDdCG6Qva7TAhRA0pR03n63/y51/OEeoPrzDaJLDuRJfjqMUeQaP1TJ+r dr8pBO59qQN4F6pTifmFZExlfVckVFh2vPguWxZFMdB8nZtEXc3nxS7WehqhlgAi59ro wcpEGEVktxcNk/94/XM8WOTF1eEdv6EV6fTB/NDiOJfKgCd3eJ5zcqn+xmg+4Nv+G2// qjFTcyVL39P1bPTJXx6jE+2w2FzppN6c1fmAZZO4WEJfPVLi4F1MVRQ7azD0990avXp/ 0vTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=qP+Sjsyo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o12-v6si897484plg.715.2018.04.03.10.25.40; Tue, 03 Apr 2018 10:25:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=qP+Sjsyo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752479AbeDCRXj (ORCPT + 99 others); Tue, 3 Apr 2018 13:23:39 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60296 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897AbeDCRXg (ORCPT ); Tue, 3 Apr 2018 13:23:36 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w33HIUjj123810; Tue, 3 Apr 2018 17:23:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2017-10-26; bh=YrqVyUfswuEjZBCviR+F3VOzXCQ3qxgt8GykPyOKF78=; b=qP+SjsyoNPShi4x7uzBKu0lcTp6AMOc6sO7+5g1qO8j4fEN/HF4q2CiVjmIZOGlI9NSe eYf2NfN3YJ19JjfGc+EMvEBnS+iufw1qKq7bTp0/+gJf5E4Wg0u65kfH8zgkvqrTOORF RzaC6/kWE4KpuhcarSKn8AZCxdA10mr086j60h0B2iDJkYumCivB78vgBudI94b47flY BuAqNLWePJk2mGB9qbpdG/JwPvV+yRaHQGlJPdkO2wUotk2D84w3MwrWve5LxdB6is6u PprzYtNXa7mITf/d3e6KUjaFLZdPBIiUsQmz6tkBcBcROnk58uVfe6G2TeWl0DR7v1xr 6A== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2h4dw7g0qa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 Apr 2018 17:23:11 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w33HNA8s013681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Apr 2018 17:23:10 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w33HN82K028670; Tue, 3 Apr 2018 17:23:09 GMT Received: from oracle.com (/67.188.214.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 03 Apr 2018 10:23:08 -0700 From: rao.shoaib@oracle.com To: linux-kernel@vger.kernel.org Cc: paulmck@linux.vnet.ibm.com, joe@perches.com, willy@infradead.org, brouer@redhat.com, linux-mm@kvack.org, Rao Shoaib Subject: [PATCH 0/2] Move kfree_rcu out of rcu code and use kfree_bulk Date: Tue, 3 Apr 2018 10:22:51 -0700 Message-Id: <1522776173-7190-1-git-send-email-rao.shoaib@oracle.com> X-Mailer: git-send-email 2.7.4 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8852 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=4 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=987 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1804030176 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rao Shoaib This patch moves kfree_call_rcu() out of rcu related code to mm/slab_common and updates kfree_rcu() to use new bulk memory free functions as they are more efficient. This is a resubmission of the previous patch. Changes since last submission Surrounded code with 'CONFIG_TREE_RCU || CONFIG_PREEMPT_RCU' to separate tinyurl definitions. Diff of the changes: diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 6338fb6..102a93f 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h @@ -55,8 +55,6 @@ void call_rcu(struct rcu_head *head, rcu_callback_t func); #define call_rcu call_rcu_sched #endif /* #else #ifdef CONFIG_PREEMPT_RCU */ -/* only for use by kfree_call_rcu() */ -void call_rcu_lazy(struct rcu_head *head, rcu_callback_t func); void call_rcu_bh(struct rcu_head *head, rcu_callback_t func); void call_rcu_sched(struct rcu_head *head, rcu_callback_t func); @@ -210,6 +208,8 @@ do { \ #if defined(CONFIG_TREE_RCU) || defined(CONFIG_PREEMPT_RCU) #include +/* only for use by kfree_call_rcu() */ +void call_rcu_lazy(struct rcu_head *head, rcu_callback_t func); #elif defined(CONFIG_TINY_RCU) #include #else diff --git a/mm/slab_common.c b/mm/slab_common.c index 6e8afff..f126d08 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -1526,6 +1526,7 @@ void kzfree(const void *p) } EXPORT_SYMBOL(kzfree); +#if defined(CONFIG_TREE_RCU) || defined(CONFIG_PREEMPT_RCU) static DEFINE_PER_CPU(struct rcu_bulk_free, cpu_rbf); /* drain if atleast these many objects */ @@ -1696,6 +1697,7 @@ void kfree_call_rcu(struct rcu_head *head, __rcu_bulk_free(head, func); } EXPORT_SYMBOL_GPL(kfree_call_rcu); +#endif Previous Changes: 1) checkpatch.pl has been fixed, so kfree_rcu macro is much simpler 2) To handle preemption, preempt_enable()/preempt_disable() statements have been added to __rcu_bulk_free(). Rao Shoaib (2): Move kfree_call_rcu() to slab_common.c kfree_rcu() should use kfree_bulk() interface include/linux/mm.h | 5 ++ include/linux/rcupdate.h | 43 +----------- include/linux/rcutiny.h | 8 ++- include/linux/rcutree.h | 2 - include/linux/slab.h | 42 ++++++++++++ kernel/rcu/tree.c | 24 +++---- kernel/sysctl.c | 40 +++++++++++ mm/slab.h | 23 +++++++ mm/slab_common.c | 174 +++++++++++++++++++++++++++++++++++++++++++++++ 9 files changed, 304 insertions(+), 57 deletions(-) -- 2.7.4