Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1522776711.12959.1.camel@mtkswgap22>
Subject: Re: [PATCH net] net: dsa: mt7530: Use NULL instead of plain integer
From:   Sean Wang <sean.wang@mediatek.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
CC:     <netdev@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
        open list <linux-kernel@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>
Date:   Wed, 4 Apr 2018 01:31:51 +0800
In-Reply-To: <f5aa0467-8124-b097-2b89-dcf1698a5ba5@gmail.com>
References: <20180402232414.19671-1-f.fainelli@gmail.com>
         <1522721904.18424.51.camel@mtkswgap22>
         <f5aa0467-8124-b097-2b89-dcf1698a5ba5@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2018-04-03 at 10:02 -0700, Florian Fainelli wrote:
> On 04/02/2018 07:18 PM, Sean Wang wrote:
> > On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote:
> >> We would be passing 0 instead of NULL as the rsp argument to
> >> mt7530_fdb_cmd(), fix that.
> >>
> > 
> > Acked-by: Sean Wang <sean.wang@mediatek.com>
> > 
> > BTW, does the part of the commit message should be updated with "passing
> > NULL instead of 0"?
> 
> I don't follow you, the commit message indicates what we were doing
> which implies it was wrong and fixes it. Would you want me to reword
> that part?

thanks for the explanation.

the commit message is clear and okay for me now