To: Greg KH <greg@kroah.com>
Cc: "David S. Miller" <davem@redhat.com>, Jeff Garzik <jgarzik@pobox.com>,
       rddunlap@osdl.org, davej@redhat.com, willy@debian.org,
       linux-kernel@vger.kernel.org,
       kernel-janitor-discuss@lists.sourceforge.net
Subject: Re: C99 Initialisers
References: <3F397FFB.9090601@pobox.com>
	<20030812171407.09f31455.rddunlap@osdl.org>
	<3F3986ED.1050206@pobox.com>
	<20030812173742.6e17f7d7.rddunlap@osdl.org>
	<20030813004941.GD2184@redhat.com>
	<32835.4.4.25.4.1060743746.squirrel@www.osdl.org>
	<3F39AFDF.1020905@pobox.com>
	<20030813031432.22b6a0d6.davem@redhat.com>
	<20030813173150.GA3317@kroah.com> <m31xvpe2ar.fsf@defiant.pm.waw.pl>
	<20030813212611.GA6652@kroah.com>
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: 15 Aug 2003 00:46:04 +0200
In-Reply-To: <20030813212611.GA6652@kroah.com>
Message-ID: <m365kz5043.fsf@defiant.pm.waw.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 791
Lines: 16

Greg KH <greg@kroah.com> writes:

> > +	{ PCI_DEVICE(BROADCOM, TIGON3_5700) },
> > +	{ PCI_DEVICE(BROADCOM, TIGON3_5701) },
> > 
> Someone else mentioned that to me, but that's just mean as this file
> shows that not all device ids are in the pci id table.

PCI_VENDOR_ID_xxx can be #defined in the driver as well, no problem here.
Grepping - yes, real problem.

Using one 32-bit value for two 16-bit vendor and device IDs may be
worth considering, too. Some potential problems, though, not 2.6 I think.
-- 
Krzysztof Halasa
Network Administrator
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/