Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1522791985.2654.142.camel@codethink.co.uk>
Subject: Re: [PATCH 4.4 70/97] rtc: ds1374: wdt: Fix issue with timeout
 scaling from secs to wdt ticks
From:   Ben Hutchings <ben.hutchings@codethink.co.uk>
To:     Moritz Fischer <mdf@kernel.org>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc:     stable@vger.kernel.org,
        Sasha Levin <alexander.levin@microsoft.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Date:   Tue, 03 Apr 2018 22:46:25 +0100
In-Reply-To: <20180323094201.536829633@linuxfoundation.org>
References: <20180323094157.535925724@linuxfoundation.org>
         <20180323094201.536829633@linuxfoundation.org>
Organization: Codethink Ltd.
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2018-03-23 at 10:54 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Moritz Fischer <mdf@kernel.org>
> 
> 
> [ Upstream commit 453d0744f6c6ca3f9749b8c57c2e85b5b9f52514 ]
> 
> The issue is that the internal counter that triggers the watchdog reset
> is actually running at 4096 Hz instead of 1Hz, therefore the value
> given by userland (in sec) needs to be multiplied by 4096 to get the
> correct behavior.
[...]

The wdt_margin module parameter has the same problem.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.