Received: by 10.213.65.68 with SMTP id h4csp179836imn; Tue, 3 Apr 2018 18:18:18 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+6dSMxWTOJFLqOcI+df0XzTLOS59hQOtzS3yCcPPYIx/WEZ30emonyb+UxygUwpufzR0tH X-Received: by 10.98.178.76 with SMTP id x73mr10492429pfe.193.1522804698055; Tue, 03 Apr 2018 18:18:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522804698; cv=none; d=google.com; s=arc-20160816; b=Im5VBAu9NheeYQlyvSriSL7gowcRMAvKKBQthdqNSwovg053CUnriNsKa0duRZ5yab cbCj/ycRvnET4Xz497mhI8zLV0plquiNY7xKPXA9fHIc/+IigJ1ub92lDnpM0Dt2ke3u 8YPGQMLWq15KHFHePVeh27TY+sfWmHb3EBKCmNs5KeSAKhROgqdmhcA64MVELqnLTb9B gU4XkXnzteUVQHohdEpbPKuyE5uEOq2bbt9TNa/bVNX5b2/iLnd4ZB44E45YiaUUNSjO sQzGXbFTZ49Au3TUyXkq+xxdtqtlmDuXIgJm0dLO6EkX4ULg/uoalO2mX9PgFholD73u 1QAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=bG0JjoSY9tYIS6ScZAeFivgtj0FdZDiYO4+Ey3LeMCY=; b=A5vzDiCq8HjRqAqYDFae+wHA9jmmvIT9qFP0URHwQQdr4M6DHnzDjt/rLJXJrcjh/3 BCQNUtXPDeupce5j9tW6lMrn/SH6W6FBomLX94YzBo6KKX4eyzRAIiQrfG210+S0I+L+ aMssnsrqjdvwTzRjaRuBf48RriqktDoJDExQbW7W3AavW9IVNStNalwMn0nsYtsk/3a9 /q6x4AccKXXLu6iU6gOn7L7M2mB/HmFdC9Br7IpsG7uQs44ELsf+KTTGaaj1LuMFfQoA nQoRCu5TKwt2ykPir8K288pgt6O8yVpH2lov01xHdrTrsqDnyV2IItpEfp9meWMoUc08 WGgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h4-v6si1880741pln.744.2018.04.03.18.18.04; Tue, 03 Apr 2018 18:18:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754895AbeDDBRC (ORCPT + 99 others); Tue, 3 Apr 2018 21:17:02 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:7148 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753124AbeDDBRA (ORCPT ); Tue, 3 Apr 2018 21:17:00 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 53AD42B1151A0; Wed, 4 Apr 2018 09:16:46 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.361.1; Wed, 4 Apr 2018 09:16:39 +0800 Subject: Re: [PATCH] f2fs: remove unmatched zero_user_segment when convert inline dentry To: Yunlong Song , , , CC: , , , , , References: <1522755761-131554-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: <8c280631-71a6-4432-898e-1662b2c6c8a7@huawei.com> Date: Wed, 4 Apr 2018 09:16:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1522755761-131554-1-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/4/3 19:42, Yunlong Song wrote: > Since the layout of regular dentry block is different from inline dentry > block, zero_user_segment starting from MAX_INLINE_DATA(dir) is not > correct for regular dentry block, besides, bitmap is already copied and > used, so there is no necessary to zero page at all, so just remove the > zero_user_segment is OK. > > Signed-off-by: Yunlong Song Reviewed-by: Chao Yu Thanks,